allow significant date to be entered in past (#745)

Co-authored-by: Thomas McInnes <128510230+thomasmcinnes-nimble@users.noreply.github.com>

Author: tristancollen

CHANGELOG.md

@@ -16,6 +16,9 @@ Security in case of vulnerabilities.
 
 ## Unreleased
 
+### Changed
+- [282791](https://dfe-gov-uk.visualstudio.com/Academies-and-Free-Schools-SIP/_workitems/edit/282791) - Removed future date requirement on significant date
+
 See the [full commit history](https://github.com/DFE-Digital/complete-conversions-transfers-changes/compare/production-2026-05-13.1533...main) for everything awaiting release
 
 ---

src/Core/Dfe.Complete.Application/Validation/SignificantDateValidator.cs

@@ -13,11 +13,6 @@ public class SignificantDateValidator : ISignificantDateValidator
 {
     public ValidationResult ValidateSignificantDate(DateOnly? significantDate, ProjectDto? existingProject = null, DateOnly? payrollDeadline = null)
     {
-        // Basic future date validation
-        var futureValidation = ValidateSignificantDateInFuture(significantDate);
-        if (!futureValidation.IsValid)
-            return futureValidation;
-
         // If we have an existing project, check it's not the same as current date
         if (existingProject != null)
         {

src/Tests/Dfe.Complete.Application.Tests/Validators/SignificantDateValidatorTests.cs

@@ -35,7 +35,7 @@ public void ValidateSignificantDate_WithValidFutureDate_AndNoExistingProject_Ret
         }
 
         [Fact]
-        public void ValidateSignificantDate_WithPastDate_ReturnsError()
+        public void ValidateSignificantDate_WithPastDate_ReturnsSuccess()
         {
             // Arrange
             var pastDate = DateOnly.FromDateTime(DateTime.Today.AddDays(-1));
@@ -44,8 +44,7 @@ public void ValidateSignificantDate_WithPastDate_ReturnsError()
             var result = _validator.ValidateSignificantDate(pastDate);
 
             // Assert
-            Assert.False(result.IsValid);
-            Assert.Equal("The Significant date must be in the future.", result.ErrorMessage);
+            Assert.True(result.IsValid);
         }
 
         [Fact]
@@ -78,22 +77,6 @@ public void ValidateSignificantDate_WithSameDateAsExisting_ReturnsError()
             Assert.Equal("The new date cannot be the same as the current date. Check you have entered the correct date.", result.ErrorMessage);
         }
 
-        [Fact]
-        public void ValidateSignificantDate_WithPastDate_ReturnsErrorRegardlessOfExistingProject()
-        {
-            // Arrange
-            var pastDate = DateOnly.FromDateTime(DateTime.Today.AddDays(-1));
-            var currentDate = DateOnly.FromDateTime(DateTime.Today.AddDays(5));
-            var existingProject = CreateTestProject(currentDate);
-
-            // Act
-            var result = _validator.ValidateSignificantDate(pastDate, existingProject);
-
-            // Assert
-            Assert.False(result.IsValid);
-            Assert.Equal("The Significant date must be in the future.", result.ErrorMessage);
-        }
-
         [Fact]
         public void ValidateSignificantDate_WithNullDate_ReturnsSuccess()
         {
@@ -130,7 +113,7 @@ public void ValidateSignificantDate_WithVariousFutureDates_ReturnsSuccess(int da
         [InlineData(-1)] // Yesterday
         [InlineData(-30)] // Last month
         [InlineData(-365)] // Last year
-        public void ValidateSignificantDate_WithVariousPastDates_ReturnsError(int daysInPast)
+        public void ValidateSignificantDate_WithVariousPastDates_ReturnsSuccess(int daysInPast)
         {
             // Arrange
             var pastDate = DateOnly.FromDateTime(DateTime.Today.AddDays(daysInPast));
@@ -139,8 +122,7 @@ public void ValidateSignificantDate_WithVariousPastDates_ReturnsError(int daysIn
             var result = _validator.ValidateSignificantDate(pastDate);
 
             // Assert
-            Assert.False(result.IsValid);
-            Assert.Equal("The Significant date must be in the future.", result.ErrorMessage);
+            Assert.True(result.IsValid);
         }
 
         #endregion
@@ -164,19 +146,18 @@ public void ValidateSignificantDate_WithPayrollDeadline_ValidFutureDate_AndAfter
         }
 
         [Fact]
-        public void ValidateSignificantDate_WithPayrollDeadline_SignificantDateInPast_ReturnsError()
+        public void ValidateSignificantDate_WithPayrollDeadline_SignificantDateInPast_ReturnsSuccess()
         {
             // Arrange
-            var payrollDate = DateOnly.FromDateTime(DateTime.Today.AddDays(5));
+            var payrollDate = DateOnly.FromDateTime(DateTime.Today.AddDays(-5));
             var significantDate = DateOnly.FromDateTime(DateTime.Today.AddDays(-1));
             var existingProject = CreateTestProject(DateOnly.FromDateTime(DateTime.Today.AddDays(15)));
 
             // Act
             var result = _validator.ValidateSignificantDate(significantDate, existingProject, payrollDate);
 
             // Assert
-            Assert.False(result.IsValid);
-            Assert.Equal("The Significant date must be in the future.", result.ErrorMessage);
+            Assert.True(result.IsValid);
         }
 
         [Fact]

src/Tests/Dfe.Complete.CypressTests/cypress/e2e/conversion-tasks/group-two/external-stakeholder-kick-off.cy.ts

@@ -16,7 +16,6 @@ import {
 } from "cypress/support/formatDate";
 import stakeholderKickOffTaskPage from "cypress/pages/projects/tasks/stakeholderKickOffTaskPage";
 import projectDetailsPage from "cypress/pages/projects/projectDetails/projectDetailsPage";
-import validationComponent from "cypress/pages/validationComponent";
 import { ConversionTasksGroupTwoSetup } from "cypress/support/conversionTasksSetup";
 import { urnPool } from "cypress/constants/testUrns";
 
@@ -109,12 +108,6 @@ describe("Conversion tasks - External stakeholder kick off", () => {
         taskListPage.hasTaskStatusCompleted("External stakeholder kick-off");
     });
 
-    it("Should NOT be able to set a conversion date in the past", () => {
-        cy.visit(`projects/${project2Id}/tasks/${taskPath}`);
-        stakeholderKickOffTaskPage.enterSignificantDate(1, 2020).saveAndReturn();
-        validationComponent.hasLinkedValidationError("The Significant date must be in the future");
-    });
-
     it("Should only be able to confirm the conversion date once", () => {
         cy.visit(`projects/${project2Id}/tasks`);
         projectDetailsPage.hasProvisionalDateTag();

src/Tests/Dfe.Complete.CypressTests/cypress/e2e/conversions/change-conversion-date.cy.ts

@@ -187,18 +187,6 @@ describe("Change the conversion date tests", () => {
         projectDetailsPage.doesntContain("Change conversion date");
     });
 
-    it("Should display error when trying to change conversion date to a past date", () => {
-        cy.visit(`projects/${confirmedDateProjectId}/date-history`);
-
-        Logger.log("Click 'Change conversion date' button");
-        projectDetailsPage.clickButton("Change conversion date");
-
-        Logger.log("Enter past date");
-        changeDatePage.enterDate(1, 2025).saveAndContinue();
-
-        validationComponent.hasLinkedValidationError("The Significant date must be in the future");
-    });
-
     it("Should NOT be able to submit a change conversion date request with no reasons selected", () => {
         cy.visit(`projects/${confirmedDateProjectId}/tasks`);
 

src/Tests/Dfe.Complete.CypressTests/cypress/e2e/transfer-tasks/group-two/external-stakeholder-kick-off.cy.ts

@@ -14,7 +14,6 @@ import {
 } from "cypress/support/formatDate";
 import stakeholderKickOffTaskPage from "cypress/pages/projects/tasks/stakeholderKickOffTaskPage";
 import projectDetailsPage from "cypress/pages/projects/projectDetails/projectDetailsPage";
-import validationComponent from "cypress/pages/validationComponent";
 import { urnPool } from "cypress/constants/testUrns";
 import { rdoLondonUser } from "cypress/constants/cypressConstants";
 
@@ -107,12 +106,6 @@ describe("Transfers tasks - External stakeholder kick-off", () => {
             .isUnticked();
     });
 
-    it("Should NOT be able to set a transfer date in the past", () => {
-        cy.visit(`projects/${project2Id}/tasks/stakeholder_kick_off`);
-        stakeholderKickOffTaskPage.enterSignificantDate(1, 2020).saveAndReturn();
-        validationComponent.hasLinkedValidationError("The Significant date must be in the future");
-    });
-
     it("Should only be able to confirm the transfer date once", () => {
         cy.visit(`projects/${project2Id}/tasks`);
         projectDetailsPage.hasProvisionalDateTag();