Tweak testing of DfeAnalytics

Author: starswan

config/initializers/dfe_analytics.rb

@@ -1,14 +1,14 @@
 DfE::Analytics.configure do |config|
   # only enable analytics in review apps/qa/prod or tests where :dfe_analytics tag is present
-  config.enable_analytics = proc { !Rails.env.local? || ENV["ENABLE_DFE_ANALYTICS"] == "true" }
+  config.enable_analytics = -> { !Rails.env.local? || ENV["ENABLE_DFE_ANALYTICS"] == "true" }
   # Whether to log events instead of sending them to BigQuery.
-  #
-  config.log_only = false
+
+  config.log_only = -> { Rails.env.local? && ENV["ENABLE_DFE_ANALYTICS"] != "true" }
 
   config.excluded_paths = ["/check"]
 
   # Whether to use ActiveJob or dispatch events immediately.
-  #
+  # we have tests that assert 'has been enqueued' so changing this is test/dev is problematic
   config.async = true
 
   # Which ActiveJob queue to put events on
@@ -32,7 +32,7 @@
   #
   config.bigquery_api_json_key = ENV.fetch("BIG_QUERY_API_JSON_KEY", nil)
 
-  # Period while DFE Analytics will be set in maintenance mode and the events won'tbe sent to BigQuery.
+  # Period while DFE Analytics will be set in maintenance mode and the events won't be sent to BigQuery.
   # Any event generated during this period will be re-enqueued to be sent later.
   #
   config.bigquery_maintenance_window = "01-08-2024 18:00..01-08-2024 18:30"

spec/system/publishers/publishers_can_message_multiple_job_candidates_spec.rb

@@ -84,6 +84,7 @@
       end
 
       scenario "updating template", :js do
+        expect(page).to have_content "Edit template"
         click_on "Edit template"
         fill_in_trix_editor "message_template_content", with: " "
         click_on "Save template"
@@ -96,7 +97,9 @@
       end
 
       scenario "creating a new template", :js do
+        expect(page).to have_content "Create new template"
         click_on "Create new template"
+        expect(page).to have_content "Save template"
         click_on "Save template"
         expect(page).to have_content "Enter a template name"
 

spec/system/publishers/publishers_can_preview_a_vacancy_spec.rb

@@ -12,12 +12,11 @@
   context "when reviewing a draft vacancy" do
     before do
       visit organisation_job_preview_path(vacancy.id)
-      # wait for page load
-      find("span.govuk-caption-l")
-      find("footer")
     end
 
     it "passes a11y", :a11y do
+      # wait for page load
+      expect(page).to have_content(vacancy.job_title)
       expect(page).to be_axe_clean
     end
 

spec/system/publishers/publishers_can_send_messages_to_applicants_spec.rb

@@ -201,15 +201,12 @@
         login_publisher(publisher: publisher, organisation: organisation)
 
         visit messages_organisation_job_job_application_path(vacancy.id, job_application.id)
-
-        find(".tabs-component")
-        find_by_id("messages-list")
-        find("footer")
       end
 
       after { logout }
 
       it "passes accessibility checks", :a11y do
+        # wait for page load
         expect(page).to have_text("Hello from publisher")
         expect(page).to be_axe_clean
       end