feat: run dirac legacy cs-sync on CS commit

Author: natthan-pigoux

src/DIRAC/ConfigurationSystem/private/Modificator.py

@@ -6,7 +6,7 @@
 
 from diraccfg import CFG
 
-from DIRAC import gLogger
+from DIRAC import S_ERROR
 from DIRAC.ConfigurationSystem.Client.ConfigurationData import gConfigurationData
 from DIRAC.Core.Security.ProxyInfo import getProxyInfo
 from DIRAC.Core.Utilities import List
@@ -244,7 +244,7 @@ def __str__(self):
     def commit(self):
         resVerif = diracxVerifyConfig(self.cfgData)
         if not resVerif["OK"]:
-            gLogger.warn(resVerif["Message"])
+            return S_ERROR(resVerif["Message"])
         compressedData = zlib.compress(str(self.cfgData).encode(), 9)
         return self.rpcClient.commitNewData(compressedData)
 

src/DIRAC/FrameworkSystem/Utilities/diracx.py

@@ -1,12 +1,17 @@
+import os
+import re
+import subprocess
 from collections.abc import Generator
 from contextlib import contextmanager
 from pathlib import Path
 from tempfile import NamedTemporaryFile
+import tempfile
 from typing import Any
 
 import requests
 from cachetools import LRUCache, TTLCache, cached
 from cachetools.keys import hashkey
+from diracx.cli.internal.legacy import _apply_fixes
 from diracx.core.config.schema import Config as DiracxConfig
 from diracx.core.models import TokenResponse
 from diracx.core.preferences import DiracxPreferences
@@ -115,9 +120,17 @@ def diracxVerifyConfig(cfgData):
     Returns:
         S_OK | S_ERROR: Value: diracx Config validation
     """
-    cfg = cfgData.getAsDict()
-    try:
-        validation = DiracxConfig.model_validate(cfg)
-    except ValidationError as exc:
-        return S_ERROR(exc)
-    return S_OK(validation)
+    os.environ["DIRAC_COMPAT_ENABLE_CS_CONVERSION"] = "true"
+    with tempfile.NamedTemporaryFile() as temp_cfg:
+        with tempfile.NamedTemporaryFile() as temp_diracx_cfg:
+            cfgData.writeToFile(temp_cfg)
+            cmd = ["dirac", "internal", "legacy", "cs-sync", temp_cfg, temp_diracx_cfg]
+            res = subprocess.run(cmd, capture_output=True, text=True, timeout=15)
+    os.environ.pop("DIRAC_COMPAT_ENABLE_CS_CONVERSION")
+    if res.returncode == 0:
+        return S_OK(res.stdout)
+    else:
+        err = res.stderr.strip()
+        match = re.search(r"(ValidationError:.*)", err, flags=re.DOTALL)
+        if match:
+            return S_ERROR(match.group(1))