🦄 refactor:Security tidy

Author: DNA-styx

web/includes/class_table.php

@@ -127,7 +127,7 @@ function __construct($columns, $keycol, $sort_default, $sort_default2,
 
 	function start($numitems, $width=100, $align='center')
 	{
-		global $g_options, $game, $realgame, $db;
+		global $game, $realgame, $db;
 		$numpages = ceil($numitems / $this->numperpage);
 ?>
 

web/pages/admintasks/options.php

@@ -64,7 +64,6 @@ function __construct($title)
 
 		function draw ()
 		{
-			global $g_options;
 ?>
 	<h4 class="mb-4 mt-4 text-lg font-semibold text-gray-600 dark:text-gray-300"><?php echo $this->title; ?></h4>
 	<table class="data-table" style="width:75%">

web/pages/admintasks/serversettings.php

@@ -50,9 +50,6 @@ function setdefaults($key)
         // get default values
         $db->query("DELETE FROM hlstats_Servers_Config WHERE serverId=$key;");
         $db->query("INSERT INTO hlstats_Servers_Config (serverId, parameter, value) SELECT $key,parameter,value FROM hlstats_Servers_Config_Default");
-        // get server ip and port
-        $db->query("SELECT CONCAT(address, ':', port) AS addr FROM hlstats_Servers WHERE serverId=$key;");
-        $r = $db->fetch_array();
     }
 
 	if (isset($_GET['key'])) {
@@ -114,9 +111,6 @@ function setdefaults($key)
 			// copy server settings from another server
 			$db->query("DELETE FROM hlstats_Servers_Config WHERE serverId=$key");
 			$db->query("INSERT INTO hlstats_Servers_Config (serverId, parameter, value) SELECT $key,parameter,value FROM hlstats_Servers_Config WHERE serverId=$sourceId");
-			// get server ip and port
-			$db->query("SELECT CONCAT(address, ':', port) AS addr FROM hlstats_Servers WHERE serverId=$key;");
-			$r = $db->fetch_array();
 		} else {
 			if ($edlist->update())
 				message('success', 'Operation successful.');

web/pages/admintasks/tools_synchronize.php

@@ -64,7 +64,6 @@
    function hide_cheaters($query)  {
      global $db;
      $result      = $db->query($query);
-     $cheater     = array();
      $query       = "UPDATE hlstats_Players SET last_event = IF(hideranking <> 2, UNIX_TIMESTAMP(), last_event), hideranking = 2 WHERE playerId IN ";
      $insert_part = "";
      $first       = 0;