✅add tests for getSubject and getSubjectList

Author: OozyGrub

src/index.test.ts

@@ -1,5 +1,4 @@
-import { getFaculty, getFacultyList, getSubjectList } from ".";
-import { Subject } from "./types";
+import { getFaculty, getFacultyList, getSubject, getSubjectList } from ".";
 
 describe("getFacultyList", () => {
   it("should return list of faculties containing: code, name_en, name_th", () => {
@@ -33,24 +32,44 @@ describe("getFaculty", () => {
   });
 });
 
+describe("getSubjectList", () => {
+  it(`should return list of subjects containing correct properties`, () => {
+    const subjectList = getSubjectList();
+    subjectList.forEach((s) => {
+      expect(s).toHaveProperty("code");
+      expect(s).toHaveProperty("abbr");
+      expect(s).toHaveProperty("facultyCode");
+      expect(s).toHaveProperty("name");
+      expect(s).toHaveProperty("isClosed");
+      expect(s).toHaveProperty("openSemester");
+      expect(s).toHaveProperty("closeSemester");
+    });
+  });
+});
+
 describe("getSubject", () => {
-  describe(`when getting subjects from facultyId`, () => {
-    it(`should not be undefined`, async () => {
-      const subjectList = await getSubjectList("");
-      //expect(subjectList).not.toBeUndefined();
-    }, 30000);
-    // it("should return list of subjects with correct properties", async () => {
-    //   const subjectList = await getSubjectList("");
-    //   if (subjectList === undefined) throw Error("subjectList is undefined");
-    //   subjectList.forEach((s) => {
-    //     expect(s).toHaveProperty("code");
-    //     expect(s).toHaveProperty("abbr");
-    //     expect(s).toHaveProperty("facultyCode");
-    //     expect(s).toHaveProperty("name");
-    //     expect(s).toHaveProperty("isClosed");
-    //     expect(s).toHaveProperty("openSemester");
-    //     expect(s).toHaveProperty("closeSemester");
-    //   });
-    // });
+  it(`should return subject from the subject code specified`, () => {
+    expect(getSubject("2000501")).toEqual({
+      code: "2000501",
+      facultyCode: "20",
+      abbr: "CON PDG PEACE CONF",
+      name: {
+        en: "CONCEPTS AND PARADIGMS IN PEACE AND CONFLICT STUDIES",
+        th: "มโนทัศน์และกระบวนทัศน์ในการศึกษาสันติภาพและความขัดแย้ง",
+      },
+      isClosed: false,
+      openSemester: "1/2552",
+    });
+    expect(getSubject("2110413")).toEqual({
+      code: "2110413",
+      facultyCode: "21",
+      abbr: "COMP SECURITY",
+      name: {
+        en: "COMPUTER SECURITY",
+        th: "ความมั่นคงของคอมพิวเตอร์",
+      },
+      isClosed: false,
+      openSemester: "2/2546",
+    });
   });
 });