Skip to content

The Windows build fails due to non-standard C++ code #39

@andyburras

Description

@andyburras
  • In PostprocessData.cpp:

for (int j = i; list[j].offset < (offset + segmentSizes[index]); j++) {
...
}
errprint("[...]",index, list[j].offset);

Does not obey C++ standard rules - the scope of the name(s) declared extends to the end of the for statement.

  • In ValidateAtoms.cpp:

char vsdi_name[strlen(vsdi.name)];
and saio_offset ...

Using non-standard C++ dynamic array lengths - (this has been adopted by the C standard and is supported in g++, but it is not in the C++ standard).

  • In ValidateMP4.h:

true and false are #defined.

C++ Standard Library forbids macroizing keywords

  • Plus Visual Studio projects do not compile with latest (2017) VS version.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions