fixup! Delete inactive function versions at deploy time (#5927)

Author: dsotirho-ucsc

scripts/delete_older_function_versions.py

@@ -1,5 +1,5 @@
 """
-Delete all published versions of the AWS Lambda function except for the version specified to keep.
+Delete all versions of a Lambda function prior to the specified one.
 """
 import argparse
 import logging
@@ -32,6 +32,7 @@ def main(argv: list[str]):
                         required=True,
                         help='The name of the Lambda function')
     parser.add_argument('--function-version', '-v',
+                        type=int,
                         required=True,
                         help='The Lambda function version to keep')
     args = parser.parse_args(argv)

src/azul/lambdas.py

@@ -116,10 +116,9 @@ def list_lambdas(self) -> list[Lambda]:
 
     def delete_older_function_versions(self,
                                        function_name: str,
-                                       keep_version: str) -> None:
+                                       keep_version: int) -> None:
         """
         Delete all versions of a Lambda function prior to the specified one.
-        Raises an error if the specified version does not exist.
 
         :param function_name: The fully qualified name of the function
                               e.g. 'azul-service-dev'
@@ -132,15 +131,9 @@ def delete_older_function_versions(self,
             for function in page['Versions']
             if (
                 function['Version'] != '$LATEST'  # The so-called "unpublished" version
-                and int(function['Version']) <= int(keep_version)
+                and int(function['Version']) < keep_version
             )
         ]
-        try:
-            versions.remove(keep_version)
-        except ValueError:
-            assert False, R(
-                'Function version not found',
-                function_name, keep_version, versions)
         for version in versions:
             log.info('Deleting version %r of %r', version, function_name)
             self._lambda.delete_function(FunctionName=function_name,