Fix: Repeat manifest requests after failed generation raise InvalidGeneration (DataBiosphere/azul-private#212) #7453

hannes-ucsc · 2025-10-01T05:59:12Z

Linked issues: https://github.com/DataBiosphere/azul-private/issues/212

Checklist

Author

PR is assigned to the author
PR is a draft
Target branch is develop
Name of PR branch matches issues/<GitHub handle of author>/<issue#>-<slug>
PR is linked to all issues it (partially) resolves
PR description links to connected issues
PR title matches¹ that of a linked issue _{or comment in PR explains why they're different}
PR title references all linked issues
For each linked issue, there is at least one commit whose title references that issue

¹ when the issue title describes a problem, the corresponding PR
title is Fix: followed by the issue title

Author (partiality)

Added p tag to titles of partial commits
This PR is labeled partial _{or completely resolves all linked issues}
This PR partially resolves each of the linked issues _{or does not have the partial label}

Author (reindex)

Added r tag to commit title _{or the changes introduced by this PR will not require reindexing of any deployment}
This PR is labeled reindex:dev _{or the changes introduced by it will not require reindexing of dev}
This PR is labeled reindex:anvildev _{or the changes introduced by it will not require reindexing of anvildev}
This PR is labeled reindex:anvilprod _{or the changes introduced by it will not require reindexing of anvilprod}
This PR is labeled reindex:prod _{or the changes introduced by it will not require reindexing of prod}
This PR is labeled reindex:partial and its description documents the specific reindexing procedure for dev, anvildev, anvilprod and prod _{or requires a full reindex or carries none of the labels reindex:dev, reindex:anvildev, reindex:anvilprod and reindex:prod}

Author (API changes)

This PR and its linked issues are labeled API _{or this PR does not modify a REST API}
Added a (A) tag to commit title for backwards (in)compatible changes _{or this PR does not modify a REST API}
Updated REST API version number in app.py _{or this PR does not modify a REST API}

Author (upgrading deployments)

Ran make docker_images.json and committed the resulting changes _{or this PR does not modify azul_docker_images, or any other variables referenced in the definition of that variable}
Documented upgrading of deployments in UPGRADING.rst _{or this PR does not require upgrading deployments}
Added u tag to commit title _{or this PR does not require upgrading deployments}
This PR is labeled upgrade _{or does not require upgrading deployments}
This PR is labeled deploy:shared _{or does not modify docker_images.json, and does not require deploying the shared component for any other reason}
This PR is labeled deploy:gitlab _{or does not require deploying the gitlab component}
This PR is labeled deploy:runner _{or does not require deploying the runner image}

Author (hotfixes)

Added F tag to main commit title _{or this PR does not include permanent fix for a temporary hotfix}
Reverted the temporary hotfixes for any linked issues _{or the none of the stable branches (anvilprod and prod) have temporary hotfixes for any of the issues linked to this PR}

Author (before every review)

Rebased PR branch on develop, squashed fixups from prior reviews
Ran make requirements_update _{or this PR does not modify requirements*.txt, common.mk, Makefile, Dockerfile or environment.boot}
Added R tag to commit title _{or this PR does not modify requirements*.txt}
This PR is labeled reqs _{or does not modify requirements*.txt}
make integration_test passes in personal deployment _{or this PR does not modify functionality that could affect the IT outcome}
PR is awaiting requested review from a peer
Status of PR is Review requested
PR is assigned to only the peer

Peer reviewer (after approval)

Note that when requesting changes, the PR must be assigned back to the author.

Actually approved the PR
PR is not a draft
PR is awaiting requested review from system administrator
Status of PR is Review requested
PR is assigned to only the system administrator

System administrator (after approval)

Actually approved the PR
Labeled linked issues as demo or no demo
Commented on linked issues about demo expectations _{or all linked issues are labeled no demo}
Decided if PR can be labeled no sandbox
A comment to this PR details the completed security design review
PR title is appropriate as title of merge commit
N reviews label is accurate
Status of PR is Approved
PR is assigned to only the operator

Operator

Checked reindex:… labels and r commit title tag
Checked that demo expectations are clear _{or all linked issues are labeled no demo}
Squashed PR branch and rebased onto develop
Sanity-checked history
Pushed PR branch to GitHub

Operator (deploy `.shared` and `.gitlab` components)

Ran _select dev.shared && CI_COMMIT_REF_NAME=develop make -C terraform/shared apply_keep_unused _{or this PR is not labeled deploy:shared}
Ran _select dev.gitlab && CI_COMMIT_REF_NAME=develop make -C terraform/gitlab apply _{or this PR is not labeled deploy:gitlab}
Ran _select anvildev.shared && CI_COMMIT_REF_NAME=develop make -C terraform/shared apply_keep_unused _{or this PR is not labeled deploy:shared}
Ran _select anvildev.gitlab && CI_COMMIT_REF_NAME=develop make -C terraform/gitlab apply _{or this PR is not labeled deploy:gitlab}
Checked the items in the next section _{or this PR is labeled deploy:gitlab}
PR is assigned to only the system administrator _{or this PR is not labeled deploy:gitlab}

System administrator (post-deploy of `.gitlab` component)

Background migrations for dev.gitlab are complete _{or this PR is not labeled deploy:gitlab}
Background migrations for anvildev.gitlab are complete _{or this PR is not labeled deploy:gitlab}
PR is assigned to only the operator

Operator (deploy runner image)

Ran _select dev.gitlab && make -C terraform/gitlab/runner _{or this PR is not labeled deploy:runner}
Ran _select anvildev.gitlab && make -C terraform/gitlab/runner _{or this PR is not labeled deploy:runner}

Operator (sandbox build)

Operator (merge the branch)

All status checks passed and the PR is mergeable
The title of the merge commit starts with the title of this PR
Added PR # reference to merge commit title
Collected commit title tags in merge commit title _{but only included p if the PR is also labeled partial}
Pushed merge commit to GitHub
Status of PR is Merged lower
Status of blocked issues is Triage _{or no issues are blocked on the linked issues}

Operator (main build)

Operator (reindex)

Operator (mirroring)

Started mirroring in dev _{or this PR does not require mirroring dev}
Started mirroring in anvildev _{or this PR does not require mirroring anvildev}
Checked for, triaged and possibly requeued messages in mirror fail queue in dev _{or this PR does not require mirroring dev}
Checked for, triaged and possibly requeued messages in mirror fail queue in anvildev _{or this PR does not require mirroring anvildev}
Emptied mirror fail queue in dev _{or this PR does not require mirroring dev}
Emptied mirror fail queue in anvildev _{or this PR does not require mirroring anvildev}

Operator

Propagated the deploy:shared, deploy:gitlab, deploy:runner, API, reindex:partial, reindex:anvilprod and reindex:prod labels to the next promotion PRs _{or this PR carries none of these labels}
Propagated any specific instructions related to the deploy:shared, deploy:gitlab, deploy:runner, API, reindex:partial, reindex:anvilprod and reindex:prod labels, from the description of this PR to that of the next promotion PRs _{or this PR carries none of these labels}
PR is assigned to no one

Shorthand for review comments

L line is too long
W line wrapping is wrong
Q bad quotes
F other formatting problem

coveralls · 2025-10-01T06:14:54Z

coverage: 85.385% (+0.02%) from 85.362%
when pulling d21b07d on issues/hannes-ucsc/212-manifest-filters
into d56a238 on develop.

codecov · 2025-10-01T06:20:59Z

Codecov Report

❌ Patch coverage is 95.61404% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.14%. Comparing base (d56a238) to head (d21b07d).
⚠️ Report is 10 commits behind head on develop.

Files with missing lines	Patch %	Lines
src/azul/service/app_controller.py	33.33%	4 Missing ⚠️
src/azul/service/__init__.py	99.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #7453      +/-   ##
===========================================
- Coverage    85.16%   85.14%   -0.02%     
===========================================
  Files          155      155              
  Lines        22296    22293       -3     
===========================================
- Hits         18989    18982       -7     
- Misses        3307     3311       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

hannes-ucsc · 2025-10-02T18:05:58Z

Sequence -> list

str -> FieldName

Use proper type aliases

Introduce type alias for range ends

Rename FilterOperator to FilterJSON

…alidGeneration (DataBiosphere/azul-private#212) Add test

…alidGeneration (DataBiosphere/azul-private#212) Add fix

dsotirho-ucsc

Pro forma approval

github-actions bot added the orange label Oct 1, 2025

hannes-ucsc force-pushed the issues/hannes-ucsc/212-manifest-filters branch 2 times, most recently from d266867 to 2d14ce5 Compare October 1, 2025 06:07

hannes-ucsc self-assigned this Oct 1, 2025

hannes-ucsc changed the title ~~Issues/hannes ucsc/212 manifest filters~~ Fix: Repeat manifest requests after failed generation raise InvalidGeneration (DataBiosphere/azul-private#212) Oct 1, 2025

hannes-ucsc force-pushed the issues/hannes-ucsc/212-manifest-filters branch from 2d14ce5 to 5f6c5d9 Compare October 1, 2025 06:38

hannes-ucsc removed the orange label Oct 2, 2025

hannes-ucsc mentioned this pull request Oct 2, 2025

500 error on malformed filter #7403

Open

hannes-ucsc assigned dsotirho-ucsc and unassigned hannes-ucsc Oct 2, 2025

hannes-ucsc added 9 commits October 2, 2025 17:47

[1/5] Refactor FiltersJSON

8eefc8c

Sequence -> list

[2/5] Refactor FiltersJSON

64b6f2a

str -> FieldName

[3/5] Refactor FiltersJSON

93c2bed

Use proper type aliases

[4/5] Refactor FiltersJSON

406e6c9

Introduce type alias for range ends

[5/5] Refactor FiltersJSON

882999a

Rename FilterOperator to FilterJSON

Simplify function in app module

dcb5b73

Inline function in app module

6430dfd

[1/2] Fix: Repeat manifest requests after failed generation raise Inv…

07a347c

…alidGeneration (DataBiosphere/azul-private#212) Add test

[2/2] Fix: Repeat manifest requests after failed generation raise Inv…

d21b07d

…alidGeneration (DataBiosphere/azul-private#212) Add fix

dsotirho-ucsc force-pushed the issues/hannes-ucsc/212-manifest-filters branch from 632cb3c to d21b07d Compare October 3, 2025 00:48

dsotirho-ucsc added the sandbox [process] Resolution is being verified in sandbox deployment label Oct 3, 2025

dsotirho-ucsc approved these changes Oct 3, 2025

View reviewed changes

dsotirho-ucsc merged commit 1e8b3ea into develop Oct 3, 2025
10 checks passed

dsotirho-ucsc deleted the issues/hannes-ucsc/212-manifest-filters branch October 3, 2025 03:07

dsotirho-ucsc removed their assignment Oct 3, 2025

hannes-ucsc linked an issue Oct 12, 2025 that may be closed by this pull request

500 error on malformed filter #7403

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix: Repeat manifest requests after failed generation raise InvalidGeneration (DataBiosphere/azul-private#212) #7453

Fix: Repeat manifest requests after failed generation raise InvalidGeneration (DataBiosphere/azul-private#212) #7453

Uh oh!

hannes-ucsc commented Oct 1, 2025 •

edited by dsotirho-ucsc

Loading

Uh oh!

coveralls commented Oct 1, 2025 •

edited

Loading

Uh oh!

codecov bot commented Oct 1, 2025 •

edited

Loading

Uh oh!

hannes-ucsc commented Oct 2, 2025

Uh oh!

dsotirho-ucsc left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Fix: Repeat manifest requests after failed generation raise InvalidGeneration (DataBiosphere/azul-private#212) #7453

Fix: Repeat manifest requests after failed generation raise InvalidGeneration (DataBiosphere/azul-private#212) #7453

Uh oh!

Conversation

hannes-ucsc commented Oct 1, 2025 • edited by dsotirho-ucsc Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Author

Author (partiality)

Author (reindex)

Author (API changes)

Author (upgrading deployments)

Author (hotfixes)

Author (before every review)

Peer reviewer (after approval)

System administrator (after approval)

Operator

Operator (deploy .shared and .gitlab components)

System administrator (post-deploy of .gitlab component)

Operator (deploy runner image)

Operator (sandbox build)

Operator (merge the branch)

Operator (main build)

Operator (reindex)

Operator (mirroring)

Operator

Shorthand for review comments

Uh oh!

coveralls commented Oct 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Oct 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

hannes-ucsc commented Oct 2, 2025

Security design review

Uh oh!

dsotirho-ucsc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

hannes-ucsc commented Oct 1, 2025 •

edited by dsotirho-ucsc

Loading

Operator (deploy `.shared` and `.gitlab` components)

System administrator (post-deploy of `.gitlab` component)

coveralls commented Oct 1, 2025 •

edited

Loading

codecov bot commented Oct 1, 2025 •

edited

Loading