From 9b541aa02735b37d890ca2c283113288d08ed087 Mon Sep 17 00:00:00 2001 From: Ganesh Jangir Date: Wed, 20 Aug 2025 15:48:22 +0200 Subject: [PATCH 1/3] chore(trace-exporter): enable data pipeline based on Windows --- tracer/src/Datadog.Trace/Configuration/TracerSettings.cs | 2 +- tracer/src/Datadog.Trace/FrameworkDescription.cs | 5 +++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/tracer/src/Datadog.Trace/Configuration/TracerSettings.cs b/tracer/src/Datadog.Trace/Configuration/TracerSettings.cs index 43389010ed24..e036295814af 100644 --- a/tracer/src/Datadog.Trace/Configuration/TracerSettings.cs +++ b/tracer/src/Datadog.Trace/Configuration/TracerSettings.cs @@ -411,7 +411,7 @@ internal TracerSettings(IConfigurationSource? source, IConfigurationTelemetry te DataPipelineEnabled = config .WithKeys(ConfigurationKeys.TraceDataPipelineEnabled) - .AsBool(defaultValue: false); + .AsBool(defaultValue: FrameworkDescription.Instance.IsWindows()); if (DataPipelineEnabled) { diff --git a/tracer/src/Datadog.Trace/FrameworkDescription.cs b/tracer/src/Datadog.Trace/FrameworkDescription.cs index 486c4ede95a3..694576fc598e 100644 --- a/tracer/src/Datadog.Trace/FrameworkDescription.cs +++ b/tracer/src/Datadog.Trace/FrameworkDescription.cs @@ -69,6 +69,11 @@ public bool IsWindows() return string.Equals(OSPlatform, OSPlatformName.Windows, StringComparison.OrdinalIgnoreCase); } + public bool IsLinux() + { + return string.Equals(OSPlatform, OSPlatformName.Linux, StringComparison.OrdinalIgnoreCase); + } + public override string ToString() { // examples: From 457c3438927e56257036d5d42f70db4b3499f696 Mon Sep 17 00:00:00 2001 From: Ganesh Jangir Date: Wed, 20 Aug 2025 17:04:09 +0200 Subject: [PATCH 2/3] fix: change log warnings to information for data pipeline disabling --- .../src/Datadog.Trace/Configuration/TracerSettings.cs | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tracer/src/Datadog.Trace/Configuration/TracerSettings.cs b/tracer/src/Datadog.Trace/Configuration/TracerSettings.cs index e036295814af..373fb1ae08d3 100644 --- a/tracer/src/Datadog.Trace/Configuration/TracerSettings.cs +++ b/tracer/src/Datadog.Trace/Configuration/TracerSettings.cs @@ -420,7 +420,7 @@ internal TracerSettings(IConfigurationSource? source, IConfigurationTelemetry te if (StatsComputationEnabled) { DataPipelineEnabled = false; - Log.Warning( + Log.Information( $"{ConfigurationKeys.TraceDataPipelineEnabled} is enabled, but {ConfigurationKeys.StatsComputationEnabled} is enabled. Disabling data pipeline."); _telemetry.Record(ConfigurationKeys.TraceDataPipelineEnabled, false, ConfigurationOrigins.Calculated); } @@ -430,7 +430,7 @@ internal TracerSettings(IConfigurationSource? source, IConfigurationTelemetry te if (Exporter.TracesTransport == TracesTransportType.UnixDomainSocket && FrameworkDescription.Instance.IsWindows()) { DataPipelineEnabled = false; - Log.Warning( + Log.Information( $"{ConfigurationKeys.TraceDataPipelineEnabled} is enabled, but TracesTransport is set to UnixDomainSocket which is not supported on Windows. Disabling data pipeline."); _telemetry.Record(ConfigurationKeys.TraceDataPipelineEnabled, false, ConfigurationOrigins.Calculated); } @@ -440,13 +440,13 @@ internal TracerSettings(IConfigurationSource? source, IConfigurationTelemetry te DataPipelineEnabled = false; if (isLibDatadogAvailable.Exception is not null) { - Log.Warning( + Log.Information( isLibDatadogAvailable.Exception, $"{ConfigurationKeys.TraceDataPipelineEnabled} is enabled, but libdatadog is not available. Disabling data pipeline."); } else { - Log.Warning( + Log.Information( $"{ConfigurationKeys.TraceDataPipelineEnabled} is enabled, but libdatadog is not available. Disabling data pipeline."); } @@ -459,7 +459,7 @@ internal TracerSettings(IConfigurationSource? source, IConfigurationTelemetry te if (!string.IsNullOrEmpty(EnvironmentHelpers.GetEnvironmentVariable("DD_INJECTION_ENABLED"))) { DataPipelineEnabled = false; - Log.Warning( + Log.Information( $"{ConfigurationKeys.TraceDataPipelineEnabled} is enabled, but SSI is enabled. Disabling data pipeline."); _telemetry.Record(ConfigurationKeys.TraceDataPipelineEnabled, false, ConfigurationOrigins.Calculated); } From 24c390fe44d6d284c99c52dc56cca5d2daf9dfb6 Mon Sep 17 00:00:00 2001 From: Ganesh Jangir Date: Mon, 1 Sep 2025 10:59:41 +0200 Subject: [PATCH 3/3] refactor(FrameworkDescription): remove IsLinux method --- tracer/src/Datadog.Trace/FrameworkDescription.cs | 5 ----- 1 file changed, 5 deletions(-) diff --git a/tracer/src/Datadog.Trace/FrameworkDescription.cs b/tracer/src/Datadog.Trace/FrameworkDescription.cs index 694576fc598e..486c4ede95a3 100644 --- a/tracer/src/Datadog.Trace/FrameworkDescription.cs +++ b/tracer/src/Datadog.Trace/FrameworkDescription.cs @@ -69,11 +69,6 @@ public bool IsWindows() return string.Equals(OSPlatform, OSPlatformName.Windows, StringComparison.OrdinalIgnoreCase); } - public bool IsLinux() - { - return string.Equals(OSPlatform, OSPlatformName.Linux, StringComparison.OrdinalIgnoreCase); - } - public override string ToString() { // examples: