Add null-safety unit tests for UDFs (#191)

ferenc-csaky · web-flow · commit 00b8e28c5d54 · 2025-09-02T19:20:27.000+02:00
diff --git a/stdlib/stdlib-commons/src/test/java/com/datasqrl/flinkrunner/stdlib/commons/SerializeToBytesTest.java b/stdlib/stdlib-commons/src/test/java/com/datasqrl/flinkrunner/stdlib/commons/SerializeToBytesTest.java
@@ -0,0 +1,31 @@
+/*
+ * Copyright © 2025 DataSQRL (contact@datasqrl.com)
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package com.datasqrl.flinkrunner.stdlib.commons;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+import org.junit.jupiter.api.Test;
+
+class SerializeToBytesTest {
+
+  @Test
+  public void testNullInput() {
+    var function = new serialize_to_bytes();
+    var result = function.eval(null);
+
+    assertThat(result).isNull();
+  }
+}
diff --git a/stdlib/stdlib-vector/src/main/java/com/datasqrl/flinkrunner/stdlib/vector/VectorFunctions.java b/stdlib/stdlib-vector/src/main/java/com/datasqrl/flinkrunner/stdlib/vector/VectorFunctions.java
@@ -25,7 +25,7 @@ public class VectorFunctions {
 
   public static final euclidean_distance EUCLIDEAN_DISTANCE = new euclidean_distance();
 
-  public static final vector_to_double VEC_TO_DOUBLE = new vector_to_double();
+  public static final vector_to_double VECTOR_TO_DOUBLE = new vector_to_double();
 
   public static final double_to_vector DOUBLE_TO_VECTOR = new double_to_vector();
 
@@ -38,7 +38,7 @@ public class VectorFunctions {
           COSINE_SIMILARITY,
           COSINE_DISTANCE,
           EUCLIDEAN_DISTANCE,
-          VEC_TO_DOUBLE,
+          VECTOR_TO_DOUBLE,
           DOUBLE_TO_VECTOR,
           ASCII_TEXT_TEST_EMBED,
           CENTER);
diff --git a/stdlib/stdlib-vector/src/main/java/com/datasqrl/flinkrunner/stdlib/vector/center.java b/stdlib/stdlib-vector/src/main/java/com/datasqrl/flinkrunner/stdlib/vector/center.java
@@ -15,7 +15,7 @@
  */
 package com.datasqrl.flinkrunner.stdlib.vector;
 
-import static com.datasqrl.flinkrunner.stdlib.vector.VectorFunctions.VEC_TO_DOUBLE;
+import static com.datasqrl.flinkrunner.stdlib.vector.VectorFunctions.VECTOR_TO_DOUBLE;
 import static com.datasqrl.flinkrunner.stdlib.vector.VectorFunctions.convert;
 
 import com.datasqrl.flinkrunner.stdlib.utils.AutoRegisterSystemFunction;
@@ -47,11 +47,11 @@ public FlinkVectorType getValue(CenterAccumulator acc) {
   }
 
   public void accumulate(CenterAccumulator acc, FlinkVectorType vector) {
-    acc.add(VEC_TO_DOUBLE.eval(vector));
+    acc.add(VECTOR_TO_DOUBLE.eval(vector));
   }
 
   public void retract(CenterAccumulator acc, FlinkVectorType vector) {
-    acc.substract(VEC_TO_DOUBLE.eval(vector));
+    acc.substract(VECTOR_TO_DOUBLE.eval(vector));
   }
 
   public void merge(CenterAccumulator acc, Iterable<CenterAccumulator> iter) {
diff --git a/stdlib/stdlib-vector/src/main/java/com/datasqrl/flinkrunner/stdlib/vector/cosine_similarity.java b/stdlib/stdlib-vector/src/main/java/com/datasqrl/flinkrunner/stdlib/vector/cosine_similarity.java
@@ -15,7 +15,7 @@
  */
 package com.datasqrl.flinkrunner.stdlib.vector;
 
-import static com.datasqrl.flinkrunner.stdlib.vector.VectorFunctions.VEC_TO_DOUBLE;
+import static com.datasqrl.flinkrunner.stdlib.vector.VectorFunctions.VECTOR_TO_DOUBLE;
 
 import com.datasqrl.flinkrunner.stdlib.utils.AutoRegisterSystemFunction;
 import com.google.auto.service.AutoService;
@@ -35,8 +35,8 @@ public Double eval(FlinkVectorType vectorA, FlinkVectorType vectorB) {
     }
 
     // Create RealVectors from the input arrays
-    RealVector vA = new ArrayRealVector(VEC_TO_DOUBLE.eval(vectorA), false);
-    RealVector vB = new ArrayRealVector(VEC_TO_DOUBLE.eval(vectorB), false);
+    RealVector vA = new ArrayRealVector(VECTOR_TO_DOUBLE.eval(vectorA), false);
+    RealVector vB = new ArrayRealVector(VECTOR_TO_DOUBLE.eval(vectorB), false);
 
     // Calculate the cosine similarity
     var dotProduct = vA.dotProduct(vB);
diff --git a/stdlib/stdlib-vector/src/main/java/com/datasqrl/flinkrunner/stdlib/vector/euclidean_distance.java b/stdlib/stdlib-vector/src/main/java/com/datasqrl/flinkrunner/stdlib/vector/euclidean_distance.java
@@ -15,7 +15,7 @@
  */
 package com.datasqrl.flinkrunner.stdlib.vector;
 
-import static com.datasqrl.flinkrunner.stdlib.vector.VectorFunctions.VEC_TO_DOUBLE;
+import static com.datasqrl.flinkrunner.stdlib.vector.VectorFunctions.VECTOR_TO_DOUBLE;
 
 import com.datasqrl.flinkrunner.stdlib.utils.AutoRegisterSystemFunction;
 import com.google.auto.service.AutoService;
@@ -35,8 +35,8 @@ public Double eval(FlinkVectorType vectorA, FlinkVectorType vectorB) {
     }
 
     // Create RealVectors from the input arrays
-    RealVector vA = new ArrayRealVector(VEC_TO_DOUBLE.eval(vectorA), false);
-    RealVector vB = new ArrayRealVector(VEC_TO_DOUBLE.eval(vectorB), false);
+    RealVector vA = new ArrayRealVector(VECTOR_TO_DOUBLE.eval(vectorA), false);
+    RealVector vB = new ArrayRealVector(VECTOR_TO_DOUBLE.eval(vectorB), false);
 
     return vA.getDistance(vB);
   }
diff --git a/stdlib/stdlib-vector/src/test/java/com/datasqrl/flinkrunner/stdlib/vector/AsciiTextTestEmbedTest.java b/stdlib/stdlib-vector/src/test/java/com/datasqrl/flinkrunner/stdlib/vector/AsciiTextTestEmbedTest.java
@@ -0,0 +1,40 @@
+/*
+ * Copyright © 2025 DataSQRL (contact@datasqrl.com)
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package com.datasqrl.flinkrunner.stdlib.vector;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+import org.junit.jupiter.api.Test;
+
+class AsciiTextTestEmbedTest {
+
+  @Test
+  public void testNullInputReturnsNull() {
+    var function = new ascii_text_test_embed();
+    var result = function.eval(null);
+
+    assertThat(result).isNull();
+  }
+
+  @Test
+  public void testValidInputReturnsVector() {
+    var function = new ascii_text_test_embed();
+    var result = function.eval("test");
+
+    assertThat(result).isNotNull();
+    assertThat(result.getValue()).hasSize(256);
+  }
+}
diff --git a/stdlib/stdlib-vector/src/test/java/com/datasqrl/flinkrunner/stdlib/vector/CosineDistanceTest.java b/stdlib/stdlib-vector/src/test/java/com/datasqrl/flinkrunner/stdlib/vector/CosineDistanceTest.java
@@ -0,0 +1,47 @@
+/*
+ * Copyright © 2025 DataSQRL (contact@datasqrl.com)
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package com.datasqrl.flinkrunner.stdlib.vector;
+
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.within;
+
+import org.junit.jupiter.api.Test;
+
+class CosineDistanceTest {
+
+  @Test
+  public void testNullInputsReturnNull() {
+    var function = new cosine_distance();
+
+    assertThat(function.eval(null, null)).isNull();
+
+    var vector = new FlinkVectorType(new double[] {1.0, 2.0, 3.0});
+    assertThat(function.eval(null, vector)).isNull();
+    assertThat(function.eval(vector, null)).isNull();
+  }
+
+  @Test
+  public void testValidInputsReturnDistance() {
+    var function = new cosine_distance();
+
+    var vector1 = new FlinkVectorType(new double[] {1.0, 0.0, 0.0});
+    var vector2 = new FlinkVectorType(new double[] {1.0, 0.0, 0.0});
+
+    var result = function.eval(vector1, vector2);
+    assertThat(result).isNotNull();
+    assertThat(result).isCloseTo(0.0, within(1e-7));
+  }
+}
diff --git a/stdlib/stdlib-vector/src/test/java/com/datasqrl/flinkrunner/stdlib/vector/CosineSimilarityTest.java b/stdlib/stdlib-vector/src/test/java/com/datasqrl/flinkrunner/stdlib/vector/CosineSimilarityTest.java
@@ -0,0 +1,47 @@
+/*
+ * Copyright © 2025 DataSQRL (contact@datasqrl.com)
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package com.datasqrl.flinkrunner.stdlib.vector;
+
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.within;
+
+import org.junit.jupiter.api.Test;
+
+class CosineSimilarityTest {
+
+  @Test
+  public void testNullInputsReturnNull() {
+    var function = new cosine_similarity();
+
+    assertThat(function.eval(null, null)).isNull();
+
+    var vector = new FlinkVectorType(new double[] {1.0, 2.0, 3.0});
+    assertThat(function.eval(null, vector)).isNull();
+    assertThat(function.eval(vector, null)).isNull();
+  }
+
+  @Test
+  public void testValidInputsReturnSimilarity() {
+    var function = new cosine_similarity();
+
+    var vector1 = new FlinkVectorType(new double[] {1.0, 0.0, 0.0});
+    var vector2 = new FlinkVectorType(new double[] {1.0, 0.0, 0.0});
+
+    var result = function.eval(vector1, vector2);
+    assertThat(result).isNotNull();
+    assertThat(result).isCloseTo(1.0, within(1e-7));
+  }
+}
diff --git a/stdlib/stdlib-vector/src/test/java/com/datasqrl/flinkrunner/stdlib/vector/DoubleToVectorTest.java b/stdlib/stdlib-vector/src/test/java/com/datasqrl/flinkrunner/stdlib/vector/DoubleToVectorTest.java
@@ -0,0 +1,41 @@
+/*
+ * Copyright © 2025 DataSQRL (contact@datasqrl.com)
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package com.datasqrl.flinkrunner.stdlib.vector;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+import org.junit.jupiter.api.Test;
+
+class DoubleToVectorTest {
+
+  @Test
+  public void testNullInputReturnsNull() {
+    var function = new double_to_vector();
+    var result = function.eval(null);
+
+    assertThat(result).isNull();
+  }
+
+  @Test
+  public void testValidInputReturnsVector() {
+    var function = new double_to_vector();
+    var input = new double[] {1.0, 2.0, 3.0};
+    var result = function.eval(input);
+
+    assertThat(result).isNotNull();
+    assertThat(result.getValue()).containsExactly(1.0, 2.0, 3.0);
+  }
+}
diff --git a/stdlib/stdlib-vector/src/test/java/com/datasqrl/flinkrunner/stdlib/vector/EuclideanDistanceTest.java b/stdlib/stdlib-vector/src/test/java/com/datasqrl/flinkrunner/stdlib/vector/EuclideanDistanceTest.java
@@ -0,0 +1,47 @@
+/*
+ * Copyright © 2025 DataSQRL (contact@datasqrl.com)
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package com.datasqrl.flinkrunner.stdlib.vector;
+
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.within;
+
+import org.junit.jupiter.api.Test;
+
+class EuclideanDistanceTest {
+
+  @Test
+  public void testNullInputsReturnNull() {
+    var function = new euclidean_distance();
+
+    assertThat(function.eval(null, null)).isNull();
+
+    var vector = new FlinkVectorType(new double[] {1.0, 2.0, 3.0});
+    assertThat(function.eval(null, vector)).isNull();
+    assertThat(function.eval(vector, null)).isNull();
+  }
+
+  @Test
+  public void testValidInputsReturnDistance() {
+    var function = new euclidean_distance();
+
+    var vector1 = new FlinkVectorType(new double[] {1.0, 0.0, 0.0});
+    var vector2 = new FlinkVectorType(new double[] {0.0, 0.0, 0.0});
+
+    var result = function.eval(vector1, vector2);
+    assertThat(result).isNotNull();
+    assertThat(result).isCloseTo(1.0, within(1e-7));
+  }
+}
diff --git a/stdlib/stdlib-vector/src/test/java/com/datasqrl/flinkrunner/stdlib/vector/VectorFunctionsTest.java b/stdlib/stdlib-vector/src/test/java/com/datasqrl/flinkrunner/stdlib/vector/VectorFunctionsTest.java
@@ -1187,6 +1187,57 @@ class VectorFunctionsTest {
     }
   };
 
+  @Test
+  public void testNullSafetyVectorUDFs() {
+    // Test cosine_similarity with null inputs
+    assertThat(VectorFunctions.COSINE_SIMILARITY.eval(null, null)).isNull();
+    assertThat(
+            VectorFunctions.COSINE_SIMILARITY.eval(
+                null, VectorFunctions.DOUBLE_TO_VECTOR.eval(VECTORS[0])))
+        .isNull();
+    assertThat(
+            VectorFunctions.COSINE_SIMILARITY.eval(
+                VectorFunctions.DOUBLE_TO_VECTOR.eval(VECTORS[0]), null))
+        .isNull();
+
+    // Test cosine_distance with null inputs
+    assertThat(VectorFunctions.COSINE_DISTANCE.eval(null, null)).isNull();
+    assertThat(
+            VectorFunctions.COSINE_DISTANCE.eval(
+                null, VectorFunctions.DOUBLE_TO_VECTOR.eval(VECTORS[0])))
+        .isNull();
+    assertThat(
+            VectorFunctions.COSINE_DISTANCE.eval(
+                VectorFunctions.DOUBLE_TO_VECTOR.eval(VECTORS[0]), null))
+        .isNull();
+
+    // Test euclidean_distance with null inputs
+    assertThat(VectorFunctions.EUCLIDEAN_DISTANCE.eval(null, null)).isNull();
+    assertThat(
+            VectorFunctions.EUCLIDEAN_DISTANCE.eval(
+                null, VectorFunctions.DOUBLE_TO_VECTOR.eval(VECTORS[0])))
+        .isNull();
+    assertThat(
+            VectorFunctions.EUCLIDEAN_DISTANCE.eval(
+                VectorFunctions.DOUBLE_TO_VECTOR.eval(VECTORS[0]), null))
+        .isNull();
+
+    // Test double_to_vector with null input
+    assertThat(VectorFunctions.DOUBLE_TO_VECTOR.eval(null)).isNull();
+
+    // Test vector_to_double with null input
+    assertThat(VectorFunctions.VECTOR_TO_DOUBLE.eval(null)).isNull();
+
+    // Test ascii_text_test_embed with null input
+    assertThat(VectorFunctions.ASCII_TEXT_TEST_EMBED.eval(null)).isNull();
+
+    // Verify that cosine_distance returns null when cosine_similarity returns null
+    var cosineSimilarity = VectorFunctions.COSINE_SIMILARITY.eval(null, null);
+    var cosineDistance = VectorFunctions.COSINE_DISTANCE.eval(null, null);
+    assertThat(cosineSimilarity).isNull();
+    assertThat(cosineDistance).isNull();
+  }
+
   @Test
   public void testSimilarityCenter() {
     var results = new FlinkVectorType[VECTORS.length];
diff --git a/stdlib/stdlib-vector/src/test/java/com/datasqrl/flinkrunner/stdlib/vector/VectorToDoubleTest.java b/stdlib/stdlib-vector/src/test/java/com/datasqrl/flinkrunner/stdlib/vector/VectorToDoubleTest.java

Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,7 @@`
`15`	`15`	`*/`
`16`	`16`	`package com.datasqrl.flinkrunner.stdlib.vector;`
`17`	`17`
`18`		`-import static com.datasqrl.flinkrunner.stdlib.vector.VectorFunctions.VEC_TO_DOUBLE;`
	`18`	`+import static com.datasqrl.flinkrunner.stdlib.vector.VectorFunctions.VECTOR_TO_DOUBLE;`
`19`	`19`	`import static com.datasqrl.flinkrunner.stdlib.vector.VectorFunctions.convert;`
`20`	`20`
`21`	`21`	`import com.datasqrl.flinkrunner.stdlib.utils.AutoRegisterSystemFunction;`
`@@ -47,11 +47,11 @@ public FlinkVectorType getValue(CenterAccumulator acc) {`
`47`	`47`	`}`
`48`	`48`
`49`	`49`	`public void accumulate(CenterAccumulator acc, FlinkVectorType vector) {`
`50`		`- acc.add(VEC_TO_DOUBLE.eval(vector));`
	`50`	`+ acc.add(VECTOR_TO_DOUBLE.eval(vector));`
`51`	`51`	`}`
`52`	`52`
`53`	`53`	`public void retract(CenterAccumulator acc, FlinkVectorType vector) {`
`54`		`- acc.substract(VEC_TO_DOUBLE.eval(vector));`
	`54`	`+ acc.substract(VECTOR_TO_DOUBLE.eval(vector));`
`55`	`55`	`}`
`56`	`56`
`57`	`57`	`public void merge(CenterAccumulator acc, Iterable<CenterAccumulator> iter) {`