Skip to content

Conversation

@mrjovana
Copy link

Changes made to sat macro, in order to enable proper ordering during load of intra-day changes with same load_dt but different src_eff:

  • added optional src_eff parameter to window_cols list, used in latest_records CTE
  • if src_eff is provided, it is added to order by clause together with load_dt in latest records CTE (to locate latest latest record from existing target)

@DVAlexHiggs
Copy link
Member

DVAlexHiggs commented Jun 30, 2025

Hello, Thanks for this PR.

We already added support for this as of AutomateDV 0.11.1, please upgrade to make use of this change :)

@mrjovana
Copy link
Author

mrjovana commented Jun 30, 2025

hey @DVAlexHiggs , please check once again... I know you added already this clause to newly incoming source records, but I don't see it for latest records in existing target satellite (not in 0.11.1 or 0.11.2) - important to determine what is real latest-latest in existing sat, in case multiple changes were loaded within same load_dt previously.

@DVAlexHiggs
Copy link
Member

Ah I see, apologies for my misunderstanding!

This does make sense, I will re-open the PR.

Unfortunately we cannot accept PRs directly to this repo at the current time, and our development repo with our full test-suite is not public. If and when we implement this change, I will ensure you are credited in the release. Apologies for the inconvenience around how this works at this time.

@DVAlexHiggs DVAlexHiggs reopened this Jun 30, 2025
@mrjovana
Copy link
Author

Not a problem at all, just please let me know if and when this change is implemented. Thank you very much @DVAlexHiggs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants