Thank you for the interest in contributing to the "Windows (No Internet, Secured) BUGFIX" NCSI Resolver project! This document provides guidelines and instructions for contributing.
If you find a bug, please create an issue using the bug report template and include:
- A clear, descriptive title
- Steps to reproduce the issue
- Expected behavior
- Actual behavior
- Screenshots if applicable
- Your Windows version and other relevant system information
- Any additional context that might help
For feature requests or enhancements:
- Use the feature request template
- Clearly describe the feature/enhancement and its benefits
- Provide specific examples of how it would be used
- Describe alternatives you've considered
- Any additional context or screenshots
- Fork the repository
- Create a new branch from
main - Make your changes
- Ensure your code follows the project's style guidelines
- Add tests if applicable
- Update documentation as needed
- Submit your pull request with a clear description of the changes
- Clone your fork of the repository
- Set up a virtual environment:
python -m venv venv venv\Scripts\activate # Windows source venv/bin/activate # Unix/MacOS - Install dependencies (dev or otherwise, currently there are none):
pip install -r requirements-dev.txt
Before submitting your changes, please test them thoroughly:
- Test on multiple Windows versions if possible
- Test with different network configurations
- Test with and without admin privileges
- Run any unit tests if available
- Follow PEP 8 coding standards
- Use meaningful variable and function names
- Add comments for complex logic
- Keep functions focused on a single responsibility
- Document public functions with docstrings
- Use clear, descriptive commit messages
- Start with a short summary line (50 chars or less)
- Optionally, provide more detailed explanation after the summary, separated by a blank line
- Reference issue numbers when applicable: "Fixes #123" or "Related to #456"
By contributing to this project, you agree that your contributions will be licensed under the project's MIT License.
If you have any questions or need help, feel free to open an issue or contact the project maintainers.
Thank you for contributing to NCSI Resolver!
By participating, you agree to maintain a respectful environment for everyone. Contributors are expected to be:
- Welcoming and civil (empathy would be nice too)
- Accepting of constructive criticism
- Thoughtful and attempt to be respectful of alternate viewpoints and experiences
- Focus on what is best for the project and the community