chore(e2e): inline python assertions

Author: Desdaemon

.github/workflows/nightly.yml

@@ -110,10 +110,6 @@ jobs:
           sudo apt-get update
           sudo apt-get install -y gcc-multilib
 
-      - name: Run unit tests
-        if: matrix.target == 'x86_64-unknown-linux-gnu'
-        run: cargo test
-
       - name: Build
         run: cargo build --release --target ${{ matrix.target }}
 

.github/workflows/test.yml

@@ -38,9 +38,10 @@ jobs:
       - name: Run tests
         working-directory: testing
         run: |
-          pip install uv
+          pip install -U uv
           uv venv
           . ${{ matrix.runs-on == 'windows-latest' && '.venv/Scripts/activate' || '.venv/bin/activate'}}
+          uv pip compile requirements.in -o requirements.txt
           uv pip sync requirements.txt
           pytest -vv --junitxml=.results.xml --color=yes
 

.gitignore

@@ -9,4 +9,5 @@ dist/*
 syntaxes/*.json
 .venv
 __pycache__
-.*_cache
+.*_cache
+testing/requirements.txt

src/analyze.rs

@@ -1,7 +1,7 @@
 //! Methods related to type analysis. The two most important methods are
 //! [`Backend::model_of_range`] and [`Backend::type_of`].
 
-use std::{borrow::Borrow, collections::HashMap, iter::FusedIterator, ops::ControlFlow};
+use std::{borrow::Borrow, collections::HashMap, fmt::Debug, iter::FusedIterator, ops::ControlFlow};
 
 use tracing::trace;
 use tree_sitter::{Node, QueryCursor};
@@ -63,6 +63,12 @@ pub struct Scope {
 	pub super_: Option<ImStr>,
 }
 
+impl Debug for Scope {
+	fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
+		f.debug_tuple("Scope").field(&"..").finish()
+	}
+}
+
 pub fn normalize<'r, 'n>(node: &'r mut Node<'n>) -> &'r mut Node<'n> {
 	let mut cursor = node.walk();
 	while matches!(

src/python.rs

@@ -1017,6 +1017,11 @@ impl Backend {
 								return ControlFlow::Continue(entered);
 							}
 
+							// HACK: fix this issue where the model name is just empty
+							if interner().resolve(&model_name).is_empty() {
+								return ControlFlow::Continue(entered);
+							}
+
 							diagnostics.push(Diagnostic {
 								range: ts_range_to_lsp_range(attribute.range()),
 								severity: Some(DiagnosticSeverity::ERROR),

src/xml.rs

@@ -15,7 +15,7 @@ use odoo_lsp::model::{Field, FieldKind};
 use odoo_lsp::template::gather_templates;
 use ropey::{Rope, RopeSlice};
 use tower_lsp::lsp_types::*;
-use tracing::{debug, warn};
+use tracing::{debug, instrument, warn};
 use tree_sitter::Parser;
 use xmlparser::{ElementEnd, Error, StrSpan, StreamError, Token, Tokenizer};
 
@@ -610,6 +610,7 @@ impl Backend {
 	}
 	/// The main function that determines all the information needed
 	/// to resolve the symbol at the cursor.
+	#[instrument(level = "trace", skip_all, ret)]
 	fn gather_refs<'read>(
 		&self,
 		offset_at_cursor: ByteOffset,
@@ -998,6 +999,7 @@ impl Backend {
 	}
 }
 
+#[derive(Debug)]
 struct XmlRefs<'a> {
 	ref_at_cursor: Option<(&'a str, core::ops::Range<usize>)>,
 	ref_kind: Option<RefKind<'a>>,

testing/README.md

@@ -1 +1,9 @@
 End-to-end testing for odoo-lsp.
+
+```shell
+pip install -U setuptools uv
+uv venv
+source .venv/bin/activate
+uv pip compile requirements.in > requirements.txt
+uv pip sync requirements.txt
+```

testing/fixtures/basic/bar/models.py

@@ -7,4 +7,4 @@ class DerivedBar(models.Model):
     _inherit = "bar"
 
     def test(self):
-        self.env["bar"]
+        pass

testing/fixtures/basic/foo/models.py

@@ -1,15 +1,32 @@
 class Foo(Model):
     _name = "foo"
 
-    def test(self):
+    bar = fields.Char()
+
+    def completions(self):
         self.env["bar"]
+        #         ^complete bar derived.bar foo foob
 
     def diagnostics(self):
         self.foo
+        #    ^diag Model `foo` has no field `foo`
         self.env["foo"].foo
+        #               ^diag Model `foo` has no field `foo`
         self.mapped("foo")
+        #            ^diag Model `foo` has no field `foo`
         self.env["fo"]
+        #         ^diag `fo` is not a valid model name
 
 
 class Foob(Model):
     _name = "foob"
+
+    foo_id = fields.Many2one("foo")
+    barb = fields.Char(related='foo_id.bar')
+    #                                  ^complete bar
+
+class NonModel:
+    __slots__ = ("foo", "bar")
+
+    def __init__(self):
+        ...

testing/fixtures/basic/foo/records.xml

@@ -0,0 +1,6 @@
+<odoo>
+	<record id="foo.1" model="foo">
+		<field name="bar"/>
+		<!--         ^complete bar -->
+	</record>
+</odoo>