refactor: remove any usages and improve type safety in public routes#653
Open
pari7maheshwari wants to merge 1 commit into
Open
refactor: remove any usages and improve type safety in public routes#653pari7maheshwari wants to merge 1 commit into
pari7maheshwari wants to merge 1 commit into
Conversation
|
@pari7maheshwari is attempting to deploy a commit to the Prashantkumar Khatri's projects Team on Vercel. A member of the Team first needs to authorize it. |
github-actions
Bot
added
backend
gssoc:approved
Contributor
|
Hi @pari7maheshwari, Thanks for opening this pull request. This PR has been automatically classified based on the files modified. Applied Labels
Primary Review Area
Reviewer@Harxhit has been identified as the primary reviewer for this pull request. If you have any questions regarding the affected area or implementation details, feel free to reach out to the assigned reviewer. Thank you for your contribution! |
Contributor
CI — All Checks PassedBackend — PASS
Mobile — SKIP
Web — SKIP
Last updated: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #553
Removes all
anyusages fromapps/backend/src/routes/public.tsby introducing proper TypeScript types for query parameters and card link response mapping. No runtime behaviour is changed.Type of Change
What Changed
QrQuerystringinterface ({ format?: 'png' | 'svg'; size?: string }) and typed the QR route'sFastifyRequestwithQuerystring: QrQuerystring, replacing two(request.query as any)casts with directrequest.query.formatandrequest.query.sizeaccessCardLinkWithPlatformtype viaPrisma.CardLinkGetPayload<{ include: { platformLink: true } }>, replacing(cl: any)in the/card/:cardIdresponse mapping with a proper generated Prisma typeimport type { Prisma } from '@prisma/client'to support the payload type — reuses the existing generated client, no new dependenciesHow to Test
npm run typecheck --workspaces --if-present— should pass with no new errorsnpm run lint— should passGET /api/u/:username/qr?format=svg&size=300andGET /api/public/card/:cardIdmanually or via existing tests to confirm responses are unchangedChecklist
npm run lintpasses)npm run typecheck --workspaces --if-present)npm run test --workspaces --if-present)console.logor debug statements left in the codeScreenshots / Recordings
Not applicable — refactor only, no UI or API contract changes.
Note for reviewers: Two pre-existing TypeScript errors (
rateLimit does not exist in type FastifyContextConfig, lines 40 and 152) are visible in the Problems panel but were present before this PR and are out of scope for this issue.