Skip to content

Conversation

@Enegg
Copy link
Contributor

@Enegg Enegg commented Nov 8, 2025

Summary

This PR changes the definitions of enum member aliases from the form x = 1; y = 1 to x = 1; y = x, as pyright only understands the latter to be an alias. (#11100)

This impacts things like assignability (currently h: Literal[Enum.x] = Enum.y produces an error) and exhaustiveness checks.

image

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running uv run nox -s lint
    • I have type-checked the code by running uv run nox -s pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@read-the-docs-community
Copy link

read-the-docs-community bot commented Nov 8, 2025

Documentation build overview

📚 disnake | 🛠️ Build #30267702 | 📁 Comparing 5930316 against latest (90279c4)


🔍 Preview build

Show files changed (49 files in total): 📝 49 modified | ➕ 0 added | ➖ 0 deleted
File Status
genindex.html 📝 modified
index.html 📝 modified
whats_new.html 📝 modified
api/abc.html 📝 modified
api/activities.html 📝 modified
api/app_commands.html 📝 modified
api/app_info.html 📝 modified
api/audit_logs.html 📝 modified
api/automod.html 📝 modified
api/channels.html 📝 modified
api/clients.html 📝 modified
api/components.html 📝 modified
api/emoji.html 📝 modified
api/entitlements.html 📝 modified
api/events.html 📝 modified
api/exceptions.html 📝 modified
api/guild_scheduled_events.html 📝 modified
api/guilds.html 📝 modified
api/integrations.html 📝 modified
api/interactions.html 📝 modified
api/invites.html 📝 modified
api/localization.html 📝 modified
api/members.html 📝 modified
api/messages.html 📝 modified
api/misc.html 📝 modified
api/permissions.html 📝 modified
api/roles.html 📝 modified
api/skus.html 📝 modified
api/soundboard.html 📝 modified
api/stage_instances.html 📝 modified
api/stickers.html 📝 modified
api/subscriptions.html 📝 modified
api/ui.html 📝 modified
api/users.html 📝 modified
api/utilities.html 📝 modified
api/voice.html 📝 modified
api/webhooks.html 📝 modified
api/widgets.html 📝 modified
ext/tasks/index.html 📝 modified
ext/commands/api/app_commands.html 📝 modified
ext/commands/api/bots.html 📝 modified
ext/commands/api/checks.html 📝 modified
ext/commands/api/cogs.html 📝 modified
ext/commands/api/context.html 📝 modified
ext/commands/api/converters.html 📝 modified
ext/commands/api/exceptions.html 📝 modified
ext/commands/api/help_commands.html 📝 modified
ext/commands/api/misc.html 📝 modified
ext/commands/api/prefix_commands.html 📝 modified

@Snipy7374
Copy link
Collaborator

There's also

disnake/disnake/enums.py

Lines 1459 to 1462 in d231d63

closed = 2
"""The stage instance can only be joined by members of the guild."""
guild_only = 2
"""Alias for :attr:`.closed`"""

@onerandomusername onerandomusername self-requested a review November 10, 2025 06:19
@Enegg
Copy link
Contributor Author

Enegg commented Nov 10, 2025

There's also

disnake/disnake/enums.py

Lines 1459 to 1462 in d231d63

closed = 2
"""The stage instance can only be joined by members of the guild."""
guild_only = 2
"""Alias for :attr:`.closed`"""

Mfw case sensitive search for "alias" does not find "Alias"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants