Skip to content

Commit 729951f

Browse files
DonaldcwlDonaldcwl
committed
release v1.0.1
- fixing bug related to wrong image output resolution in some cases
1 parent 3f9079e commit 729951f

22 files changed

+560
-410
lines changed

‎README.md‎

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,9 @@ Javascript module to be run in the web browser for image compression.
1010
- **Multi-thread** (web worker) non-blocking compression are supported through options.
1111

1212
## Change log ##
13+
v1.0.1
14+
- fixing bug related to wrong image output resolution in some case
15+
1316
v1.0.0
1417
- breaking change: change "imageCompression" function signature
1518
- use of OffscreenCanvas when support, fallback to document.createElement('canvas')
@@ -141,6 +144,16 @@ cd browser-image-compression/example
141144
# open "basic.html" on your browser
142145
```
143146

147+
## Contribution ##
148+
1. fork the repo and git clone it
149+
2. run `npm run watch` # it will watch code change in lib/ folder and generate js in dist/ folder
150+
3. add/update code in lib/ folder
151+
4. try the code by opening example/development.html which will load the js in dist/ folder
152+
5. add/update test in test/ folder
153+
6. `npm run test`
154+
7. push to your forked repo on github
155+
8. make a pull request to this repo
156+
144157
[dist]: https://github.com/Donaldcwl/browser-image-compression/tree/master/dist
145158
[example]: https://github.com/Donaldcwl/browser-image-compression/tree/master/example
146159
[delivrjs]: https://cdn.jsdelivr.net/

‎coverage/badge.svg‎

Lines changed: 1 addition & 1 deletion
Loading

‎coverage/coverage-final.json‎

Lines changed: 3 additions & 3 deletions
Large diffs are not rendered by default.

‎coverage/coverage-summary.json‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
{"total": {"lines":{"total":159,"covered":110,"skipped":0,"pct":69.18},"statements":{"total":172,"covered":112,"skipped":0,"pct":65.12},"functions":{"total":21,"covered":18,"skipped":0,"pct":85.71},"branches":{"total":74,"covered":34,"skipped":0,"pct":45.95}}
1+
{"total": {"lines":{"total":159,"covered":115,"skipped":0,"pct":72.33},"statements":{"total":172,"covered":117,"skipped":0,"pct":68.02},"functions":{"total":21,"covered":18,"skipped":0,"pct":85.71},"branches":{"total":74,"covered":39,"skipped":0,"pct":52.7}}
22
,"/Users/donald/Project/browser-image-compression/lib/image-compression.js": {"lines":{"total":31,"covered":23,"skipped":0,"pct":74.19},"functions":{"total":1,"covered":1,"skipped":0,"pct":100},"statements":{"total":31,"covered":23,"skipped":0,"pct":74.19},"branches":{"total":18,"covered":13,"skipped":0,"pct":72.22}}
3-
,"/Users/donald/Project/browser-image-compression/lib/index.js": {"lines":{"total":25,"covered":22,"skipped":0,"pct":88},"functions":{"total":1,"covered":1,"skipped":0,"pct":100},"statements":{"total":25,"covered":22,"skipped":0,"pct":88},"branches":{"total":17,"covered":11,"skipped":0,"pct":64.71}}
4-
,"/Users/donald/Project/browser-image-compression/lib/utils.js": {"lines":{"total":103,"covered":65,"skipped":0,"pct":63.11},"functions":{"total":19,"covered":16,"skipped":0,"pct":84.21},"statements":{"total":116,"covered":67,"skipped":0,"pct":57.76},"branches":{"total":39,"covered":10,"skipped":0,"pct":25.64}}
3+
,"/Users/donald/Project/browser-image-compression/lib/index.js": {"lines":{"total":25,"covered":22,"skipped":0,"pct":88},"functions":{"total":1,"covered":1,"skipped":0,"pct":100},"statements":{"total":25,"covered":22,"skipped":0,"pct":88},"branches":{"total":17,"covered":12,"skipped":0,"pct":70.59}}
4+
,"/Users/donald/Project/browser-image-compression/lib/utils.js": {"lines":{"total":103,"covered":70,"skipped":0,"pct":67.96},"functions":{"total":19,"covered":16,"skipped":0,"pct":84.21},"statements":{"total":116,"covered":72,"skipped":0,"pct":62.07},"branches":{"total":39,"covered":14,"skipped":0,"pct":35.9}}
55
}

‎coverage/image-compression.js.html‎

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -129,39 +129,39 @@ <h1>
129129
<span class="cline-any cline-neutral">&nbsp;</span>
130130
<span class="cline-any cline-neutral">&nbsp;</span>
131131
<span class="cline-any cline-neutral">&nbsp;</span>
132-
<span class="cline-any cline-yes">2x</span>
132+
<span class="cline-any cline-yes">6x</span>
133133
<span class="cline-any cline-neutral">&nbsp;</span>
134-
<span class="cline-any cline-yes">2x</span>
134+
<span class="cline-any cline-yes">6x</span>
135135
<span class="cline-any cline-neutral">&nbsp;</span>
136136
<span class="cline-any cline-neutral">&nbsp;</span>
137-
<span class="cline-any cline-yes">2x</span>
137+
<span class="cline-any cline-yes">6x</span>
138138
<span class="cline-any cline-no">&nbsp;</span>
139139
<span class="cline-any cline-neutral">&nbsp;</span>
140140
<span class="cline-any cline-neutral">&nbsp;</span>
141141
<span class="cline-any cline-neutral">&nbsp;</span>
142142
<span class="cline-any cline-neutral">&nbsp;</span>
143143
<span class="cline-any cline-neutral">&nbsp;</span>
144-
<span class="cline-any cline-yes">2x</span>
145-
<span class="cline-any cline-yes">2x</span>
146-
<span class="cline-any cline-yes">2x</span>
144+
<span class="cline-any cline-yes">6x</span>
145+
<span class="cline-any cline-yes">6x</span>
146+
<span class="cline-any cline-yes">6x</span>
147147
<span class="cline-any cline-neutral">&nbsp;</span>
148148
<span class="cline-any cline-neutral">&nbsp;</span>
149-
<span class="cline-any cline-yes">2x</span>
150-
<span class="cline-any cline-yes">2x</span>
151-
<span class="cline-any cline-yes">2x</span>
149+
<span class="cline-any cline-yes">6x</span>
150+
<span class="cline-any cline-yes">6x</span>
151+
<span class="cline-any cline-yes">6x</span>
152152
<span class="cline-any cline-neutral">&nbsp;</span>
153-
<span class="cline-any cline-yes">2x</span>
153+
<span class="cline-any cline-yes">6x</span>
154154
<span class="cline-any cline-no">&nbsp;</span>
155155
<span class="cline-any cline-neutral">&nbsp;</span>
156156
<span class="cline-any cline-neutral">&nbsp;</span>
157157
<span class="cline-any cline-neutral">&nbsp;</span>
158-
<span class="cline-any cline-yes">2x</span>
159-
<span class="cline-any cline-yes">2x</span>
158+
<span class="cline-any cline-yes">6x</span>
159+
<span class="cline-any cline-yes">6x</span>
160160
<span class="cline-any cline-neutral">&nbsp;</span>
161-
<span class="cline-any cline-yes">2x</span>
162-
<span class="cline-any cline-yes">2x</span>
163-
<span class="cline-any cline-yes">2x</span>
164-
<span class="cline-any cline-yes">1x</span>
161+
<span class="cline-any cline-yes">6x</span>
162+
<span class="cline-any cline-yes">6x</span>
163+
<span class="cline-any cline-yes">6x</span>
164+
<span class="cline-any cline-yes">3x</span>
165165
<span class="cline-any cline-yes">5x</span>
166166
<span class="cline-any cline-yes">5x</span>
167167
<span class="cline-any cline-neutral">&nbsp;</span>
@@ -171,7 +171,7 @@ <h1>
171171
<span class="cline-any cline-yes">5x</span>
172172
<span class="cline-any cline-neutral">&nbsp;</span>
173173
<span class="cline-any cline-neutral">&nbsp;</span>
174-
<span class="cline-any cline-yes">1x</span>
174+
<span class="cline-any cline-yes">3x</span>
175175
<span class="cline-any cline-no">&nbsp;</span>
176176
<span class="cline-any cline-no">&nbsp;</span>
177177
<span class="cline-any cline-neutral">&nbsp;</span>
@@ -183,7 +183,7 @@ <h1>
183183
<span class="cline-any cline-neutral">&nbsp;</span>
184184
<span class="cline-any cline-neutral">&nbsp;</span>
185185
<span class="cline-any cline-neutral">&nbsp;</span>
186-
<span class="cline-any cline-yes">2x</span>
186+
<span class="cline-any cline-yes">6x</span>
187187
<span class="cline-any cline-neutral">&nbsp;</span></td><td class="text"><pre class="prettyprint lang-js">import { canvasToFile, drawFileInCanvas, followExifOrientation, getExifOrientation, handleMaxWidthOrHeight } from './utils'
188188
&nbsp;
189189
/**
@@ -259,7 +259,7 @@ <h1>
259259
</div><!-- /wrapper -->
260260
<div class='footer quiet pad2 space-top1 center small'>
261261
Code coverage
262-
generated by <a href="https://istanbul.js.org/" target="_blank">istanbul</a> at Wed Feb 06 2019 15:51:16 GMT+0800 (Hong Kong Standard Time)
262+
generated by <a href="https://istanbul.js.org/" target="_blank">istanbul</a> at Fri Mar 08 2019 15:37:32 GMT+0800 (Hong Kong Standard Time)
263263
</div>
264264
</div>
265265
<script src="prettify.js"></script>

‎coverage/index.html‎

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -20,24 +20,24 @@ <h1>
2020
</h1>
2121
<div class='clearfix'>
2222
<div class='fl pad1y space-right2'>
23-
<span class="strong">65.12% </span>
23+
<span class="strong">68.02% </span>
2424
<span class="quiet">Statements</span>
25-
<span class='fraction'>112/172</span>
25+
<span class='fraction'>117/172</span>
2626
</div>
2727
<div class='fl pad1y space-right2'>
28-
<span class="strong">45.95% </span>
28+
<span class="strong">52.7% </span>
2929
<span class="quiet">Branches</span>
30-
<span class='fraction'>34/74</span>
30+
<span class='fraction'>39/74</span>
3131
</div>
3232
<div class='fl pad1y space-right2'>
3333
<span class="strong">85.71% </span>
3434
<span class="quiet">Functions</span>
3535
<span class='fraction'>18/21</span>
3636
</div>
3737
<div class='fl pad1y space-right2'>
38-
<span class="strong">69.18% </span>
38+
<span class="strong">72.33% </span>
3939
<span class="quiet">Lines</span>
40-
<span class='fraction'>110/159</span>
40+
<span class='fraction'>115/159</span>
4141
</div>
4242
</div>
4343
<p class="quiet">
@@ -79,8 +79,8 @@ <h1>
7979
<td data-value="88" class="pic high"><div class="chart"><div class="cover-fill" style="width: 88%;"></div><div class="cover-empty" style="width:12%;"></div></div></td>
8080
<td data-value="88" class="pct high">88%</td>
8181
<td data-value="25" class="abs high">22/25</td>
82-
<td data-value="64.71" class="pct medium">64.71%</td>
83-
<td data-value="17" class="abs medium">11/17</td>
82+
<td data-value="70.59" class="pct medium">70.59%</td>
83+
<td data-value="17" class="abs medium">12/17</td>
8484
<td data-value="100" class="pct high">100%</td>
8585
<td data-value="1" class="abs high">1/1</td>
8686
<td data-value="88" class="pct high">88%</td>
@@ -89,15 +89,15 @@ <h1>
8989

9090
<tr>
9191
<td class="file medium" data-value="utils.js"><a href="utils.js.html">utils.js</a></td>
92-
<td data-value="57.76" class="pic medium"><div class="chart"><div class="cover-fill" style="width: 57%;"></div><div class="cover-empty" style="width:43%;"></div></div></td>
93-
<td data-value="57.76" class="pct medium">57.76%</td>
94-
<td data-value="116" class="abs medium">67/116</td>
95-
<td data-value="25.64" class="pct low">25.64%</td>
96-
<td data-value="39" class="abs low">10/39</td>
92+
<td data-value="62.07" class="pic medium"><div class="chart"><div class="cover-fill" style="width: 62%;"></div><div class="cover-empty" style="width:38%;"></div></div></td>
93+
<td data-value="62.07" class="pct medium">62.07%</td>
94+
<td data-value="116" class="abs medium">72/116</td>
95+
<td data-value="35.9" class="pct low">35.9%</td>
96+
<td data-value="39" class="abs low">14/39</td>
9797
<td data-value="84.21" class="pct high">84.21%</td>
9898
<td data-value="19" class="abs high">16/19</td>
99-
<td data-value="63.11" class="pct medium">63.11%</td>
100-
<td data-value="103" class="abs medium">65/103</td>
99+
<td data-value="67.96" class="pct medium">67.96%</td>
100+
<td data-value="103" class="abs medium">70/103</td>
101101
</tr>
102102

103103
</tbody>
@@ -106,7 +106,7 @@ <h1>
106106
</div><!-- /wrapper -->
107107
<div class='footer quiet pad2 space-top1 center small'>
108108
Code coverage
109-
generated by <a href="https://istanbul.js.org/" target="_blank">istanbul</a> at Wed Feb 06 2019 15:51:16 GMT+0800 (Hong Kong Standard Time)
109+
generated by <a href="https://istanbul.js.org/" target="_blank">istanbul</a> at Fri Mar 08 2019 15:37:32 GMT+0800 (Hong Kong Standard Time)
110110
</div>
111111
</div>
112112
<script src="prettify.js"></script>

‎coverage/index.js.html‎

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,9 @@ <h1>
2525
<span class='fraction'>22/25</span>
2626
</div>
2727
<div class='fl pad1y space-right2'>
28-
<span class="strong">64.71% </span>
28+
<span class="strong">70.59% </span>
2929
<span class="quiet">Branches</span>
30-
<span class='fraction'>11/17</span>
30+
<span class='fraction'>12/17</span>
3131
</div>
3232
<div class='fl pad1y space-right2'>
3333
<span class="strong">100% </span>
@@ -155,25 +155,25 @@ <h1>
155155
<span class="cline-any cline-neutral">&nbsp;</span>
156156
<span class="cline-any cline-neutral">&nbsp;</span>
157157
<span class="cline-any cline-neutral">&nbsp;</span>
158-
<span class="cline-any cline-yes">5x</span>
159-
<span class="cline-any cline-yes">5x</span>
158+
<span class="cline-any cline-yes">9x</span>
159+
<span class="cline-any cline-yes">9x</span>
160160
<span class="cline-any cline-neutral">&nbsp;</span>
161-
<span class="cline-any cline-yes">5x</span>
161+
<span class="cline-any cline-yes">9x</span>
162162
<span class="cline-any cline-yes">2x</span>
163-
<span class="cline-any cline-yes">3x</span>
163+
<span class="cline-any cline-yes">7x</span>
164164
<span class="cline-any cline-yes">1x</span>
165165
<span class="cline-any cline-neutral">&nbsp;</span>
166166
<span class="cline-any cline-neutral">&nbsp;</span>
167167
<span class="cline-any cline-neutral">&nbsp;</span>
168-
<span class="cline-any cline-yes">2x</span>
168+
<span class="cline-any cline-yes">6x</span>
169169
<span class="cline-any cline-neutral">&nbsp;</span>
170170
<span class="cline-any cline-neutral">&nbsp;</span>
171171
<span class="cline-any cline-neutral">&nbsp;</span>
172172
<span class="cline-any cline-neutral">&nbsp;</span>
173173
<span class="cline-any cline-neutral">&nbsp;</span>
174174
<span class="cline-any cline-neutral">&nbsp;</span>
175175
<span class="cline-any cline-neutral">&nbsp;</span>
176-
<span class="cline-any cline-yes">2x</span>
176+
<span class="cline-any cline-yes">6x</span>
177177
<span class="cline-any cline-no">&nbsp;</span>
178178
<span class="cline-any cline-neutral">&nbsp;</span>
179179
<span class="cline-any cline-no">&nbsp;</span>
@@ -182,15 +182,15 @@ <h1>
182182
<span class="cline-any cline-no">&nbsp;</span>
183183
<span class="cline-any cline-neutral">&nbsp;</span>
184184
<span class="cline-any cline-neutral">&nbsp;</span>
185-
<span class="cline-any cline-yes">2x</span>
185+
<span class="cline-any cline-yes">6x</span>
186186
<span class="cline-any cline-neutral">&nbsp;</span>
187187
<span class="cline-any cline-neutral">&nbsp;</span>
188-
<span class="cline-any cline-yes">2x</span>
189-
<span class="cline-any cline-yes">2x</span>
190-
<span class="cline-any cline-yes">2x</span>
188+
<span class="cline-any cline-yes">6x</span>
189+
<span class="cline-any cline-yes">6x</span>
190+
<span class="cline-any cline-yes">6x</span>
191191
<span class="cline-any cline-neutral">&nbsp;</span>
192192
<span class="cline-any cline-neutral">&nbsp;</span>
193-
<span class="cline-any cline-yes">2x</span>
193+
<span class="cline-any cline-yes">6x</span>
194194
<span class="cline-any cline-neutral">&nbsp;</span>
195195
<span class="cline-any cline-neutral">&nbsp;</span>
196196
<span class="cline-any cline-yes">1x</span>
@@ -234,7 +234,7 @@ <h1>
234234
&nbsp;
235235
let compressedFile
236236
&nbsp;
237-
options.maxSizeMB = options.maxSizeMB || <span class="branch-1 cbranch-no" title="branch not covered" >Number.POSITIVE_INFINITY</span>
237+
options.maxSizeMB = options.maxSizeMB || Number.POSITIVE_INFINITY
238238
options.useWebWorker = typeof options.useWebWorker === 'boolean' ? options.useWebWorker : <span class="branch-1 cbranch-no" title="branch not covered" >true</span>
239239
&nbsp;
240240
if (!(file instanceof Blob || file instanceof File)) {
@@ -289,7 +289,7 @@ <h1>
289289
</div><!-- /wrapper -->
290290
<div class='footer quiet pad2 space-top1 center small'>
291291
Code coverage
292-
generated by <a href="https://istanbul.js.org/" target="_blank">istanbul</a> at Wed Feb 06 2019 15:51:16 GMT+0800 (Hong Kong Standard Time)
292+
generated by <a href="https://istanbul.js.org/" target="_blank">istanbul</a> at Fri Mar 08 2019 15:37:32 GMT+0800 (Hong Kong Standard Time)
293293
</div>
294294
</div>
295295
<script src="prettify.js"></script>

0 commit comments

Comments
 (0)