fix #404 (#496)

<!--- Provide a general summary of your changes in the title above -->
<!--- Link the corresponding issues after you created the pull request
-->

## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all
the boxes that apply: -->
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)

## Checklist:
<!--- Go over all the following points, and put an `x` in all the boxes
that apply. -->
<!--- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
- [x] I have updated the [changelog](../CHANGELOG.md) accordingly.
- [x] I have added tests to cover my changes.

Author: leon1995

CHANGELOG.md

@@ -11,6 +11,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 - the `http.client.NotConnected` raised by `SoapClient` now carries the reason of the underlying connection/SSL error, and the consumer now logs the SSL error when it falls back from an encrypted to an unencrypted connection [#427](https://github.com/Draegerwerk/sdc11073/issues/427)
 
+### Fixed
+
+- `SubscriptionEnd` messages now use the full WS-Eventing status URI (e.g. `http://schemas.xmlsoap.org/ws/2004/08/eventing/SourceShuttingDown`) instead of the bare local name, and are sent to the `EndTo` endpoint reference of the subscribe request. If no `EndTo` was provided, no `SubscriptionEnd` message is sent [#404](https://github.com/Draegerwerk/sdc11073/issues/404)
+- the parameter and return type in `RequestManipulatorProtocol.manipulate_string` from `str` to `bytes`
+
 ## [v3.0.0] - 2026-06-24
 
 ### Added

pat/requestmanipulator.py

@@ -1,10 +1,11 @@
+"""A manipulator to manipulate outgoing messages."""
+
 from __future__ import annotations
 
 from typing import TYPE_CHECKING, Protocol
 
 if TYPE_CHECKING:
     from sdc11073 import xml_utils
-
     from sdc11073.pysoap.soapenvelope import Soap12Envelope
 
 
@@ -23,5 +24,5 @@ def manipulate_soapenvelope(self, soap_envelope: Soap12Envelope) -> Soap12Envelo
     def manipulate_domtree(self, domtree: xml_utils.LxmlElement) -> xml_utils.LxmlElement | None:
         """Manipulate on etree.Element level."""
 
-    def manipulate_string(self, xml_string: str) -> str | None:
+    def manipulate_string(self, xml_string: bytes) -> bytes | None:
         """Manipulate on string level."""

src/sdc11073/consumer/manipulator.py

@@ -14,13 +14,12 @@
 
 from sdc11073 import observableproperties
 from sdc11073.etc import apply_map
+from sdc11073.provider.subscriptionmgr_base import ActionBasedSubscription, RoundTripData, SubscriptionsManagerBase
 from sdc11073.pysoap.soapclient import HTTPReturnCodeError
 from sdc11073.xml_types import eventing_types as evt_types
 from sdc11073.xml_types.addressing_types import HeaderInformationBlock
 from sdc11073.xml_types.basetypes import MessageType
 
-from .subscriptionmgr_base import ActionBasedSubscription, RoundTripData, SubscriptionsManagerBase
-
 if TYPE_CHECKING:
     from collections.abc import Awaitable, Iterable
     from logging import LoggerAdapter
@@ -81,35 +80,27 @@ async def async_send_notification_report(self, body_node: xml_utils.LxmlElement,
             raise
 
     async def async_send_notification_end_message(
-        self, code: str = 'SourceShuttingDown', reason: str = 'Event source going off line.'
+        self,
+        code: str = evt_types.SubscriptionEndStatus.SOURCE_SHUTTING_DOWN,
+        reason: str = 'Event source going off line.',
     ) -> ReceivedMessage | None:
-        """Send notification end message to subscriber."""
-        url = self.base_urls[0]
-        my_addr = f'{url.scheme}:{url.netloc}/{url.path}'
+        """Send notification end message to subscriber.
 
-        if not self.is_valid:
+        A SubscriptionEnd message is sent to the EndTo endpoint reference of the subscribe request.
+        If no EndTo was provided, no message is sent.
+        """
+        message = self._prepare_subscription_end(code=code, reason=reason)
+        if message is None:
             return None
-        subscription_end = evt_types.SubscriptionEnd()
-        subscription_end.SubscriptionManager.Address = my_addr
-        subscription_end.SubscriptionManager.ReferenceParameters = self.reference_parameters
-        subscription_end.Status = code
-        subscription_end.add_reason(reason, 'en-US')
-        inf = HeaderInformationBlock(
-            action=subscription_end.action,
-            addr_to=self.end_to_address or self.notify_to_address,
-            reference_parameters=self.end_to_ref_params or self.notify_ref_params,
-        )
-        message = self._msg_factory.mk_soap_message(inf, payload=subscription_end)
-        url = self._end_to_url or self.notify_to_url
-        soap_client = self._get_soap_client(url.netloc)
-        self._logger.info('async send subscription end to {}, subscription = {}', url, self)  # noqa: PLE1205
+        soap_client = self._get_soap_client(self._end_to_url.netloc)
+        self._logger.info('async send subscription end to {}, subscription = {}', self._end_to_url, self)  # noqa: PLE1205
         try:
-            return await soap_client.async_post_message_to(url.path, message)
+            return await soap_client.async_post_message_to(self._end_to_url.path, message)
         except aiohttp.client_exceptions.ClientConnectorError:
             # it does not matter that we could not send the message - end is end ;)
             self._logger.info(  # noqa: PLE1205
                 'exception async send subscription end to {}, subscription = {}',
-                url,
+                self._end_to_url,
                 self,
             )
         except Exception:  # noqa: BLE001

src/sdc11073/provider/subscriptionmgr_async.py

@@ -4,11 +4,11 @@
 
 import http.client
 import time
+import urllib.parse
 import uuid
 from collections import deque
 from threading import Thread
 from typing import TYPE_CHECKING, Any, Protocol
-from urllib.parse import urlparse
 
 from lxml import etree
 
@@ -22,7 +22,6 @@
 from sdc11073.xml_types.basetypes import MessageType
 
 if TYPE_CHECKING:
-    import urllib.parse
     from collections.abc import Sequence
     from urllib.parse import SplitResult
 
@@ -104,16 +103,16 @@ def __init__(  # noqa: PLR0913
 
         self.mode = subscribe_request.Delivery.Mode
         self.notify_to_address = subscribe_request.Delivery.NotifyTo.Address
-        self.notify_to_url = urlparse(self.notify_to_address)
+        self.notify_to_url = urllib.parse.urlparse(self.notify_to_address)
         self.notify_ref_params = subscribe_request.Delivery.NotifyTo.ReferenceParameters
         self.end_to_address = None
         self.end_to_ref_params = []
-        self._end_to_url = None
+        self._end_to_url: urllib.parse.ParseResult | None = None
         if subscribe_request.EndTo is not None:
             self.end_to_address = subscribe_request.EndTo.Address
             self.end_to_ref_params = subscribe_request.EndTo.ReferenceParameters
             if self.end_to_address is not None:
-                self._end_to_url = urlparse(self.end_to_address)
+                self._end_to_url = urllib.parse.urlparse(self.end_to_address)
 
         self.identifier_uuid = uuid.uuid4()
         self.reference_parameters = []  # default: no reference parameters
@@ -194,32 +193,47 @@ def is_valid(self) -> bool:
             return False
         return self.remaining_seconds > 0 and not self.has_delivery_failure
 
-    def send_notification_end_message(
+    def _prepare_subscription_end(
         self,
-        code: str = 'SourceShuttingDown',
+        code: str = evt_types.SubscriptionEndStatus.SOURCE_SHUTTING_DOWN,
         reason: str = 'Event source going off line.',
-    ):
-        """Send a notification end message."""
+    ) -> CreatedMessage | None:
         url = self.base_urls[0]
         my_addr = f'{url.scheme}:{url.netloc}/{url.path}'
 
         if not self.is_valid:
-            return
+            return None
+        if self._end_to_url is None:
+            # no EndTo endpoint reference -> per WS-Eventing the default is not to send this message
+            return None
         subscription_end = evt_types.SubscriptionEnd()
         subscription_end.SubscriptionManager.Address = my_addr
         subscription_end.SubscriptionManager.ReferenceParameters = self.reference_parameters
         subscription_end.Status = code
         subscription_end.add_reason(reason, 'en-US')
         inf = HeaderInformationBlock(
             action=subscription_end.action,
-            addr_to=self.end_to_address or self.notify_to_address,
-            reference_parameters=self.end_to_ref_params or self.notify_ref_params,
+            addr_to=self.end_to_address,
+            reference_parameters=self.end_to_ref_params,
         )
-        message = self._msg_factory.mk_soap_message(inf, payload=subscription_end)
-        url = self._end_to_url or self.notify_to_url
-        soap_client = self._get_soap_client(url.netloc)
+        return self._msg_factory.mk_soap_message(inf, payload=subscription_end)
+
+    def send_notification_end_message(
+        self,
+        code: str = evt_types.SubscriptionEndStatus.SOURCE_SHUTTING_DOWN,
+        reason: str = 'Event source going off line.',
+    ):
+        """Send a notification end message.
+
+        A SubscriptionEnd message is sent to the EndTo endpoint reference of the subscribe request.
+        If no EndTo was provided, no message is sent.
+        """
+        message = self._prepare_subscription_end(code=code, reason=reason)
+        if message is None:
+            return
+        soap_client = self._get_soap_client(self._end_to_url.netloc)
         try:
-            soap_client.post_message_to(url.path, message, msg='send_notification_end_message')
+            soap_client.post_message_to(self._end_to_url.path, message, msg='send_notification_end_message')
         except Exception as ex:  # noqa: BLE001
             # it does not matter that we could not send the message - end is end ;)
             self._logger.info('could not send subscription end message, error = {}', ex)  # noqa: PLE1205