error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false --> games/src/downloads/download_agent.rs:282:12 | 282 | if max_download_threads <= 0 { | ^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: because `0` is the minimum value for this type, the case where the two sides are not equal never occurs, consider using `max_download_threads == 0` instead = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons = note: `#[deny(clippy::absurd_extreme_comparisons)]` on by default

Clippy had exited with the 101 exit code

warning: redundant closure --> games/src/downloads/download_logic.rs:98:28 | 98 | .map(|v| v.map_err(|err| std::io::Error::other(err))); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `std::io::Error::other` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure = note: `#[warn(clippy::redundant_closure)]` on by default

warning: unneeded `return` statement --> games/src/downloads/download_agent.rs:302:29 | 302 | Err(err) => return Err(err), | ^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return = note: `#[warn(clippy::needless_return)]` on by default help: remove `return` | 302 - Err(err) => return Err(err), 302 + Err(err) => Err(err), |

warning: importing legacy numeric constants --> download_manager/src/depot_manager.rs:4:32 | 4 | time::{Duration, Instant}, usize, | ^^^^^ | = help: remove this import = note: then `usize::<CONST>` will resolve to the respective associated constant = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants = note: `#[warn(clippy::legacy_numeric_constants)]` on by default

warning: this `MutexGuard` is held across an await point --> download_manager/src/download_manager_frontend.rs:134:13 | 134 | let mut queue = self.edit(); | ^^^^^^^^^ | = help: consider using an async-aware `Mutex` type or ensuring the `MutexGuard` is dropped before calling `await` note: these are all the await points this lock is held through --> download_manager/src/download_manager_frontend.rs:141:9 | 141 | send!(self.command_sender, DownloadManagerSignal::UpdateUIQueue); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#await_holding_lock = note: `#[warn(clippy::await_holding_lock)]` on by default = note: this warning originates in the macro `send` (in Nightly builds, run with -Z macro-backtrace for more info)

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/