fix: clippy

Author: DecDuck

src-tauri/games/src/downloads/download_agent.rs

@@ -25,7 +25,7 @@ use std::collections::HashMap;
 use std::fmt::Debug;
 use std::fs::{create_dir_all, remove_file};
 use std::io;
-use std::path::{Path, PathBuf, StripPrefixError};
+use std::path::{Path, PathBuf};
 use std::sync::{Arc, Mutex};
 use std::time::Instant;
 use tauri::AppHandle;
@@ -308,7 +308,7 @@ impl GameDownloadAgent {
         let current_file_tree = self.scan_filetree(base_path)?;
 
         for file in current_file_tree {
-            let filename = file.strip_prefix(&base_path)?.to_string_lossy().to_string();
+            let filename = file.strip_prefix(base_path)?.to_string_lossy().to_string();
             let needed = file_list.contains_key(&filename) || filename == ".dropdata";
             if !needed {
                 info!("deleted {}", file.display());
@@ -330,7 +330,7 @@ impl GameDownloadAgent {
                     }
                     Ok(())
                 }
-                Err(err) => return Err(err),
+                Err(err) => Err(err),
             };
 
         let mut index = 0;

src-tauri/games/src/downloads/download_logic.rs

@@ -3,7 +3,7 @@ use std::fs::{Permissions, set_permissions};
 use std::io::SeekFrom;
 #[cfg(unix)]
 use std::os::unix::fs::PermissionsExt;
-use std::path::{Path, PathBuf};
+use std::path::Path;
 use std::sync::Arc;
 use std::time::Instant;
 
@@ -95,7 +95,7 @@ pub async fn download_game_chunk(
 
     let stream = response
         .bytes_stream()
-        .map(|v| v.map_err(|err| std::io::Error::other(err)));
+        .map(|v| v.map_err(std::io::Error::other));
     let mut stream_reader = StreamReader::new(stream);
     //let mut stream_reader = response;
 

src-tauri/src/downloads.rs

@@ -9,7 +9,6 @@ use download_manager::{
     DOWNLOAD_MANAGER, downloadable::Downloadable, error::ApplicationDownloadError,
 };
 use games::downloads::download_agent::GameDownloadAgent;
-use log::info;
 
 #[tauri::command]
 pub async fn download_game(
@@ -37,8 +36,10 @@ pub async fn download_game(
         }
     };
 
-    let mut configuration = UserConfiguration::default();
-    configuration.enable_updates = enable_updates;
+    let configuration = UserConfiguration {
+        enable_updates,
+        ..Default::default()
+    };
 
     let base_dir = {
         let db_lock = borrow_db_checked();

src-tauri/src/scheduler.rs

@@ -1,7 +1,7 @@
-use std::{time::Duration, usize};
+use std::{time::Duration};
 
 use async_trait::async_trait;
-use log::{info, warn};
+use log::warn;
 use tokio::time;
 
 use crate::updates::GameUpdater;

src-tauri/src/updates.rs

@@ -3,9 +3,9 @@ use std::sync::nonpoison::Mutex;
 use async_trait::async_trait;
 use client::{app_state::AppState, app_status::AppStatus};
 use database::{
-    DownloadableMetadata, GameDownloadStatus, GameVersion, borrow_db_checked, borrow_db_mut_checked,
+    GameDownloadStatus, GameVersion, borrow_db_checked, borrow_db_mut_checked,
 };
-use log::{info, warn};
+use log::warn;
 use process::PROCESS_MANAGER;
 use remote::utils::DROP_APP_HANDLE;
 use tauri::Manager;
@@ -44,12 +44,9 @@ impl ScheduleTask for GameUpdater {
         let state = app_handle.state::<Mutex<AppState>>();
         {
             let state_lock = state.lock();
-            match state_lock.status {
-                AppStatus::Offline => {
-                    self.no_internet = true;
-                    return Ok(());
-                }
-                _ => {}
+            if state_lock.status == AppStatus::Offline {
+                self.no_internet = true;
+                return Ok(());
             };
         };
 
@@ -58,7 +55,9 @@ impl ScheduleTask for GameUpdater {
         let to_check: Vec<GameVersion> = {
             let db_lock = borrow_db_checked();
 
-            let games = db_lock
+            
+
+            db_lock
                 .applications
                 .game_statuses
                 .values()
@@ -67,17 +66,14 @@ impl ScheduleTask for GameUpdater {
                     _ => None,
                 })
                 .map(|v| {
-                    v.map(|version_id| db_lock.applications.game_versions.get(version_id))
-                        .flatten()
+                    v.and_then(|version_id| db_lock.applications.game_versions.get(version_id))
                 })
                 .filter(|v| {
                     v.map(|v| v.user_configuration.enable_updates)
                         .unwrap_or(false)
                 })
                 .map(|v| v.cloned().unwrap())
-                .collect();
-
-            games
+                .collect()
         };
 
         for version in to_check {
@@ -99,7 +95,7 @@ impl ScheduleTask for GameUpdater {
                 .filter(|v| process_manager_lock.valid_platform(&v.platform))
                 .collect();
 
-            let latest = match valid_options.get(0) {
+            let latest = match valid_options.first() {
                 Some(v) => v,
                 None => {
                     warn!("found no versions for game id: {}", version.game_id);
@@ -113,13 +109,10 @@ impl ScheduleTask for GameUpdater {
                 .get_mut(&version.game_id)
                 .ok_or(anyhow::anyhow!(""))?;
 
-            match game_status {
-                GameDownloadStatus::Installed {
+            if let GameDownloadStatus::Installed {
                     update_available, ..
-                } => {
-                    *update_available = latest.version_id != version.version_id;
-                }
-                _ => (),
+                } = game_status {
+                *update_available = latest.version_id != version.version_id;
             };
         }