Skip to content

Commit bcbef72

Browse files
Chris53897Chris8934
Chris53897
and
Chris8934
authored
feat: drop support for symfony 7, doctrine/orm 2, .... (#172)
* feat: drop support for symfony 7, doctrine/orm 2, doctrine/doctrine-bundle 2, doctrine/dbal 3 bump versions * feat: allow phpunit/phpunit 13 --------- Co-authored-by: Christopher Georg <christopher.georg@sr-travel.de>
1 parent 06ba9b8 commit bcbef72

5 files changed

Lines changed: 47 additions & 53 deletions

File tree

‎.github/workflows/code_checks.yaml‎

Lines changed: 5 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -9,21 +9,15 @@ jobs:
99
strategy:
1010
fail-fast: false
1111
matrix:
12-
php: ['8.2']
12+
php: ['8.4']
1313
stability: [ prefer-stable ]
14-
symfony-version: ['7.4.*']
14+
symfony-version: ['8.0.*']
1515
include:
16-
- php: '8.2'
17-
symfony-version: 7.4.*
16+
- php: '8.4'
17+
symfony-version: 8.0.*
1818
stability: prefer-lowest
19-
- php: '8.3'
20-
symfony-version: 7.4.*
21-
stability: prefer-stable
2219
- php: '8.4'
23-
symfony-version: 7.4.*
24-
stability: prefer-stable
25-
- php: '8.5'
26-
symfony-version: 7.4.*
20+
symfony-version: 8.0.*
2721
stability: prefer-stable
2822
- php: '8.5'
2923
symfony-version: 8.0.*

‎.github/workflows/code_coverage.yaml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ jobs:
1010
- uses: actions/checkout@v6
1111
- uses: shivammathur/setup-php@v2
1212
with:
13-
php-version: 8.2
13+
php-version: 8.4
1414
coverage: pcov
1515

1616
- run: composer install --no-progress

‎Command/UnlockCommand.php‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
class UnlockCommand extends Command
2626
{
2727
private ObjectManager $em;
28-
public const DEFAULT_LOCK_TIME = 3600; // 1 hour
28+
public const int DEFAULT_LOCK_TIME = 3600; // 1 hour
2929
private SymfonyStyle $io;
3030

3131
private bool $unlockAll;

‎Tests/Service/ScheduledCommandQueryServiceTest.php‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ public function testFindEnabledCommandExcludesDisabled(): void
8888
{
8989
// Create a disabled command
9090
$command = $this->factory->create();
91-
$command->setName('test-disabled-' . uniqid());
91+
$command->setName('test-disabled-' . uniqid('', true));
9292
$command->setCommand('cache:clear');
9393
$command->setCronExpression('@daily');
9494
$command->setDisabled(true);
@@ -113,7 +113,7 @@ public function testFindEnabledCommandExcludesLocked(): void
113113
{
114114
// Create a locked command
115115
$command = $this->factory->create();
116-
$command->setName('test-locked-' . uniqid());
116+
$command->setName('test-locked-' . uniqid('', true));
117117
$command->setCommand('cache:clear');
118118
$command->setCronExpression('@daily');
119119
$command->setLocked(true);
@@ -138,7 +138,7 @@ public function testFindLockedCommandFindsLockedCommands(): void
138138
{
139139
// Create a locked command
140140
$command = $this->factory->create();
141-
$command->setName('test-find-locked-' . uniqid());
141+
$command->setName('test-find-locked-' . uniqid('', true));
142142
$command->setCommand('cache:clear');
143143
$command->setCronExpression('@daily');
144144
$command->setLocked(true);
@@ -164,7 +164,7 @@ public function testFindFailedCommandFindsFailedCommands(): void
164164
{
165165
// Create a failed command
166166
$command = $this->factory->create();
167-
$command->setName('test-failed-' . uniqid());
167+
$command->setName('test-failed-' . uniqid('', true));
168168
$command->setCommand('cache:clear');
169169
$command->setCronExpression('@daily');
170170
$command->setLastReturnCode(1); // Non-zero = failed
@@ -190,7 +190,7 @@ public function testGetNotLockedCommandReturnsNullForLockedCommand(): void
190190
{
191191
// Create a locked command
192192
$command = $this->factory->create();
193-
$command->setName('test-not-locked-' . uniqid());
193+
$command->setName('test-not-locked-' . uniqid('', true));
194194
$command->setCommand('cache:clear');
195195
$command->setCronExpression('@daily');
196196
$command->setLocked(true);
@@ -211,7 +211,7 @@ public function testGetNotLockedCommandReturnsCommandForUnlockedCommand(): void
211211
{
212212
// Create an unlocked command
213213
$command = $this->factory->create();
214-
$command->setName('test-unlocked-' . uniqid());
214+
$command->setName('test-unlocked-' . uniqid('', true));
215215
$command->setCommand('cache:clear');
216216
$command->setCronExpression('@daily');
217217
$command->setLocked(false);

‎composer.json‎

Lines changed: 34 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -16,46 +16,46 @@
1616
}
1717
],
1818
"require": {
19-
"php": ">=8.2",
20-
"doctrine/orm": "^2.20.8 || ^3.5",
21-
"doctrine/doctrine-bundle": "^2.18.0 || ^3.1",
22-
"doctrine/dbal": "^3.10.4 || ^4.4",
23-
"doctrine/persistence": "^3.4.1 || ^4.1",
19+
"php": ">=8.4",
20+
"doctrine/orm": "^3.6",
21+
"doctrine/doctrine-bundle": "^3.2",
22+
"doctrine/dbal": "^4.4",
23+
"doctrine/persistence": "^4.1",
2424
"dragonmantank/cron-expression": "^3.6",
25-
"knplabs/knp-time-bundle": "^2.4",
25+
"knplabs/knp-time-bundle": "^2.5",
2626
"lorisleiva/cron-translator": "^0.5.0",
27-
"symfony/asset": "^7.4 || ^8.0",
28-
"symfony/config": "^7.4 || ^8.0",
29-
"symfony/console": "^7.4 || ^8.0",
30-
"symfony/framework-bundle": "^7.4 || ^8.0",
31-
"symfony/twig-bundle": "^7.4 || ^8.0",
32-
"symfony/translation": "^7.4 || ^8.0",
33-
"symfony/finder": "^7.4 || ^8.0",
34-
"symfony/form": "^7.4 || ^8.0",
35-
"symfony/validator": "^7.4 || ^8.0",
36-
"symfony/lock": "^7.4 || ^8.0",
37-
"symfony/dependency-injection": "^7.4 || ^8.0",
38-
"symfony/property-access": "^7.4 || ^8.0",
39-
"symfony/http-kernel": "^7.4 || ^8.0",
40-
"symfony/routing": "^7.4 || ^8.0",
41-
"symfony/yaml": "^7.4 || ^8.0",
42-
"twig/twig": "^3.22"
27+
"symfony/asset": "^8.0",
28+
"symfony/config": "^8.0",
29+
"symfony/console": "^8.0",
30+
"symfony/framework-bundle": "^8.0",
31+
"symfony/twig-bundle": "^8.0",
32+
"symfony/translation": "^8.0",
33+
"symfony/finder": "^8.0",
34+
"symfony/form": "^8.0",
35+
"symfony/validator": "^8.0",
36+
"symfony/lock": "^8.0",
37+
"symfony/dependency-injection": "^8.0",
38+
"symfony/property-access": "^8.0",
39+
"symfony/http-kernel": "^8.0",
40+
"symfony/routing": "^8.0",
41+
"symfony/yaml": "^8.0",
42+
"twig/twig": "^3.23"
4343
},
4444
"require-dev": {
4545
"doctrine/doctrine-fixtures-bundle": "^4.3",
46-
"liip/test-fixtures-bundle": "^3.7",
46+
"liip/test-fixtures-bundle": "^3.8",
4747
"phpstan/phpstan": "^2.1",
48-
"phpunit/phpunit": "^11.5.48 || ^12.5.6 || ^13.0.1",
49-
"symfony/browser-kit": "^7.4 || ^8.0",
50-
"symfony/css-selector": "^7.4 || ^8.0",
51-
"symfony/debug-bundle": "^7.4 || ^8.0",
52-
"symfony/dom-crawler": "^7.4 || ^8.0",
53-
"symfony/dotenv": "^7.4 || ^8.0",
54-
"symfony/phpunit-bridge": "^7.4 || ^8.0",
55-
"symfony/http-client": "^7.4 || ^8.0",
56-
"symfony/notifier": "^7.4 || ^8.0",
48+
"phpunit/phpunit": "^13.0.1",
49+
"symfony/browser-kit": "^8.0",
50+
"symfony/css-selector": "^8.0",
51+
"symfony/debug-bundle": "^8.0",
52+
"symfony/dom-crawler": "^8.0",
53+
"symfony/dotenv": "^8.0",
54+
"symfony/phpunit-bridge": "^8.0",
55+
"symfony/http-client": "^8.0",
56+
"symfony/notifier": "^8.0",
5757
"symfony/maker-bundle": "^1.65",
58-
"symfony/var-dumper": "^7.4 || ^8.0"
58+
"symfony/var-dumper": "^8.0"
5959
},
6060
"suggest": {
6161
"ext-pcntl": "For using the scheduler daemon",
@@ -86,7 +86,7 @@
8686
"extra": {
8787
"symfony": {
8888
"allow-contrib": false,
89-
"require": "^7.4 || ^8.0"
89+
"require": "^8.0"
9090
}
9191
},
9292
"minimum-stability": "dev",

0 commit comments

Comments
 (0)