refactor: update integration tests for consolidated scripts

- Update imports from scripts.register_stac/augment_stac_item to scripts.register
- Test upsert_item, add_visualization_links, s3_to_https, rewrite_asset_hrefs functions
- Fix datetime to use datetime object instead of string
- Fix S1 test to use 'vh' asset key (matches implementation)
- All 6 integration tests passing

Author: wietzesuijker

tests/integration/test_stac_api.py

@@ -3,7 +3,8 @@
 These tests verify end-to-end scenarios with mocked external dependencies.
 """
 
-from unittest.mock import MagicMock, patch
+from datetime import UTC, datetime
+from unittest.mock import MagicMock
 
 import pytest
 from pystac import Asset, Item
@@ -13,144 +14,105 @@
 def test_pystac_item():
     """Sample pystac Item for testing."""
     item = Item(
-        id="S2B_test",
+        id="S2B_MSIL2A_20250101T000000_test",
         geometry=None,
         bbox=None,
-        datetime="2025-01-01T00:00:00Z",
+        datetime=datetime(2025, 1, 1, 0, 0, 0, tzinfo=UTC),
         properties={},
         collection="sentinel-2-l2a",
     )
+    item.add_asset(
+        "data",
+        Asset(
+            href="s3://bucket/test.zarr",
+            media_type="application/vnd+zarr",
+            roles=["data"],
+        ),
+    )
     item.add_asset(
         "TCI_10m",
         Asset(
-            href="https://example.com/data.zarr/TCI",
+            href="s3://bucket/test.zarr/measurements/reflectance/r10m/TCI",
             media_type="application/vnd+zarr",
             roles=["visual"],
         ),
     )
     return item
 
 
-@pytest.fixture
-def test_item_dict():
-    """Sample STAC item dictionary for registration tests."""
-    return {
-        "type": "Feature",
-        "stac_version": "1.0.0",
-        "id": "test-item",
-        "collection": "test-collection",
-        "geometry": None,
-        "bbox": None,
-        "properties": {"datetime": "2025-01-01T00:00:00Z"},
-        "assets": {},
-        "links": [],
-    }
-
+@pytest.mark.integration
+def test_upsert_item_creates_new(test_pystac_item):
+    """Test upsert_item creates new STAC item when it doesn't exist."""
+    from scripts.register import upsert_item
 
-@pytest.fixture
-def mock_stac_client():
-    """Mock pystac_client.Client for registration tests."""
+    # Mock client and collection
     mock_client = MagicMock()
     mock_collection = MagicMock()
     mock_client.get_collection.return_value = mock_collection
 
-    # Mock the StacApiIO session (httpx client)
-    mock_session = MagicMock()
-    mock_stac_io = MagicMock()
-    mock_stac_io.session = mock_session
-    mock_stac_io.timeout = 30
-    mock_client._stac_io = mock_stac_io
-
-    return mock_client
-
-
-@pytest.mark.integration
-def test_register_creates_new_item(test_item_dict, mock_stac_client):
-    """Test registration creates new STAC item when it doesn't exist."""
-    from scripts.register_stac import register_item
-
     # Mock item doesn't exist
-    mock_stac_client.get_collection().get_item.side_effect = Exception("Not found")
+    mock_collection.get_item.side_effect = Exception("Not found")
 
     # Mock successful POST
     mock_response = MagicMock()
     mock_response.status_code = 201
     mock_response.raise_for_status = MagicMock()
-    mock_stac_client._stac_io.session.post.return_value = mock_response
+    mock_stac_io = MagicMock()
+    mock_stac_io.session = MagicMock()
+    mock_stac_io.session.post.return_value = mock_response
+    mock_stac_io.timeout = 30
+    mock_client._stac_io = mock_stac_io
 
-    with patch("pystac_client.Client.open", return_value=mock_stac_client):
-        register_item(
-            stac_url="https://stac.example.com",
-            collection_id="test-collection",
-            item_dict=test_item_dict,
-            mode="create-or-skip",
-        )
+    upsert_item(mock_client, "test-collection", test_pystac_item)
 
-        # Verify POST was called to create item
-        assert mock_stac_client._stac_io.session.post.called
+    # Verify POST was called to create item
+    assert mock_stac_io.session.post.called
 
 
 @pytest.mark.integration
-def test_register_skips_existing_item(test_item_dict, mock_stac_client):
-    """Test registration skips when item already exists."""
-    from scripts.register_stac import register_item
-
-    # Mock item exists
-    mock_stac_client.get_collection().get_item.return_value = MagicMock()
+def test_upsert_item_updates_existing(test_pystac_item):
+    """Test upsert_item updates existing item."""
+    from scripts.register import upsert_item
 
-    with patch("pystac_client.Client.open", return_value=mock_stac_client):
-        register_item(
-            stac_url="https://stac.example.com",
-            collection_id="test-collection",
-            item_dict=test_item_dict,
-            mode="create-or-skip",
-        )
-
-        # Verify no POST/PUT/DELETE was called
-        assert not mock_stac_client._stac_io.session.post.called
-        assert not mock_stac_client._stac_io.session.put.called
-        assert not mock_stac_client._stac_io.session.delete.called
-
-
-@pytest.mark.integration
-def test_register_updates_existing_item(test_item_dict, mock_stac_client):
-    """Test registration updates existing item in upsert mode."""
-    from scripts.register_stac import register_item
+    # Mock client and collection
+    mock_client = MagicMock()
+    mock_collection = MagicMock()
+    mock_client.get_collection.return_value = mock_collection
 
     # Mock item exists
-    mock_stac_client.get_collection().get_item.return_value = MagicMock()
+    mock_collection.get_item.return_value = MagicMock()
 
     # Mock successful DELETE and POST
+    mock_stac_io = MagicMock()
+    mock_stac_io.session = MagicMock()
+    mock_stac_io.timeout = 30
+
     mock_delete_response = MagicMock()
     mock_delete_response.status_code = 204
     mock_delete_response.raise_for_status = MagicMock()
-    mock_stac_client._stac_io.session.delete.return_value = mock_delete_response
+    mock_stac_io.session.delete.return_value = mock_delete_response
 
     mock_post_response = MagicMock()
     mock_post_response.status_code = 201
     mock_post_response.raise_for_status = MagicMock()
-    mock_stac_client._stac_io.session.post.return_value = mock_post_response
+    mock_stac_io.session.post.return_value = mock_post_response
 
-    with patch("pystac_client.Client.open", return_value=mock_stac_client):
-        register_item(
-            stac_url="https://stac.example.com",
-            collection_id="test-collection",
-            item_dict=test_item_dict,
-            mode="upsert",
-        )
+    mock_client._stac_io = mock_stac_io
 
-        # Verify DELETE then POST was called
-        assert mock_stac_client._stac_io.session.delete.called
-        assert mock_stac_client._stac_io.session.post.called
+    upsert_item(mock_client, "test-collection", test_pystac_item)
+
+    # Verify DELETE then POST was called
+    assert mock_stac_io.session.delete.called
+    assert mock_stac_io.session.post.called
 
 
 @pytest.mark.integration
-def test_augmentation_adds_visualization_links(test_pystac_item):
-    """Test augmentation workflow adds visualization links."""
-    from scripts.augment_stac_item import add_visualization
+def test_add_visualization_links_s2(test_pystac_item):
+    """Test add_visualization_links for Sentinel-2."""
+    from scripts.register import add_visualization_links
 
     # Add visualization links
-    add_visualization(
+    add_visualization_links(
         item=test_pystac_item,
         raster_base="https://titiler.example.com",
         collection_id="sentinel-2-l2a",
@@ -159,44 +121,78 @@ def test_augmentation_adds_visualization_links(test_pystac_item):
     # Verify XYZ tile link added
     xyz_links = [link for link in test_pystac_item.links if link.rel == "xyz"]
     assert len(xyz_links) > 0
-    assert "titiler.example.com" in xyz_links[0].target
+    assert "titiler.example.com" in xyz_links[0].href
+    assert "TCI" in xyz_links[0].href or "tci" in xyz_links[0].href.lower()
 
     # Verify viewer link added
     viewer_links = [link for link in test_pystac_item.links if link.rel == "viewer"]
     assert len(viewer_links) > 0
 
+    # Verify EOPF Explorer link added
+    explorer_links = [link for link in test_pystac_item.links if "explorer" in link.href.lower()]
+    assert len(explorer_links) > 0
+
+
+@pytest.mark.integration
+def test_add_visualization_links_s1():
+    """Test add_visualization_links for Sentinel-1."""
+    from scripts.register import add_visualization_links
+
+    # Create S1 item
+    item = Item(
+        id="S1A_IW_GRDH_test",
+        geometry=None,
+        bbox=None,
+        datetime=datetime(2025, 1, 1, 0, 0, 0, tzinfo=UTC),
+        properties={},
+        collection="sentinel-1-grd",
+    )
+    item.add_asset(
+        "vh",
+        Asset(
+            href="s3://bucket/test.zarr/measurements/VH",
+            media_type="application/vnd+zarr",
+            roles=["data"],
+        ),
+    )
+
+    add_visualization_links(
+        item=item,
+        raster_base="https://titiler.example.com",
+        collection_id="sentinel-1-grd",
+    )
+
+    # Verify XYZ link contains VH
+    xyz_links = [link for link in item.links if link.rel == "xyz"]
+    assert len(xyz_links) > 0
+    assert "VH" in xyz_links[0].href or "vh" in xyz_links[0].href.lower()
+
 
 @pytest.mark.integration
-def test_augmentation_adds_projection(test_pystac_item):
-    """Test augmentation extracts projection information."""
-    from scripts.augment_stac_item import add_projection
+def test_s3_to_https_conversion():
+    """Test S3 URL to HTTPS conversion."""
+    from scripts.register import s3_to_https
 
-    # Mock zarr group with spatial_ref
-    # Note: This test validates the interface, actual zarr integration tested separately
-    add_projection(item=test_pystac_item)
+    result = s3_to_https("s3://bucket/path/file.zarr", "https://s3.example.com")
 
-    # Projection properties should be attempted (may not be set without real zarr)
-    # This validates the function can be called and handles missing data gracefully
-    assert test_pystac_item.properties is not None
+    assert result.startswith("https://")
+    assert "bucket" in result
+    assert "file.zarr" in result
 
 
 @pytest.mark.integration
-def test_full_augmentation_pipeline(test_pystac_item):
-    """Test complete augmentation pipeline."""
-    from scripts.augment_stac_item import augment
+def test_rewrite_asset_hrefs(test_pystac_item):
+    """Test asset href rewriting from old to new base."""
+    from scripts.register import rewrite_asset_hrefs
 
-    # Run full augmentation
-    result = augment(
+    rewrite_asset_hrefs(
         item=test_pystac_item,
-        raster_base="https://titiler.example.com",
-        collection_id="sentinel-2-l2a",
-        verbose=False,
+        old_base="s3://bucket",
+        new_base="s3://new-bucket",
+        s3_endpoint="https://s3.example.com",
     )
 
-    # Verify item returned
-    assert result.id == "S2B_test"
-
-    # Verify links added
-    assert len(result.links) > 0
-    xyz_count = sum(1 for link in result.links if link.rel == "xyz")
-    assert xyz_count > 0
+    # Verify assets were rewritten
+    for asset in test_pystac_item.assets.values():
+        assert "new-bucket" in asset.href
+        assert "bucket/" not in asset.href or "new-bucket" in asset.href