Skip to content

Commit a8009fe

Browse files
committed
fix: remove empty override args from workflow template
Empty string parameters caused argparse errors. Workflows now use collection-specific defaults from convert.py CONFIGS.
1 parent 58301ee commit a8009fe

File tree

2 files changed

+30
-3
lines changed

2 files changed

+30
-3
lines changed

workflows/README.md

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -114,6 +114,25 @@ Key parameters (see [../README.md](../README.md) for full reference):
114114
- `s3_output_bucket`: Output bucket
115115
- `pipeline_image_version`: Docker image tag
116116

117+
**Override conversion parameters** (optional, for testing):
118+
119+
```bash
120+
# Example: Test with different chunk size and disable sharding
121+
argo submit workflows/base/workflowtemplate.yaml \
122+
--from workflowtemplate/geozarr-pipeline \
123+
-p source_url="https://api.example.com/stac/.../items/ITEM_ID" \
124+
-p override_spatial_chunk="2048" \
125+
-p override_enable_sharding="false"
126+
```
127+
128+
Available overrides (empty = use collection defaults):
129+
- `override_groups`: Comma-separated zarr groups (e.g., `/measurements/reflectance/r10m`)
130+
- `override_spatial_chunk`: Chunk size (e.g., `2048`)
131+
- `override_tile_width`: Tile width (e.g., `512`)
132+
- `override_enable_sharding`: Enable sharding (`true`/`false`)
133+
134+
Defaults: S2 (1024/256/true), S1 (4096/512/false). See `scripts/get_conversion_params.py`.
135+
117136
### Resource Tuning
118137

119138
Edit `workflows/base/workflowtemplate.yaml`:

workflows/base/workflowtemplate.yaml

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ spec:
1111
secondsAfterCompletion: 86400
1212
podGC:
1313
strategy: OnPodSuccess
14-
deleteDelayDuration: 300s
14+
deleteDelayDuration: 3600s
1515
workflowMetadata:
1616
labels:
1717
workflows.argoproj.io/workflow-template: geozarr-pipeline
@@ -31,7 +31,16 @@ spec:
3131
- name: s3_output_prefix
3232
value: tests-output
3333
- name: pipeline_image_version
34-
value: slim
34+
value: feature-align-data-model
35+
# Optional conversion parameter overrides (empty = use collection defaults)
36+
- name: override_groups
37+
value: ""
38+
- name: override_spatial_chunk
39+
value: ""
40+
- name: override_tile_width
41+
value: ""
42+
- name: override_enable_sharding
43+
value: ""
3544
templates:
3645
- name: main
3746
dag:
@@ -58,7 +67,6 @@ spec:
5867
- "{{workflow.parameters.s3_output_bucket}}"
5968
- --s3-output-prefix
6069
- "{{workflow.parameters.s3_output_prefix}}"
61-
- --verbose
6270
resources:
6371
requests:
6472
memory: 4Gi

0 commit comments

Comments
 (0)