Updates after testing

1. svn_ignore_ancestry is optional argument everywhere (so testing does not
   need to be changed, though no tests run with svn_ignore_ancestry = True)
2. use keyword arguments for passing svn_ignore_ancestry since it is optional
3. Small formatting changes for pylint

Author: mnlevy1981

manic/checkout.py

@@ -355,7 +355,7 @@ def main(args):
                 "No component {} found in {}".format(
                     comp, args.externals))
 
-    source_tree = SourceTree(root_dir, external, args.svn_ignore_ancestry)
+    source_tree = SourceTree(root_dir, external, svn_ignore_ancestry=args.svn_ignore_ancestry)
     printlog('Checking status of externals: ', end='')
     tree_status = source_tree.status()
     printlog('')

manic/repository_factory.py

@@ -11,7 +11,7 @@
 from .utils import fatal_error
 
 
-def create_repository(component_name, repo_info, svn_ignore_ancestry):
+def create_repository(component_name, repo_info, svn_ignore_ancestry=False):
     """Determine what type of repository we have, i.e. git or svn, and
     create the appropriate object.
 
@@ -20,7 +20,7 @@ def create_repository(component_name, repo_info, svn_ignore_ancestry):
     if protocol == 'git':
         repo = GitRepository(component_name, repo_info)
     elif protocol == 'svn':
-        repo = SvnRepository(component_name, repo_info, svn_ignore_ancestry)
+        repo = SvnRepository(component_name, repo_info, ignore_ancestry=svn_ignore_ancestry)
     elif protocol == 'externals_only':
         repo = None
     else:

manic/repository_svn.py

@@ -37,7 +37,7 @@ class SvnRepository(Repository):
     """
     RE_URLLINE = re.compile(r'^URL:')
 
-    def __init__(self, component_name, repo, ignore_ancestry):
+    def __init__(self, component_name, repo, ignore_ancestry=False):
         """
         Parse repo (a <repo> XML element).
         """
@@ -277,7 +277,7 @@ def _svn_switch(url, ignore_ancestry, verbosity):
         """
         cmd = ['svn', 'switch', '--quiet']
         if ignore_ancestry:
-          cmd.append('--ignore-ancestry')
+            cmd.append('--ignore-ancestry')
         cmd.append(url)
         if verbosity >= VERBOSITY_VERBOSE:
             printlog('    {0}'.format(' '.join(cmd)))

manic/sourcetree.py

@@ -64,7 +64,8 @@ def __init__(self, root_dir, name, ext_description, svn_ignore_ancestry):
         if self._externals:
             self._create_externals_sourcetree()
         repo = create_repository(
-            name, ext_description[ExternalsDescription.REPO], svn_ignore_ancestry)
+            name, ext_description[ExternalsDescription.REPO],
+            svn_ignore_ancestry=svn_ignore_ancestry)
         if repo:
             self._repo = repo