BREAKING: renamed actions in handlers

"action" is an outdated terminology, and "handler" should be preferred.
Also RequestHandlerInterface is usually a better fit than MiddlewareInterface
for most our needs.

Author: PowerKiKi

src/Action/AbstractAction.php renamed to src/Handler/AbstractHandler.php

@@ -2,13 +2,13 @@
 
 declare(strict_types=1);
 
-namespace Ecodev\Felix\Action;
+namespace Ecodev\Felix\Handler;
 
 use Laminas\Diactoros\Response\JsonResponse;
 use Psr\Http\Message\ResponseInterface;
-use Psr\Http\Server\MiddlewareInterface;
+use Psr\Http\Server\RequestHandlerInterface;
 
-abstract class AbstractAction implements MiddlewareInterface
+abstract class AbstractHandler implements RequestHandlerInterface
 {
     protected function createError(string $message): ResponseInterface
     {

src/Action/FileAction.php renamed to src/Handler/FileHandler.php

@@ -2,16 +2,15 @@
 
 declare(strict_types=1);
 
-namespace Ecodev\Felix\Action;
+namespace Ecodev\Felix\Handler;
 
 use Doctrine\Persistence\ObjectRepository;
 use Ecodev\Felix\Model\File;
 use Laminas\Diactoros\Response;
 use Psr\Http\Message\ResponseInterface;
 use Psr\Http\Message\ServerRequestInterface;
-use Psr\Http\Server\RequestHandlerInterface;
 
-final class FileAction extends AbstractAction
+final class FileHandler extends AbstractHandler
 {
     /**
      * @var ObjectRepository
@@ -26,7 +25,7 @@ public function __construct(ObjectRepository $fileRepository)
     /**
      * Serve a downloaded file from disk
      */
-    public function process(ServerRequestInterface $request, RequestHandlerInterface $handler): ResponseInterface
+    public function handle(ServerRequestInterface $request): ResponseInterface
     {
         $id = $request->getAttribute('id');
 

src/Action/GraphQLAction.php renamed to src/Handler/GraphQLHandler.php

@@ -2,16 +2,15 @@
 
 declare(strict_types=1);
 
-namespace Ecodev\Felix\Action;
+namespace Ecodev\Felix\Handler;
 
 use Ecodev\Felix\Api\Server;
 use Laminas\Diactoros\Response\JsonResponse;
 use Psr\Http\Message\ResponseInterface;
 use Psr\Http\Message\ServerRequestInterface;
-use Psr\Http\Server\MiddlewareInterface;
 use Psr\Http\Server\RequestHandlerInterface;
 
-final class GraphQLAction implements MiddlewareInterface
+final class GraphQLHandler implements RequestHandlerInterface
 {
     /**
      * @var Server
@@ -27,7 +26,7 @@ public function __construct(Server $server)
      * Process an incoming server request and return a response, optionally delegating
      * to the next middleware component to create the response.
      */
-    public function process(ServerRequestInterface $request, RequestHandlerInterface $handler): ResponseInterface
+    public function handle(ServerRequestInterface $request): ResponseInterface
     {
         $response = $this->server->execute($request);
 

src/Action/ImageAction.php renamed to src/Handler/ImageHandler.php

@@ -2,17 +2,16 @@
 
 declare(strict_types=1);
 
-namespace Ecodev\Felix\Action;
+namespace Ecodev\Felix\Handler;
 
 use Doctrine\Persistence\ObjectRepository;
 use Ecodev\Felix\Model\Image;
 use Ecodev\Felix\Service\ImageResizer;
 use Laminas\Diactoros\Response;
 use Psr\Http\Message\ResponseInterface;
 use Psr\Http\Message\ServerRequestInterface;
-use Psr\Http\Server\RequestHandlerInterface;
 
-final class ImageAction extends AbstractAction
+final class ImageHandler extends AbstractHandler
 {
     /**
      * @var ObjectRepository
@@ -33,7 +32,7 @@ public function __construct(ObjectRepository $imageRepository, ImageResizer $ima
     /**
      * Serve an image from disk, with optional dynamic resizing
      */
-    public function process(ServerRequestInterface $request, RequestHandlerInterface $handler): ResponseInterface
+    public function handle(ServerRequestInterface $request): ResponseInterface
     {
         $id = $request->getAttribute('id');
 

tests/Action/ImageActionTest.php renamed to tests/Handler/ImageHandlerTest.php

@@ -2,20 +2,19 @@
 
 declare(strict_types=1);
 
-namespace EcodevTests\Felix\Action;
+namespace EcodevTests\Felix\Handler;
 
 use Doctrine\Persistence\ObjectRepository;
-use Ecodev\Felix\Action\ImageAction;
+use Ecodev\Felix\Handler\ImageHandler;
 use Ecodev\Felix\Model\Image;
 use Ecodev\Felix\Service\ImageResizer;
 use Laminas\Diactoros\ServerRequest;
 use org\bovigo\vfs\vfsStream;
 use PHPUnit\Framework\TestCase;
 use Psr\Http\Message\ResponseInterface;
 use Psr\Http\Message\ServerRequestInterface;
-use Psr\Http\Server\RequestHandlerInterface;
 
-class ImageActionTest extends TestCase
+class ImageHandlerTest extends TestCase
 {
     protected function setUp(): void
     {
@@ -45,7 +44,7 @@ public function testWillServeJpgByDefault(): void
         $request = new ServerRequest();
         $request = $request->withAttribute('maxHeight', $maxHeight);
 
-        $response = $this->process($repository, $imageResizer, $request);
+        $response = $this->handle($repository, $imageResizer, $request);
 
         self::assertSame('image/jpeg', $response->getHeaderLine('content-type'));
         self::assertSame('16', $response->getHeaderLine('content-length'));
@@ -68,18 +67,17 @@ public function testWillServeWebpIfAccepted(): void
         $request = $request->withAttribute('maxHeight', $maxHeight)
             ->withHeader('accept', 'text/html, image/webp, */*;q=0.8');
 
-        $response = $this->process($repository, $imageResizer, $request);
+        $response = $this->handle($repository, $imageResizer, $request);
 
         self::assertSame('image/webp', $response->getHeaderLine('content-type'));
         self::assertSame('15', $response->getHeaderLine('content-length'));
     }
 
-    private function process(ObjectRepository $repository, ImageResizer $imageResizer, ServerRequestInterface $request): ResponseInterface
+    private function handle(ObjectRepository $repository, ImageResizer $imageResizer, ServerRequestInterface $request): ResponseInterface
     {
-        $action = new ImageAction($repository, $imageResizer);
-        $handler = $this->createMock(RequestHandlerInterface::class);
+        $handler = new ImageHandler($repository, $imageResizer);
 
-        return $action->process($request, $handler);
+        return $handler->handle($request);
     }
 
     private function createImageMock(): Image