Skip to content

Commit 796b7a6

Browse files
committed
Multiple asserts are only available since PHP 7.3
This is unfortunately because multiple asserts are only fixed since laminas-permissions-acl 2.9.0 and that version only support PHP 7.3. So that forces us to not support PHP 7.2 for that specific features.
1 parent fdbda2c commit 796b7a6

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

.github/workflows/main.yml

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,8 @@ jobs:
3131
key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.lock') }}
3232
restore-keys: ${{ runner.os }}-composer-
3333

34-
- name: Remove lock for PHP 8
35-
if: matrix.php-version == '8.0'
34+
- name: Remove lock for newer PHP
35+
if: matrix.php-version != '7.2'
3636
run: rm composer.lock && composer require symfony/cache
3737

3838
- name: Install dependencies
@@ -120,6 +120,9 @@ jobs:
120120
key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.lock') }}
121121
restore-keys: ${{ runner.os }}-composer-
122122

123+
- name: Remove lock for newer PHP
124+
run: rm composer.lock && composer require symfony/cache
125+
123126
- name: Install dependencies
124127
run: composer install
125128

tests/Acl/AclTest.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,9 @@ public function __construct()
5959
self::assertSame('Non-logged user with role anonymous is not allowed on resource "User#null" with privilege "update"', $acl->getLastDenialMessage());
6060
}
6161

62+
/**
63+
* @requires PHP 7.3
64+
*/
6265
public function testMultipleReasons(): void
6366
{
6467
$acl = new class() extends Acl {

0 commit comments

Comments
 (0)