Skip to content

Commit d34b8c2

Browse files
IvanChepurnyiIvanChepurnyi
authored
Merge pull request #1 from edward-simpson/plugin-namespacing
Namespacing all events and plugins to prevent interference with others
2 parents 690c9ee + ca97bb8 commit d34b8c2

File tree

4 files changed

+12
-12
lines changed

4 files changed

+12
-12
lines changed

‎src/etc/frontend/di.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,14 +2,14 @@
22
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
33
xsi:noNamespaceSchemaLocation="urn:magento:framework:ObjectManager/etc/config.xsd">
44
<type name="Magento\CatalogInventory\Observer\AddInventoryDataObserver">
5-
<plugin name="after_product_load" type="EcomDev\ProductDataPreLoader\Observer\ProductAfterLoad" />
5+
<plugin name="EcomDev_ProductDataPreLoader::after_product_load" type="EcomDev\ProductDataPreLoader\Observer\ProductAfterLoad" />
66
</type>
77

88
<type name="Magento\Catalog\Model\ProductRepository">
9-
<plugin name="fix_store_id_of_get_by_id" type="EcomDev\ProductDataPreLoader\Plugin\FixMissingStoreIdInProductRepository" />
9+
<plugin name="EcomDev_ProductDataPreLoader::fix_store_id_of_get_by_id" type="EcomDev\ProductDataPreLoader\Plugin\FixMissingStoreIdInProductRepository" />
1010
</type>
1111

1212
<type name="Magento\Quote\Model\ResourceModel\Quote\Item\Collection">
13-
<plugin name="preserve_quote_for_item_collection" type="EcomDev\ProductDataPreLoader\Plugin\StoreShoppingCartIntoObserver" />
13+
<plugin name="EcomDev_ProductDataPreLoader::preserve_quote_for_item_collection" type="EcomDev\ProductDataPreLoader\Plugin\StoreShoppingCartIntoObserver" />
1414
</type>
1515
</config>

‎src/etc/frontend/events.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
11
<?xml version="1.0"?>
22
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:Event/etc/events.xsd">
33
<event name="catalog_product_collection_load_after">
4-
<observer name="preload_data_with_pre_loaders" instance="EcomDev\ProductDataPreLoader\Observer\ListCollectionAfterLoad" />
4+
<observer name="EcomDev_ProductDataPreLoader::preload_data_with_pre_loaders" instance="EcomDev\ProductDataPreLoader\Observer\ListCollectionAfterLoad" />
55
</event>
66

77
<event name="sales_quote_item_collection_products_after_load">
8-
<observer name="preload_data_with_pre_loaders" instance="EcomDev\ProductDataPreLoader\Observer\CartCollectionAfterLoad" />
8+
<observer name="EcomDev_ProductDataPreLoader::preload_data_with_pre_loaders" instance="EcomDev\ProductDataPreLoader\Observer\CartCollectionAfterLoad" />
99
</event>
1010

1111
<event name="catalog_product_load_after">
12-
<observer name="preload_data_with_pre_loaders" instance="EcomDev\ProductDataPreLoader\Observer\ProductAfterLoad"/>
12+
<observer name="EcomDev_ProductDataPreLoader::preload_data_with_pre_loaders" instance="EcomDev\ProductDataPreLoader\Observer\ProductAfterLoad"/>
1313
</event>
1414
</config>

‎src/etc/webapi_rest/di.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,14 +2,14 @@
22
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
33
xsi:noNamespaceSchemaLocation="urn:magento:framework:ObjectManager/etc/config.xsd">
44
<type name="Magento\CatalogInventory\Observer\AddInventoryDataObserver">
5-
<plugin name="after_product_load" type="EcomDev\ProductDataPreLoader\Observer\ProductAfterLoad" />
5+
<plugin name="EcomDev_ProductDataPreLoader::after_product_load" type="EcomDev\ProductDataPreLoader\Observer\ProductAfterLoad" />
66
</type>
77

88
<type name="Magento\Catalog\Model\ProductRepository">
9-
<plugin name="fix_store_id_of_get_by_id" type="EcomDev\ProductDataPreLoader\Plugin\FixMissingStoreIdInProductRepository" />
9+
<plugin name="EcomDev_ProductDataPreLoader::fix_store_id_of_get_by_id" type="EcomDev\ProductDataPreLoader\Plugin\FixMissingStoreIdInProductRepository" />
1010
</type>
1111

1212
<type name="Magento\Quote\Model\ResourceModel\Quote\Item\Collection">
13-
<plugin name="preserve_quote_for_item_collection" type="EcomDev\ProductDataPreLoader\Plugin\StoreShoppingCartIntoObserver" />
13+
<plugin name="EcomDev_ProductDataPreLoader::preserve_quote_for_item_collection" type="EcomDev\ProductDataPreLoader\Plugin\StoreShoppingCartIntoObserver" />
1414
</type>
1515
</config>

‎src/etc/webapi_rest/events.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
11
<?xml version="1.0"?>
22
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:Event/etc/events.xsd">
33
<event name="catalog_product_collection_load_after">
4-
<observer name="preload_data_with_pre_loaders" instance="EcomDev\ProductDataPreLoader\Observer\ListCollectionAfterLoad" />
4+
<observer name="EcomDev_ProductDataPreLoader::preload_data_with_pre_loaders" instance="EcomDev\ProductDataPreLoader\Observer\ListCollectionAfterLoad" />
55
</event>
66

77
<event name="core_collection_abstract_load_after">
8-
<observer name="preload_data_with_pre_loaders" instance="EcomDev\ProductDataPreLoader\Observer\CartCollectionAfterLoad" />
8+
<observer name="EcomDev_ProductDataPreLoader::preload_data_with_pre_loaders" instance="EcomDev\ProductDataPreLoader\Observer\CartCollectionAfterLoad" />
99
</event>
1010

1111
<event name="catalog_product_load_after">
12-
<observer name="preload_data_with_pre_loaders" instance="EcomDev\ProductDataPreLoader\Observer\ProductAfterLoad"/>
12+
<observer name="EcomDev_ProductDataPreLoader::preload_data_with_pre_loaders" instance="EcomDev\ProductDataPreLoader\Observer\ProductAfterLoad"/>
1313
</event>
1414
</config>

0 commit comments

Comments
 (0)