stan lvl 9

Author: QuentinGab

composer.json

@@ -24,13 +24,14 @@
         "spatie/laravel-package-tools": "^1.14"
     },
     "require-dev": {
+        "larastan/larastan": "^3.0.0",
         "laravel/pint": "^1.0",
         "nunomaduro/collision": "^8.1",
-        "larastan/larastan": "^3.0.0",
         "orchestra/testbench": "^9.0",
         "pestphp/pest": "^3.0",
         "pestphp/pest-plugin-arch": "^3.0",
         "pestphp/pest-plugin-laravel": "^3.0",
+        "phpstan/extension-installer": "^1.4",
         "phpstan/phpstan-deprecation-rules": "^2.0",
         "phpstan/phpstan-phpunit": "^2.0"
     },

config/invoices.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 use Finller\Invoice\Invoice;
 use Finller\Invoice\InvoiceDiscount;
 use Finller\Invoice\InvoiceItem;

database/factories/InvoiceFactory.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Finller\Invoice\Database\Factories;
 
 use Carbon\Carbon;

database/factories/InvoiceItemFactory.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Finller\Invoice\Database\Factories;
 
 use Brick\Money\Money;
@@ -15,8 +17,10 @@ class InvoiceItemFactory extends Factory
 
     public function definition()
     {
-        $price = Money::ofMinor(fake()->numberBetween(1000, 100000), config('invoices.default_currency'));
-        $unit_tax = Money::ofMinor(fake()->numberBetween(0, $price->getAmount()->toFloat()), config('invoices.default_currency'));
+        $currency = config()->string('invoices.default_currency');
+
+        $price = Money::ofMinor(fake()->numberBetween(1000, 100000), $currency);
+        $unit_tax = Money::ofMinor(fake()->numberBetween(0, $price->getAmount()->toFloat()), $currency);
 
         $useTaxPercentage = fake()->boolean();
 

phpstan-baseline.neon

@@ -1,8 +1,8 @@
 includes:
-    - vendor/larastan/larastan/extension.neon
+    - phpstan-baseline.neon
 
 parameters:
-    level: 6
+    level: 9
     paths:
         - src
         - config
@@ -11,6 +11,4 @@ parameters:
     checkOctaneCompatibility: true
     checkModelProperties: true
     checkModelAppends: false
-    noEnvCallsOutsideOfConfig: false
-    ignoreErrors:
-        - '#Method Finller\\Invoice\\InvoiceDiscount::fromLivewire\(\) has no return type specified#'
+    noEnvCallsOutsideOfConfig: false

phpstan.neon.dist

@@ -1,5 +1,8 @@
 {
-    "exclude": [
-        "build"
-    ]
+    "preset": "laravel",
+    "rules": {
+        "declare_strict_types": true,
+        "explicit_string_variable": true,
+        "mb_str_functions": true
+    }
 }

pint.json

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 return [
     /*
     |--------------------------------------------------------------------------

resources/lang/en/invoice.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 return [
     /*
     |--------------------------------------------------------------------------

resources/lang/fr/invoice.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Finller\Invoice\Casts;
 
 use Finller\Invoice\InvoiceDiscount;
@@ -14,16 +16,29 @@ class Discounts implements CastsAttributes
 {
     /**
      * @param  array<string, mixed>  $attributes
-     * @return null|InvoiceDiscount[]
+     * @return InvoiceDiscount[]
      */
     public function get(Model $model, string $key, mixed $value, array $attributes): mixed
     {
-        $data = Json::decode(data_get($attributes, $key, ''));
+        /**
+         * @var null|array<array-key, null|array{
+         *      name: ?string,
+         *      code: ?string,
+         *      currency: ?string,
+         *      amount_off: ?int,
+         *      percent_off: ?float,
+         * }> $data
+         */
+        $data = Json::decode($attributes[$key] ?? '');
+
+        /** @var class-string<InvoiceDiscount> $class */
+        $class = config()->string('invoices.discount_class');
 
-        /** @var string $class */
-        $class = config('invoices.discount_class');
+        if (! is_array($data)) {
+            return [];
+        }
 
-        return is_array($data) ? array_map(fn (?array $item) => $class::fromArray($item), $data) : null;
+        return array_map(fn ($item) => $class::fromArray($item), $data);
     }
 
     /**
@@ -35,6 +50,8 @@ public function get(Model $model, string $key, mixed $value, array $attributes):
      */
     public function set(Model $model, string $key, mixed $value, array $attributes): mixed
     {
-        return [$key => Json::encode($value)];
+        return [
+            $key => blank($value) ? null : Json::encode($value),
+        ];
     }
 }