Merge pull request #40 from bizexcel/main

Fix PDF invoice crash when item price is zero

Author: QuentinGab

src/Pdf/PdfInvoice.php

@@ -133,38 +133,41 @@ public function subTotalDiscountedAmount(): Money
      */
     public function totalTaxAmount(): Money
     {
-        if (empty($this->items)) {
-            return Money::of(0, $this->getCurrency());
-        }
-
         $totalDiscount = $this->totalDiscountAmount();
 
         /**
-         * Taxes must be calculated on the discounted subtotal.
-         * Since discounts apply at the invoice level and taxes at the item level,
-         * we allocate the discount across items before computing taxes.
+         * Taxes must be calculated based on the discounted subtotal.
+         * Since discounts are applied at the invoice level, but taxes are calculated at the item level,
+         * we allocate the total discount proportionally across individual items before computing taxes.
          */
-        $allocatedDiscounts = $totalDiscount->allocate(...array_map(
+        $ratios = array_map(
             fn ($item) => $item->subTotalAmount()->abs()->getMinorAmount()->toInt(),
             $this->items
-        ));
+        );
+
+        if (array_sum($ratios) === 0) {
+            return Money::of(0, $this->getCurrency());
+        }
+
+        $allocatedDiscounts = $totalDiscount->allocate(...$ratios);
 
         $totalTaxAmount = Money::of(0, $this->getCurrency());
 
         foreach ($this->items as $index => $item) {
 
             if ($item->unit_tax) {
                 /**
-                 * When unit_tax is defined, the amount is considered right
-                 * and the discount is not apply
+                 * When unit_tax is defined, the amount is considered correct
                  */
                 $itemTaxAmount = $item->unit_tax->multipliedBy($item->quantity);
             } elseif ($item->tax_percentage) {
+
                 $itemDiscount = $allocatedDiscounts[$index];
 
                 $itemTaxAmount = $item->subTotalAmount()
                     ->minus($itemDiscount)
                     ->multipliedBy($item->tax_percentage / 100.0, roundingMode: RoundingMode::HALF_EVEN);
+
             } else {
                 $itemTaxAmount = Money::of(0, $totalTaxAmount->getCurrency());
             }

tests/Feature/PdfInvoiceTest.php

@@ -45,6 +45,10 @@
     expect($pdfInvoice->totalTaxAmount()->getAmount()->toFloat())->toEqual($totalTaxAmount);
     expect($pdfInvoice->totalAmount()->getAmount()->toFloat())->toEqual($totalAmount);
 })->with([
+    [[], 0.0, 0.0, 0.0, 0.0, 0.0, 0.0],
+    [[['unit_price' => 0.0]], 0.0, 0.0, 0.0, 0.0, 0.0, 0.0],
+    [[['unit_price' => 0.0]], 10.0, 0.0, 0.0, 0.0, 0.0, 0.0],
+    [[['unit_price' => 0.0]], 10.0, 10.0, 0.0, 0.0, 0.0, 0.0],
     [[['unit_price' => 100.0]], 0.0, 0.0, 100.0, 0.0, 0.0, 100.0],
     [[['unit_price' => 100.0, 'quantity' => 2]], 0.0, 0.0, 200.0, 0.0, 0.0, 200.0],
     [[['unit_price' => 100.0, 'quantity' => 0.1]], 0.0, 0.0, 10.0, 0.0, 0.0, 10.0],