Merge pull request #18 from ElegantEngineeringTech/v4

mini V4 fixes

Author: QuentinGab

src/Converters/MediaConverter.php

@@ -150,7 +150,11 @@ public function handle(): ?MediaConversion
             return $this->convert($this->media, $parent, $copy, $storage, $temporaryDirectory);
         });
 
-        if ($mediaConversion && $this->withChildren) {
+        if (
+            $mediaConversion &&
+            $mediaConversion->state === MediaConversionState::Succeeded &&
+            $this->withChildren
+        ) {
             $this->media->generateConversions(
                 parent: $mediaConversion,
                 filter: fn ($definition) => $definition->immediate,

src/MediaConversionDefinition.php

@@ -13,9 +13,9 @@ class MediaConversionDefinition
 {
     /**
      * @param  (Closure(Media $media): MediaConverter)  $converter
-     * @param  bool  $immediate  Determine if the conversion should be dispatched immediatly and synchronously after the media is added
-     * @param  MediaConversionDefinition[]  $conversions
+     * @param  null|bool|(Closure(Media $media, ?MediaConversion $parent): null|bool)  $when
      * @param  null|(Closure(?MediaConversion $conversion, Media $media, ?MediaConversion $parent): void)  $onCompleted
+     * @param  MediaConversionDefinition[]  $conversions
      */
     public function __construct(
         public string $name,