declare_strict_types

QuentinGab · QuentinGab · commit b751b0922846 · 2025-01-11T17:02:02.000+01:00
diff --git a/config/media.php b/config/media.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 use Elegantly\Media\Jobs\DeleteModelMediaJob;
 use Elegantly\Media\Models\Media;
 
diff --git a/database/factories/MediaConversionFactory.php b/database/factories/MediaConversionFactory.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Elegantly\Media\Database\Factories;
 
 use Elegantly\Media\Enums\MediaType;
diff --git a/database/factories/MediaFactory.php b/database/factories/MediaFactory.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Elegantly\Media\Database\Factories;
 
 use Elegantly\Media\Enums\MediaType;
diff --git a/pint.json b/pint.json
@@ -0,0 +1,6 @@
+{
+    "preset": "laravel",
+    "rules": {
+        "declare_strict_types": true
+    }
+}
diff --git a/src/Commands/GenerateMediaConversionsCommand.php b/src/Commands/GenerateMediaConversionsCommand.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Elegantly\Media\Commands;
 
 use Elegantly\Media\Definitions\MediaConversionDefinition;
diff --git a/src/Concerns/HasMedia.php b/src/Concerns/HasMedia.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Elegantly\Media\Concerns;
 
 use Elegantly\Media\Events\MediaAddedEvent;
diff --git a/src/Concerns/InteractWithFiles.php b/src/Concerns/InteractWithFiles.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Elegantly\Media\Concerns;
 
 use Carbon\CarbonInterval;
diff --git a/src/Contracts/InteractWithMedia.php b/src/Contracts/InteractWithMedia.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Elegantly\Media\Contracts;
 
 use Elegantly\Media\MediaCollection;
diff --git a/src/Definitions/MediaConversionAudio.php b/src/Definitions/MediaConversionAudio.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Elegantly\Media\Definitions;
 
 use Closure;
diff --git a/src/Definitions/MediaConversionDefinition.php b/src/Definitions/MediaConversionDefinition.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Elegantly\Media\Definitions;
 
 use Closure;
diff --git a/src/Definitions/MediaConversionImage.php b/src/Definitions/MediaConversionImage.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Elegantly\Media\Definitions;
 
 use Closure;
diff --git a/src/Definitions/MediaConversionPoster.php b/src/Definitions/MediaConversionPoster.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Elegantly\Media\Definitions;
 
 use Closure;
diff --git a/src/Definitions/MediaConversionVideo.php b/src/Definitions/MediaConversionVideo.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Elegantly\Media\Definitions;
 
 use Closure;
diff --git a/src/Enums/MediaType.php b/src/Enums/MediaType.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Elegantly\Media\Enums;
 
 use Elegantly\Media\Helpers\File;
diff --git a/src/Events/MediaAddedEvent.php b/src/Events/MediaAddedEvent.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Elegantly\Media\Events;
 
 use Elegantly\Media\Models\Media;
diff --git a/src/Events/MediaConversionAddedEvent.php b/src/Events/MediaConversionAddedEvent.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Elegantly\Media\Events;
 
 use Elegantly\Media\Models\MediaConversion;
diff --git a/src/Events/MediaFileStoredEvent.php b/src/Events/MediaFileStoredEvent.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Elegantly\Media\Events;
 
 use Elegantly\Media\Models\Media;
diff --git a/src/FileDownloaders/FileDownloader.php b/src/FileDownloaders/FileDownloader.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Elegantly\Media\FileDownloaders;
 
 use Elegantly\Media\Helpers\File;
diff --git a/src/Helpers/File.php b/src/Helpers/File.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Elegantly\Media\Helpers;
 
 use Elegantly\Media\Enums\MediaType;
diff --git a/src/Helpers/HasDimension.php b/src/Helpers/HasDimension.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Elegantly\Media\Helpers;
 
 use FFMpeg\Coordinate\AspectRatio;
diff --git a/src/Helpers/Image.php b/src/Helpers/Image.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Elegantly\Media\Helpers;
 
 use FFMpeg\Coordinate\AspectRatio;
diff --git a/src/Helpers/Video.php b/src/Helpers/Video.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Elegantly\Media\Helpers;
 
 use FFMpeg\Coordinate\AspectRatio;
diff --git a/src/Jobs/DeleteModelMediaJob.php b/src/Jobs/DeleteModelMediaJob.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Elegantly\Media\Jobs;
 
 use Elegantly\Media\Models\Media;
diff --git a/src/Jobs/MediaConversionJob.php b/src/Jobs/MediaConversionJob.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Elegantly\Media\Jobs;
 
 use Elegantly\Media\Models\Media;
diff --git a/src/MediaCollection.php b/src/MediaCollection.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Elegantly\Media;
 
 use Closure;
diff --git a/src/MediaServiceProvider.php b/src/MediaServiceProvider.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Elegantly\Media;
 
 use Elegantly\Media\Commands\GenerateMediaConversionsCommand;
diff --git a/src/MediaZipper.php b/src/MediaZipper.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Elegantly\Media;
 
 use Elegantly\Media\Models\Media;
diff --git a/src/Models/Media.php b/src/Models/Media.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Elegantly\Media\Models;
 
 use Carbon\Carbon;
@@ -288,7 +290,9 @@ public function executeConversion(
         if ($definition = $this->getConversionDefinition($conversion)) {
 
             if (str_contains($conversion, '.')) {
-                $parent = $this->getOrExecuteConversion(str($conversion)->beforeLast('.'));
+                $parent = $this->getOrExecuteConversion(
+                    str($conversion)->beforeLast('.')->value()
+                );
                 /**
                  * Parent conversion can't be done, so children can't be executed either.
                  */
@@ -335,7 +339,9 @@ public function getParentConversion(string $name): ?MediaConversion
             return null;
         }
 
-        return $this->getConversion(str($name)->beforeLast('.'));
+        return $this->getConversion(
+            str($name)->beforeLast('.')->value()
+        );
     }
 
     /**
@@ -571,10 +577,11 @@ public function makeFreshPath(
                 ->append('conversions/')
                 ->append(str_replace('.', '/conversions/', $conversion))
                 ->finish('/')
-                ->append($fileName ?? '');
+                ->append($fileName ?? '')
+                ->value();
         }
 
-        return $root->append($fileName ?? '');
+        return $root->append($fileName ?? '')->value();
     }
 
     /**
diff --git a/src/Models/MediaConversion.php b/src/Models/MediaConversion.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Elegantly\Media\Models;
 
 use Carbon\Carbon;
diff --git a/src/TemporaryDirectory.php b/src/TemporaryDirectory.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Elegantly\Media;
 
 use Closure;
diff --git a/src/Traits/HasUuid.php b/src/Traits/HasUuid.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Elegantly\Media\Traits;
 
 use Illuminate\Support\Str;
diff --git a/tests/ArchTest.php b/tests/ArchTest.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 it('will not use debugging functions')
     ->expect(['dd', 'dump', 'ray'])
     ->each->not->toBeUsed();
diff --git a/tests/ExampleTest.php b/tests/ExampleTest.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 // it('can test', function () {
 //     expect(true)->toBeTrue();
 // });
diff --git a/tests/Feature/HasMediaTest.php b/tests/Feature/HasMediaTest.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 use Elegantly\Media\MediaCollection;
 use Elegantly\Media\Models\Media;
 use Elegantly\Media\Tests\Models\Test;
diff --git a/tests/Feature/HasMediaTransformationsTest.php b/tests/Feature/HasMediaTransformationsTest.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 use Elegantly\Media\Tests\Models\Test;
 use Illuminate\Support\Facades\Storage;
 
diff --git a/tests/Feature/InteractWithFilesTest.php b/tests/Feature/InteractWithFilesTest.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 use Elegantly\Media\Database\Factories\MediaFactory;
 use Elegantly\Media\Helpers\File;
 use Elegantly\Media\Models\Media;
diff --git a/tests/Feature/MediaCollectionTest.php b/tests/Feature/MediaCollectionTest.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 use Elegantly\Media\Definitions\MediaConversionDefinition;
 use Elegantly\Media\MediaCollection;
 
diff --git a/tests/Feature/MediaConversionTest.php b/tests/Feature/MediaConversionTest.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 use Elegantly\Media\Database\Factories\MediaFactory;
 use Elegantly\Media\Models\Media;
 use Illuminate\Http\UploadedFile;
diff --git a/tests/Feature/MediaConversionVideoTest.php b/tests/Feature/MediaConversionVideoTest.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 use Elegantly\Media\Jobs\MediaConversionJob;
 use Elegantly\Media\Tests\Models\Test;
 use Illuminate\Support\Facades\Queue;
diff --git a/tests/Feature/MediaTest.php b/tests/Feature/MediaTest.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 use Elegantly\Media\Database\Factories\MediaFactory;
 use Elegantly\Media\Definitions\MediaConversionDefinition;
 use Elegantly\Media\Models\Media;
diff --git a/tests/Feature/MediaZipperTest.php b/tests/Feature/MediaZipperTest.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 use Elegantly\Media\Database\Factories\MediaFactory;
 use Elegantly\Media\MediaZipper;
 use Elegantly\Media\Models\Media;
diff --git a/tests/Models/Test.php b/tests/Models/Test.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Elegantly\Media\Tests\Models;
 
 use Elegantly\Media\Concerns\HasMedia;
diff --git a/tests/Models/TestSoftDelete.php b/tests/Models/TestSoftDelete.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Elegantly\Media\Tests\Models;
 
 use Illuminate\Database\Eloquent\SoftDeletes;
diff --git a/tests/Pest.php b/tests/Pest.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 use Elegantly\Media\Tests\TestCase;
 
 uses(TestCase::class)->in(__DIR__);
diff --git a/tests/TestCase.php b/tests/TestCase.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Elegantly\Media\Tests;
 
 use Elegantly\Media\MediaServiceProvider;
diff --git a/tests/Unit/FileDownloaderTest.php b/tests/Unit/FileDownloaderTest.php
diff --git a/tests/Unit/FileTest.php b/tests/Unit/FileTest.php
diff --git a/tests/Unit/IntercatWithMediaTest.php b/tests/Unit/IntercatWithMediaTest.php
diff --git a/tests/Unit/MigrateGeneratedConversionsTest.php b/tests/Unit/MigrateGeneratedConversionsTest.php
diff --git a/tests/Unit/VideoTest.php b/tests/Unit/VideoTest.php
diff --git a/workbench/app/Providers/WorkbenchServiceProvider.php b/workbench/app/Providers/WorkbenchServiceProvider.php
