Incorrect usage of RabbitMQ connections can lead to socket exhaustion

[jdtaylor91]

Problem

Incorrect usage of RabbitMQ connections can lead to socket exhaustion.

The library doesn't treat RabbitMQ connections as singletons. Every instance of RabbitMQQueueClient created by an application will create a new connection to RabbitMQ.

The recommended approach for RabbitMQ is to share a single connection.

Suggestion

The RabbitMQQueueClient instance should internally cache the connection so that it can be reused for subsequent instances. The connection could be cached by a hash of the RabbitMQQueueClientFactoryOptions to ensure that multiple connections for different RabbitMQ hosts can be supported. Only options that relate to the connection should be used for the hash.

It is recommended that a single connection but multiple channels are used, therefore each instance of RabbitMQQueueClient should still create it's own channel.

References

• https://derickbailey.com/2014/03/26/2-lessons-learned-and-3-resources-for-for-learning-rabbitmq-on-nodejs/

• https://stackoverflow.com/questions/10407760/is-there-a-performance-difference-between-pooling-connections-or-channels-in-rab

• http://lists.rabbitmq.com/pipermail/rabbitmq-discuss/2012-March/018683.html