review comment fixes

Author: shashankbrgowda

app/api/resources/templates/shared/appbar.html

@@ -1,7 +1,7 @@
 <div class="topbar">
     <div class="topbar-left">
         <div class="home-link">
-            <a href="https://beta.ensembl.org/">
+            <a href="https://beta.ensembl.org/" aria-label="Ensembl home page">
                 {% include "shared/_home_icon.html" %}
             </a>
         </div>

app/api/resources/templates/shared/id_content.html

@@ -16,7 +16,7 @@
                 <div class="genome-detail-container"
                     data-genome-browser-url="{{ item.genome_browser_url }}"
                     data-entity-viewer-url="{{ item.entity_viewer_url }}">
-                    <a href="{{ item.entity_viewer_url }}" class="genome-detail genome-detail-tooltip" aria-label="Show tooltip">
+                    <a href="{{ item.entity_viewer_url }}" class="genome-detail genome-detail-tooltip">
                         {% if item.common_name %}
                           {{ item.common_name }},
                         {% endif %}
@@ -44,10 +44,10 @@
             <div id="tooltip" style="display:none; position:absolute;" role="tooltip" aria-hidden="true">
                 <div class="tooltip-content">
                     <span class="tooltip-content-title">View in</span>
-                    <a id="genome-browser-link" href="#" aria-label="Genome Browser link">
+                    <a id="genome-browser-link" href="#" aria-label="Genome Browser">
                         {% include "shared/_genome_browser_icon.html" %}
                     </a>
-                    <a id="entity-viewer-link" href="#" aria-label="Entity Viewer link">
+                    <a id="entity-viewer-link" href="#" aria-label="Entity Viewer">
                         {% include "shared/_entity_viewer_icon.html" %}
                     </a>
                 </div>

app/static/css/styles.css

@@ -1,7 +1,7 @@
 :root {
   --standard-gutter: 30px;
   --global-padding-left: calc(var(--standard-gutter) * 4);
-  --color-light-blue: #0099ff;
+  --color-blue: #0099ff;
   --font-weight-light: 300;
   --color-medium-dark-grey: #9aa7b1;
   --color-red: #d90000;
@@ -60,7 +60,7 @@ body {
 }
 
 .copyright a {
-  color: var(--color-light-blue);
+  color: var(--color-blue);
   text-decoration: none;
 }
 
@@ -91,7 +91,6 @@ body {
 .id-redirect-content {
   margin-top: 30px;
   text-align: center;
-  width: 100%;
 }
 
 .redirect-text {
@@ -110,12 +109,12 @@ body {
 
 .footer-link a {
   font-size: 12px;
-  color: var(--color-light-blue);
+  color: var(--color-blue);
   text-decoration: none;
 }
 
 .link {
-  color: var(--color-light-blue);
+  color: var(--color-blue);
   text-decoration: none;
   font-size: 13px;
 }
@@ -204,7 +203,7 @@ body {
 .genome-detail {
   font-size: 13px;
   text-decoration: none;
-  color: var(--color-light-blue);
+  color: var(--color-blue);
 }
 
 .genome-detail-margin-left {
@@ -244,7 +243,7 @@ body {
 
 #genome-browser-link,
 #entity-viewer-link {
-  background-color: var(--color-light-blue);
+  background-color: var(--color-blue);
   padding: 2px 4px;
   margin-left: 20px;
   display: inline-block;

app/static/js/index.js

@@ -2,7 +2,6 @@ function closeTooltip() {
   const tooltip = document.getElementById('tooltip');
   if (tooltip) {
     tooltip.style.display = 'none';
-    tooltip.setAttribute('aria-hidden', 'true');
   }
 }
 
@@ -14,10 +13,10 @@ function showTooltip(el) {
   const entityViewerLink = document.getElementById('entity-viewer-link');
 
   if (genomeBrowserLink) {
-    genomeBrowserLink.href = el.dataset.genomeBrowserUrl || '#';
+    genomeBrowserLink.href = el.dataset.genomeBrowserUrl;
   }
   if (entityViewerLink) {
-    entityViewerLink.href = el.dataset.entityViewerUrl || '#';
+    entityViewerLink.href = el.dataset.entityViewerUrl;
   }
 
   const target = el.querySelector('.genome-detail-tooltip');
@@ -28,6 +27,7 @@ function showTooltip(el) {
   const rect = target.getBoundingClientRect();
   tooltip.style.top = (rect.top - 15 + window.scrollY) + 'px';
   tooltip.style.left = (rect.right + 10 + window.scrollX) + 'px';
+  genomeBrowserLink.focus();
 }
 
 document.querySelectorAll('.genome-detail-container').forEach(function(el) {