Skip to content

Commit bc98e70

Browse files
authored
Merge pull request #12 from Ensembl/fix-type-field
Fix type field
2 parents 8247a97 + 8f5aa1d commit bc98e70

File tree

4 files changed

+19
-7
lines changed

4 files changed

+19
-7
lines changed

app/api/models/resolver.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
from typing import Optional, Literal, List
1+
from typing import Optional, Literal, List, Dict
22
from pydantic import BaseModel, Field
33

44

@@ -31,7 +31,8 @@ class MetadataResult(BaseModel):
3131
assembly: Assembly
3232
scientific_name: str
3333
common_name: str
34-
type: Optional[str] = None
34+
type: Optional[Dict[str, str]] = None
35+
is_reference: bool = False
3536

3637

3738
class ResolvedPayload(MetadataResult):

app/api/resources/templates/search_results.html

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,17 @@ <h1>Resolved URLs</h1>
2121
<td>{{ item.assembly.accession_id }}</td>
2222
<td>{{ item.scientific_name }}</td>
2323
<td>{{ item.common_name }}</td>
24-
<td>{{ item.species }}</td>
25-
<td>{{ item.type }}</td>
24+
<td>
25+
{% if item.type and item.is_reference %}
26+
{{ item.type.kind }} - {{ item.type.value }}, Reference
27+
{% elif item.is_reference %}
28+
Reference
29+
{% elif item.type %}
30+
{{ item.type.kind }} - {{ item.type.value }}
31+
{% else %}
32+
-
33+
{% endif %}
34+
</td>
2635
<td>
2736
<a href="{{ item.resolved_url }}">Ensembl</a>
2837
</td>

app/static/APISpecification.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,9 @@ paths:
8787
resolved_url:
8888
type: string
8989
description: Resolved url to Ensembl site
90+
is_reference:
91+
type: boolean
92+
description: Whether a genome is reference or not
9093
'302':
9194
description: Redirect to resolved URL
9295
headers:

requirements-dev.txt

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
11
-r requirements.txt
2-
pre-commit=3.8.0
3-
black=24.8.0
4-
flake8==7.1.1
2+
pre-commit==3.8.0
3+
black==24.8.0

0 commit comments

Comments
 (0)