bbrooks/4361-Fix-Packer-Validation-AMI-Builds (#4362)

* Removing unused and conflicting Launch Darkly env vars

* Added Packer Validation as a requirement for Weekly AMI builds

* Fixed capitalization of workflow names

* Added Packer Validation tests to Weekly AMI workflow

* Updating capitlization again

Author: cthulhuplus

.circleci/config.yml

@@ -67,10 +67,16 @@ workflows:
               only:
                 - main
     jobs:
+      - packer validation tests:
+          name: Packer Validation Tests
       - build preview ami:
           name: Build Preview AMI
+          requires:
+            - Packer Validation Tests
       - build production staging ami:
           name: Build Prod Staging AMI
+          requires:
+            - Packer Validation Tests
       - cleanup preview ami:
           name: Cleanup Old Unused Preview AMIs
           requires:

packer/preview-ami.pkr.hcl

@@ -57,9 +57,7 @@ build {
             "OKTA_API_KEY=${var.preview_okta_api_key}",
             "ENVIRONMENT=${var.environment}",
             "PREVIEW_TEALIUM_TAG=${var.preview_tealium_tag}",
-            "PREVIEW_TEALIUM_ENV=${var.preview_tealium_env}",
-            "PREVIEW_LD_API_KEY=${var.preview_ld_api_key}",
-            "PREVIEW_LD_CLIENT_ID=${var.preview_ld_client_id}"
+            "PREVIEW_TEALIUM_ENV=${var.preview_tealium_env}"
         ]        
         script = "./preview20220608.sh"
     }