Merge pull request #4697 from barnabasdomozi/fix_clang_diagnostic_checker

Fix clang-tidy 'clang-diagnostic-*' checkers

Author: dkrupp

analyzer/codechecker_analyzer/analyzers/clangtidy/analyzer.py

@@ -418,18 +418,20 @@ def get_checker_list(self, config) -> Tuple[List[str], List[str]]:
         has_checker_config = \
             config.checker_config and config.checker_config != '{}'
 
+        clang_diagnostic_prefix = 'clang-diagnostic-'
+
         # Config handler stores which checkers are enabled or disabled.
         for checker_name, value in config.checks().items():
             state, _ = value
 
-            if checker_name.startswith('clang-diagnostic-'):
+            if checker_name.startswith(clang_diagnostic_prefix):
                 # If a clang-diagnostic-... is enabled add it as a compiler
                 # warning as -W..., if it is disabled, tidy can suppress when
                 # specified in the -checks parameter list, so we add it there
                 # as -clang-diagnostic-... .
 
                 # TODO: str.removeprefix() available in Python 3.9
-                warning_name = checker_name[len('clang-diagnostic-'):]
+                warning_name = checker_name[len(clang_diagnostic_prefix):]
 
                 if state == CheckerState.ENABLED:
                     if checker_name == 'clang-diagnostic-error':
@@ -444,10 +446,18 @@ def get_checker_list(self, config) -> Tuple[List[str], List[str]]:
             if state == CheckerState.ENABLED:
                 enabled_checkers.append(checker_name)
 
-        # By default all checkers are disabled and the enabled ones are added
-        # explicitly.
+        # By default all checkers are disabled and the enabled ones
+        # are added explicitly.
         checkers = ['-*']
 
+        # If only clang-diagnostic-* checkers are enabled,
+        # we need to add a dummy checker otherwise clang-tidy
+        # will fail with the following error: "no checks enabled"
+        if all(c.startswith(clang_diagnostic_prefix) for c
+                in enabled_checkers):
+            dummy_checker_name = "darwin-dispatch-once-nonstatic"
+            checkers.append(dummy_checker_name)
+
         checkers += _add_asterisk_for_group(
             enabled_checkers,
             set(x[0] for x in ClangTidy.get_analyzer_checkers()))

analyzer/tests/functional/analyze_and_parse/test_files/Makefile

@@ -54,4 +54,6 @@ cppcheck_undef_include:
 gcc_simple:
 	$(CXX) -w gcc_simple.cpp -o /dev/null -c
 infer_simple:
-	$(CXX) -w infer_simple.cpp -o /dev/null -c
+	$(CXX) -w infer_simple.cpp -o /dev/null -c
+all_checkers_off_except_return_stack_address:
+	$(CC) -w all_checkers_off_except_return_stack_address.c -o /dev/null

analyzer/tests/functional/analyze_and_parse/test_files/all_checkers_off_except_return_stack_address.c

@@ -0,0 +1,12 @@
+int* f() {
+  // We only enabled clang-diagnostic-return-stack-address checker,
+  // so there should be no finding for division by zero.
+  int a = 5/0;
+
+  // The line below should raise clang-diagnostic-return-stack-address error
+  return &a;
+}
+
+int main (void) {
+  return *f();
+}

analyzer/tests/functional/analyze_and_parse/test_files/all_checkers_off_except_return_stack_address.output

@@ -0,0 +1,57 @@
+NORMAL#CodeChecker log --output $LOGFILE$ --build "make all_checkers_off_except_return_stack_address" --quiet
+NORMAL#CodeChecker analyze $LOGFILE$ --analyzers clang-tidy -d default -e clang-diagnostic-return-stack-address --output $OUTPUT$
+NORMAL#CodeChecker parse $OUTPUT$
+CHECK#CodeChecker check --build "make all_checkers_off_except_return_stack_address" --output $OUTPUT$ --quiet --analyzers clang-tidy -d default -e clang-diagnostic-return-stack-address
+--------------------------------------------------------------------------------
+[] - Starting build...
+[] - Using CodeChecker ld-logger.
+[] - Build finished successfully.
+[] - Starting static analysis ...
+[] - [1/1] clang-tidy analyzed all_checkers_off_except_return_stack_address.c successfully.
+[] - ----==== Summary ====----
+[] - Successfully analyzed
+[] -   clang-tidy: 1
+[] - Total analyzed compilation commands: 1
+[] - ----=================----
+[] - Analysis finished.
+[] - To view results in the terminal use the "CodeChecker parse" command.
+[] - To store results use the "CodeChecker store" command.
+[] - See --help and the user guide for further options about parsing and storing the reports.
+[] - ----=================----
+[MEDIUM] all_checkers_off_except_return_stack_address.c:7:11: address of stack memory associated with local variable 'a' returned [clang-diagnostic-return-stack-address]
+  return &a;
+          ^
+
+Found 1 defect(s) in all_checkers_off_except_return_stack_address.c
+
+
+----==== Severity Statistics ====----
+----------------------------
+Severity | Number of reports
+----------------------------
+MEDIUM   |                 1
+----------------------------
+----=================----
+
+----==== Checker Statistics ====----
+--------------------------------------------------------------------
+Checker name                          | Severity | Number of reports
+--------------------------------------------------------------------
+clang-diagnostic-return-stack-address | MEDIUM   |                 1
+--------------------------------------------------------------------
+----=================----
+
+----==== File Statistics ====----
+------------------------------------------------------------------
+File name                                      | Number of reports
+------------------------------------------------------------------
+all_checkers_off_except_return_stack_address.c |                 1
+------------------------------------------------------------------
+----=================----
+
+----======== Summary ========----
+---------------------------------------------
+Number of processed analyzer result files | 1
+Number of analyzer reports                | 1
+---------------------------------------------
+----=================----