Gate compute span to non-loading render pass

Hoist isRecentSearchesDataLoaded above the compute span guard so
ComputeOptions only starts once all loading states have cleared,
preventing idle Onyx hydration time from inflating the span on
cold opens.

Made-with: Cursor

Author: mountiny

src/components/Search/SearchAutocompleteList.tsx

@@ -166,8 +166,9 @@ function SearchAutocompleteList({
 
     const computeSpanStarted = useRef(false);
     const spanHandoffDone = useRef(false);
+    const isRecentSearchesDataLoaded = !isLoadingOnyxValue(recentSearchesMetadata);
     // eslint-disable-next-line react-hooks/refs -- intentional: telemetry span must start during render to measure computation time
-    if (!computeSpanStarted.current && areOptionsInitialized && getSpan(CONST.TELEMETRY.SPAN_OPEN_SEARCH_ROUTER)) {
+    if (!computeSpanStarted.current && areOptionsInitialized && isRecentSearchesDataLoaded && getSpan(CONST.TELEMETRY.SPAN_OPEN_SEARCH_ROUTER)) {
         startSpan(CONST.TELEMETRY.SPAN_SEARCH_ROUTER_COMPUTE_OPTIONS, {
             name: CONST.TELEMETRY.SPAN_SEARCH_ROUTER_COMPUTE_OPTIONS,
             op: 'function',
@@ -446,7 +447,6 @@ function SearchAutocompleteList({
         }
     }, [autocompleteQueryValue, onHighlightFirstItem, normalizedReferenceText]);
 
-    const isRecentSearchesDataLoaded = !isLoadingOnyxValue(recentSearchesMetadata);
     const isLoading = !isRecentSearchesDataLoaded || !areOptionsInitialized;
 
     if (isLoading) {