[$250] Workflows - Submission frequency turns on after disabling and enabling workflows in more feature

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.33-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://test-management.browserstack.com/projects/2219752/folder/13176924/test-cases/41237575
Issue reported by: Applause - Internal Team

Action Performed:

1. Sign up to ND with a new gmail account
2. Select Manage my team's expenses in the onboarding modal, select 1-10 employees
3. Select "None of the above" in the accounting software modal
4. Go to Workspace settings of the automatically created workspace
5. Verify Workflows is enabled
6. Go to More features and disable the workflow and enable it again
7. Go to Workflows once more
8. Verify the sub-features were disabled

Expected Result:

The sub-features in Workflows are disabled

Actual Result:

Submission frequency turns on and set ti Instantly after disabling and enabling workflows in more features

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6978175_1760728426798.Submittion_f_enabled.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021980920504782174554
• Upwork Job ID: 1980920504782174554
• Last Price Increase: 2026-02-18

[melvin-bot]

Triggered auto assignment to @heyjennahay (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[paulnjs]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Submission frequency is turned off and turned on after enabling workflows in more features

What is the root cause of that problem?

BE always sets the autoReporting totrue when we EnablePolicyWorkflows, but we don't set autoReporting to true optimistically.

What changes do you think we should make in order to solve the problem?

Set autoReporting: true in

App/src/libs/actions/Policy/Policy.ts

Line 4216 in 7165a14

: {}),

, the corresponding pendingFields to update, revert the data in failureData, cleanup pendingFields in successData.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Test enablePolicyWorkflows funcion

What alternative solutions did you explore? (Optional)

• Besides updating autoReporting as I suggested in the above solution, we can update policy.approvalMode and policy.reimbursementChoice when EnablePolicyWorkflows as well. It requires BE changes because now, BE always set approvalMode to OPTIONAL and reimbursementChoice to reimburseNo when EnablePolicyWorkflows. Based on what BE changes, we can apply the optimistic data accordingly.

[lorretheboy]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Submission frequency turns on and set ti Instantly after disabling and enabling workflows in more features

What is the root cause of that problem?

When workflows were disabled, the enablePolicyWorkflows function correctly reset all workflow sub-features to their disabled state:

autoReporting: false
autoReportingFrequency: INSTANT
harvesting.enabled: false

However, when workflows were re-enabled, the function didn't set any optimistic data for these sub-features. This caused the backend to return autoReporting: true with autoReportingFrequency: INSTANT, creating an inconsistent state where the submission frequency toggle appeared ON (because autoReporting: true) even though the frequency was set to "instant" (which should mean it's disabled).

What changes do you think we should make in order to solve the problem?

1. We need to update BE to return correct data

2. We should update optimistic value to when enabling or disabling workflows, reset all workflow sub-features to their default disabled state. This ensures that when users re-enable workflows after disabling them, all sub-features start disabled

                    areWorkflowsEnabled: enabled,
                    approvalMode: CONST.POLICY.APPROVAL_MODE.OPTIONAL,
                    autoReporting: false,
                    autoReportingFrequency: CONST.POLICY.AUTO_REPORTING_FREQUENCIES.INSTANT,
                    harvesting: {
                        enabled: false,
                    },
                    ...(!enabled
                        ? {
                              reimbursementChoice: CONST.POLICY.REIMBURSEMENT_CHOICES.REIMBURSEMENT_NO,
                          }
                        : {}),
                    pendingFields: {
                        areWorkflowsEnabled: CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE,
                        approvalMode: CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE,
                        autoReporting: CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE,
                        autoReportingFrequency: CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE,
                        harvesting: CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE,
                        ...(!enabled
                            ? {
                                  reimbursementChoice: CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE,
                              }
                            : {}),
                    },
                },

App/src/libs/actions/Policy/Policy.ts

Lines 4200 to 4226 in 8afd8a6

	value: {
	areWorkflowsEnabled: enabled,
	...(!enabled
	? {
	approvalMode: CONST.POLICY.APPROVAL_MODE.OPTIONAL,
	autoReporting: false,
	autoReportingFrequency: CONST.POLICY.AUTO_REPORTING_FREQUENCIES.INSTANT,
	harvesting: {
	enabled: false,
	},
	reimbursementChoice: CONST.POLICY.REIMBURSEMENT_CHOICES.REIMBURSEMENT_NO,
	}
	: {}),
	pendingFields: {
	areWorkflowsEnabled: CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE,
	...(!enabled
	? {
	approvalMode: CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE,
	autoReporting: CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE,
	autoReportingFrequency: CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE,
	harvesting: CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE,
	reimbursementChoice: CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE,
	}
	: {}),
	},
	},
	},

Reset values in success data

                    pendingFields: {
                        areWorkflowsEnabled: null,
                        approvalMode: null,
                        autoReporting: null,
                        autoReportingFrequency: null,
                        harvesting: null,
                        ...(!enabled
                            ? {
                                  reimbursementChoice: null,
                              }
                            : {}),
                    },

App/src/libs/actions/Policy/Policy.ts

Lines 4232 to 4245 in 8afd8a6

	value: {
	pendingFields: {
	areWorkflowsEnabled: null,
	...(!enabled
	? {
	approvalMode: null,
	autoReporting: null,
	autoReportingFrequency: null,
	harvesting: null,
	reimbursementChoice: null,
	}
	: {}),
	},
	},

Failure data

                    areWorkflowsEnabled: !enabled,
                    approvalMode: policy?.approvalMode,
                    autoReporting: policy?.autoReporting,
                    autoReportingFrequency: policy?.autoReportingFrequency,
                    harvesting: policy?.harvesting,
                    ...(!enabled
                        ? {
                              reimbursementChoice: policy?.reimbursementChoice,
                          }
                        : {}),
                    pendingFields: {
                        areWorkflowsEnabled: null,
                        approvalMode: null,
                        autoReporting: null,
                        autoReportingFrequency: null,
                        harvesting: null,
                        ...(!enabled
                            ? {
                                  reimbursementChoice: null,
                              }
                            : {}),
                    },

App/src/libs/actions/Policy/Policy.ts

Lines 4252 to 4275 in 8afd8a6

	value: {
	areWorkflowsEnabled: !enabled,
	...(!enabled
	? {
	approvalMode: policy?.approvalMode,
	autoReporting: policy?.autoReporting,
	autoReportingFrequency: policy?.autoReportingFrequency,
	harvesting: policy?.harvesting,
	reimbursementChoice: policy?.reimbursementChoice,
	}
	: {}),
	pendingFields: {
	areWorkflowsEnabled: null,
	...(!enabled
	? {
	approvalMode: null,
	autoReporting: null,
	autoReportingFrequency: null,
	harvesting: null,
	reimbursementChoice: null,
	}
	: {}),
	},
	},

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021980920504782174554

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)