Skip to content

dmac check is inappropriate #3650

@yulintao

Description

@yulintao

`

	 if (ei && (ei->flags & ETHERNET_INTERFACE_FLAG_STATUS_L3))

	 goto skip_dmac_check01;

	  dmacs[0] = *(u64 *) e0;
	  dmacs[1] = *(u64 *) e1;

	  if (ei && vec_len (ei->secondary_addrs))
	    ethernet_input_inline_dmac_check (hi, dmacs,
					      dmacs_bad,
					      2 /* n_packets */ ,
					      ei,
					      1 /* have_sec_dmac */ );
	 ...

`

above this code from ethernet_input_inline if (ei && (ei->flags & ETHERNET_INTERFACE_FLAG_STATUS_L3)) meaning if ei->flags is in l3 mode then skip_dmac_check;

That is wrong, that should be if ei->flags is in promisc mode ,skip dmac check!

So, I think the correct way like this if (ei && (ei->flags & ETHERNET_INTERFACE_FLAG_ACCEPT_ALL));

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions