Skip to content

Consider using a larger digital storage dpdk interface for statistics #3717

@echoechoin

Description

@echoechoin

Currently, DPDK stats are stored using 16-digit numbers.
For a 10G network card with full speed, the value of rx_good_bytes will exceed the 16-digit limit in just 10 days:

9999999999999999 / (1024 * 1024 * 1024 * 10) / (24 * 60 * 60) ≈ 10.7791964655

Causing the statistics to be undercounted by a factor of 10.

src/plugins/dpdk/device/format.c:

xs = format(xs, "\n%U%-38s%16Lu",
    format_white_space, indent + 4,
    xstat_names[i].name,
    xstat->value);

Which modification is better: changing the code of the format function or increasing the value 16?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions