fix(#4218): avoid duplicate injection on fields (#5224)

Author: giulong

release-notes/CREDITS-2.x

@@ -1869,6 +1869,9 @@ wrongwrong (@k163377)
  * Contributed fix for #5202: #5202: `JsonSetter.contentNulls` ignored for `Object[]`,
   `String[]` and `Collection<String>`
   (2.19.2)
+ * Reported #4218: If `@JacksonInject` is specified for field and deserialized by
+   the Creator, the inject process will be executed twice
+  (2.20.0)
 
 Bernd Ahlers (@bernd)
  * Reported #4742: Deserialization with Builder, External type id, `@JsonCreator` failing
@@ -1952,6 +1955,17 @@ Eddú Meléndez Gonzales (@eddumelendez)
   (2.19.2)
 
 Giulio Longfils (@giulong)
+ * Contributed #2678: `@JacksonInject` added to property overrides value from the JSON
+   even if `useInput` is `OptBoolean.TRUE`
+  (2.20.0)
  * Contributed #3072: Allow specifying `@JacksonInject` does not fail when there's no
    corresponding value
   (2.20.0)
+ * Contributed #4218: If `@JacksonInject` is specified for field and deserialized by
+   the Creator, the inject process will be executed twice
+  (2.20.0)
+
+Plamen Tanov (@ptanov)
+ * Reported #2678: `@JacksonInject` added to property overrides value from the JSON
+   even if `useInput` is `OptBoolean.TRUE`
+  (2.20.0)

release-notes/VERSION-2.x

@@ -6,8 +6,16 @@ Project: jackson-databind
 
 Not yet released
 
+#2678: `@JacksonInject` added to property overrides value from the JSON
+  even if `useInput` is `OptBoolean.TRUE`
+ (reported by Plamen T)
+ (fix by Giulio L)
 #2692: Should never call `set()` on setterless property during deserialization
  (reported by @lbonco)
+#4218: If `@JacksonInject` is specified for field and deserialized by the Creator,
+  the inject process will be executed twice
+ (reported by  @wrongwrong)
+ (fix by Giulio L)
 #5237: Failing `@JsonMerge` with a custom Map with a `@JsonCreator` constructor
  (reported by @nlisker)
 #5238: Immutable classes with `@JsonIdentityInfo` can be deserialized; records cannot

src/main/java/com/fasterxml/jackson/databind/introspect/POJOPropertiesCollector.java

@@ -1282,6 +1282,20 @@ protected void _addInjectables(Map<String, POJOPropertyBuilder> props)
             }
             _doAddInjectable(_annotationIntrospector.findInjectableValue(m), m);
         }
+
+        // 21-Aug-2025, tatu: [databind#4218] avoid duplicate injectables
+        if (_injectables != null) {
+            for (POJOPropertyBuilder creatorProperty : _creatorProperties) {
+                if (creatorProperty == null) {
+                    continue;
+                }
+                final AnnotatedParameter parameter = creatorProperty.getConstructorParameter();
+                JacksonInject.Value injectable = _annotationIntrospector.findInjectableValue(parameter);
+                if (injectable != null) {
+                    _injectables.remove(injectable.getId());
+                }
+            }
+        }
     }
 
     protected void _doAddInjectable(JacksonInject.Value injectable, AnnotatedMember m)

src/test-jdk17/java/com/fasterxml/jackson/databind/records/RecordBasicsTest.java

@@ -179,29 +179,16 @@ public void testDeserializeJsonRename() throws Exception {
         assertEquals(new RecordWithRename(123, "Bob"), value);
     }
 
-    /**
-     * This test-case is just for documentation purpose:
-     * GOTCHA: Annotations on header will be propagated to the field, leading to this failure.
-     *
-     * @see #testDeserializeConstructorInjectRecord()
-     */
+    // Confirmation of fix of [databind#4218]
     @Test
-    public void testDeserializeHeaderInjectRecord_WillFail() throws Exception {
+    public void testDeserializeHeaderInjectRecord4218() throws Exception {
         ObjectReader reader = MAPPER.readerFor(RecordWithHeaderInject.class)
                 .with(new InjectableValues.Std().addValue(String.class, "Bob"));
-
-        try {
-            reader.readValue("{\"id\":123}");
-
-            fail("should not pass");
-        } catch (IllegalArgumentException e) {
-            verifyException(e, "RecordWithHeaderInject#name");
-            verifyException(e, "Can not set final java.lang.String field");
-        }
+        assertNotNull(reader.readValue("{\"id\":123}"));
     }
 
     @Test
-    public void testDeserializeConstructorInjectRecord() throws Exception {
+    public void testDeserializeConstructorInjectRecord4218() throws Exception {
         ObjectReader reader = MAPPER.readerFor(RecordWithConstructorInject.class)
                 .with(new InjectableValues.Std().addValue(String.class, "Bob"));
         RecordWithConstructorInject value = reader.readValue("{\"id\":123}");

src/test/java/com/fasterxml/jackson/databind/tofix/JacksonInject2678Test.java renamed to src/test/java/com/fasterxml/jackson/databind/deser/inject/JacksonInject2678Test.java

@@ -1,4 +1,4 @@
-package com.fasterxml.jackson.databind.tofix;
+package com.fasterxml.jackson.databind.deser.inject;
 
 import java.util.Objects;
 
@@ -10,7 +10,6 @@
 import com.fasterxml.jackson.databind.ObjectMapper;
 import com.fasterxml.jackson.databind.json.JsonMapper;
 import com.fasterxml.jackson.databind.testutil.DatabindTestUtil;
-import com.fasterxml.jackson.databind.testutil.failure.JacksonTestFailureExpected;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
 
@@ -41,7 +40,6 @@ public String getField2() {
     }
 
     // [databind#2678]
-    @JacksonTestFailureExpected
     @Test
     void readValueInjectables() throws Exception {
         final InjectableValues injectableValues =

src/test/java/com/fasterxml/jackson/databind/tofix/JacksonInject4218Test.java renamed to src/test/java/com/fasterxml/jackson/databind/deser/inject/JacksonInject4218Test.java

@@ -1,4 +1,4 @@
-package com.fasterxml.jackson.databind.tofix;
+package com.fasterxml.jackson.databind.deser.inject;
 
 import org.junit.jupiter.api.Test;
 
@@ -8,7 +8,6 @@
 
 import com.fasterxml.jackson.databind.*;
 import com.fasterxml.jackson.databind.testutil.DatabindTestUtil;
-import com.fasterxml.jackson.databind.testutil.failure.JacksonTestFailureExpected;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
 
@@ -51,9 +50,8 @@ public Object findInjectableValue(
     }
 
     // [databind#4218]
-    @JacksonTestFailureExpected
     @Test
-    void injectFail4218() throws Exception
+    void injectNoDups4218() throws Exception
     {
         ObjectReader reader = newJsonMapper()
                 .readerFor(Dto.class)