Skip to content
This repository was archived by the owner on Nov 7, 2019. It is now read-only.

Commit fcf91b3

Browse files
committed
Fix problem with Optional, @JsonSerialize(contentUsing=) (#31)
1 parent 672928c commit fcf91b3

File tree

2 files changed

+36
-6
lines changed

2 files changed

+36
-6
lines changed

release-notes/VERSION

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,12 @@ Project: jackson-datatype-jdk8
44
=== Releases ===
55
------------------------------------------------------------------------
66

7+
2.6.6 (not yet released)
8+
9+
#31: Support `@JsonSerialize(contentUsing=)` and `@JsonDeserialize(contentUsing=)`
10+
for `Optional`
11+
(reported by selenareneephillips)
12+
713
2.6.5 (19-Jan-2016)
814

915
No changes since 2.6.4.

src/main/java/com/fasterxml/jackson/datatype/jdk8/OptionalSerializer.java

Lines changed: 30 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
import com.fasterxml.jackson.databind.*;
88
import com.fasterxml.jackson.databind.annotation.JsonSerialize;
99
import com.fasterxml.jackson.databind.introspect.Annotated;
10+
import com.fasterxml.jackson.databind.introspect.AnnotatedMember;
1011
import com.fasterxml.jackson.databind.jsonFormatVisitors.JsonFormatVisitorWrapper;
1112
import com.fasterxml.jackson.databind.jsontype.TypeSerializer;
1213
import com.fasterxml.jackson.databind.ser.ContextualSerializer;
@@ -83,14 +84,17 @@ protected OptionalSerializer withResolved(BeanProperty prop,
8384
public JsonSerializer<?> createContextual(SerializerProvider provider,
8485
BeanProperty property) throws JsonMappingException
8586
{
86-
JsonSerializer<?> ser = _valueSerializer;
87+
JsonSerializer<?> ser = findContentSerializer(provider, property);
8788
if (ser == null) {
88-
// A few conditions needed to be able to fetch serializer here:
89-
if (_useStatic(provider, property, _referredType)) {
90-
ser = _findSerializer(provider, _referredType, property);
89+
ser = _valueSerializer;
90+
if (ser == null) {
91+
// A few conditions needed to be able to fetch serializer here:
92+
if (_useStatic(provider, property, _referredType)) {
93+
ser = _findSerializer(provider, _referredType, property);
94+
}
95+
} else {
96+
ser = provider.handlePrimaryContextualization(ser, property);
9197
}
92-
} else {
93-
ser = provider.handlePrimaryContextualization(ser, property);
9498
}
9599
return withResolved(property, ser, _unwrapper);
96100
}
@@ -262,4 +266,24 @@ private final JsonSerializer<Object> _findSerializer(SerializerProvider provider
262266
{
263267
return provider.findTypedValueSerializer(type, true, prop);
264268
}
269+
270+
// !!! 22-Mar-2016, tatu: Method added in jackson-databind 2.7.4; may be used
271+
// when we go 2.8
272+
protected JsonSerializer<?> findContentSerializer(SerializerProvider serializers,
273+
BeanProperty property)
274+
throws JsonMappingException
275+
{
276+
if (property != null) {
277+
// First: if we have a property, may have property-annotation overrides
278+
AnnotatedMember m = property.getMember();
279+
final AnnotationIntrospector intr = serializers.getAnnotationIntrospector();
280+
if (m != null) {
281+
Object serDef = intr.findContentSerializer(m);
282+
if (serDef != null) {
283+
return serializers.serializerInstance(m, serDef);
284+
}
285+
}
286+
}
287+
return null;
288+
}
265289
}

0 commit comments

Comments
 (0)