Skip to content

Commit 5019c16

Browse files
committed
Minor fix to incompatiblity due to fragile base interface problem (wrt TypeIdResolver)
1 parent b040836 commit 5019c16

File tree

2 files changed

+20
-32
lines changed

2 files changed

+20
-32
lines changed

pom.xml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,12 @@
33
<parent>
44
<groupId>com.fasterxml.jackson</groupId>
55
<artifactId>jackson-parent</artifactId>
6-
<version>2.4</version>
6+
<version>2.5-rc1</version>
77
</parent>
88
<groupId>com.fasterxml.jackson.module</groupId>
99
<artifactId>jackson-module-jsonSchema</artifactId>
1010
<name>jackson-module-jsonSchema</name>
11-
<version>2.4.5-SNAPSHOT</version>
11+
<version>2.5.0-SNAPSHOT</version>
1212
<packaging>bundle</packaging>
1313
<description>Add-on module for Jackson (http://jackson.codehaus.org) to support
1414
JSON Schema (http://tools.ietf.org/html/draft-zyp-json-schema-03) version 3 generation.
@@ -33,8 +33,8 @@ JSON Schema (http://tools.ietf.org/html/draft-zyp-json-schema-03) version 3 gene
3333
</developer>
3434
</developers>
3535
<properties>
36-
<version.jackson.annotations>2.4.0</version.jackson.annotations>
37-
<version.jackson.core>2.4.4</version.jackson.core>
36+
<version.jackson.annotations>2.5.0-SNAPSHOT</version.jackson.annotations>
37+
<version.jackson.core>2.5.0-SNAPSHOT</version.jackson.core>
3838

3939
<osgi.export>${project.groupId}.jsonSchema.*</osgi.export>
4040
</properties>
@@ -62,7 +62,7 @@ JSON Schema (http://tools.ietf.org/html/draft-zyp-json-schema-03) version 3 gene
6262
<plugin>
6363
<groupId>org.apache.maven.plugins</groupId>
6464
<artifactId>maven-surefire-plugin</artifactId>
65-
<version>${surefire.version}</version>
65+
<version>${version.plugin.surefire}</version>
6666
<configuration>
6767
<excludes>
6868
<exclude>com/fasterxml/jackson/module/jsonSchema/failing/*.java</exclude>

src/main/java/com/fasterxml/jackson/module/jsonSchema/JsonSchemaIdResolver.java

Lines changed: 15 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,15 @@
11
package com.fasterxml.jackson.module.jsonSchema;
22

33
import com.fasterxml.jackson.annotation.JsonTypeInfo.Id;
4+
import com.fasterxml.jackson.databind.DatabindContext;
45
import com.fasterxml.jackson.databind.JavaType;
56
import com.fasterxml.jackson.databind.jsonFormatVisitors.JsonFormatTypes;
6-
import com.fasterxml.jackson.databind.jsontype.TypeIdResolver;
7+
import com.fasterxml.jackson.databind.jsontype.impl.TypeIdResolverBase;
78
import com.fasterxml.jackson.databind.type.TypeFactory;
8-
import com.fasterxml.jackson.module.jsonSchema.types.AnySchema;
9-
import com.fasterxml.jackson.module.jsonSchema.types.ArraySchema;
10-
import com.fasterxml.jackson.module.jsonSchema.types.BooleanSchema;
11-
import com.fasterxml.jackson.module.jsonSchema.types.IntegerSchema;
12-
import com.fasterxml.jackson.module.jsonSchema.types.NullSchema;
13-
import com.fasterxml.jackson.module.jsonSchema.types.NumberSchema;
14-
import com.fasterxml.jackson.module.jsonSchema.types.ObjectSchema;
15-
import com.fasterxml.jackson.module.jsonSchema.types.StringSchema;
9+
import com.fasterxml.jackson.module.jsonSchema.types.*;
1610

17-
public class JsonSchemaIdResolver implements TypeIdResolver
18-
{
11+
public class JsonSchemaIdResolver extends TypeIdResolverBase
12+
{
1913
/* This is Wrong: should not use defaultInstance() for anything.
2014
* But has to work for now...
2115
*/
@@ -30,9 +24,6 @@ public class JsonSchemaIdResolver implements TypeIdResolver
3024

3125
public JsonSchemaIdResolver() { }
3226

33-
/* (non-Javadoc)
34-
* @see com.fasterxml.jackson.databind.jsontype.TypeIdResolver#idFromValue(java.lang.Object)
35-
*/
3627
@Override
3728
public String idFromValue(Object value) {
3829
if ( value instanceof JsonSchema) {
@@ -41,27 +32,24 @@ public String idFromValue(Object value) {
4132
return null;
4233
}
4334

44-
/* (non-Javadoc)
45-
* @see com.fasterxml.jackson.databind.jsontype.TypeIdResolver#idFromValueAndType(java.lang.Object, java.lang.Class)
46-
*/
4735
@Override
4836
public String idFromValueAndType(Object value, Class<?> suggestedType) {
4937
return idFromValue(value);
5038
}
5139

5240
@Override
53-
public JavaType typeFromId(String id) {
41+
public JavaType typeFromId(DatabindContext context, String id) {
5442
switch (JsonFormatTypes.forValue(id)) {
55-
case ANY: return any;
56-
case ARRAY: return array;
57-
case BOOLEAN: return booleanboolean;
58-
case INTEGER: return integer;
59-
case NULL: return nullnull;
60-
case NUMBER: return number;
61-
case OBJECT: return object;
62-
case STRING: return string;
43+
case ANY: return any;
44+
case ARRAY: return array;
45+
case BOOLEAN: return booleanboolean;
46+
case INTEGER: return integer;
47+
case NULL: return nullnull;
48+
case NUMBER: return number;
49+
case OBJECT: return object;
50+
case STRING: return string;
6351
default:
64-
return null;
52+
return null;
6553
}
6654
}
6755

0 commit comments

Comments
 (0)