Skip to content

Commit a201e80

Browse files
committed
Update Link node to <a> transformation, stop parsing the given url
The provided URL in the Link node shouldn't be parsed but just set as href atttribute value for the corresponding <a> tag.
1 parent 1a727fe commit a201e80

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

libraries/to-external-bodyxml/go/transform.go

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -102,12 +102,11 @@ func transformNode(n contenttree.Node) (string, error) {
102102
return fmt.Sprintf("<s>%s</s>", innerXML), nil
103103

104104
case *contenttree.Link:
105-
parts := strings.Split(node.URL, "/")
106105
if node.Title != "" {
107-
return fmt.Sprintf("<a href=\"https://ft.com/content/%s\" title=\"%s\">%s</a>", parts[len(parts)-1], node.Title, innerXML), nil
106+
return fmt.Sprintf("<a href=\"%s\" title=\"%s\">%s</a>", node.URL, node.Title, innerXML), nil
108107
}
109108

110-
return fmt.Sprintf("<a href=\"https://ft.com/content/%s\">%s</a>", parts[len(parts)-1], innerXML), nil
109+
return fmt.Sprintf("<a href=\"%s\">%s</a>", node.URL, innerXML), nil
111110

112111
case *contenttree.List:
113112
tag := "ul"
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
<body><ft-content type="http://www.ft.com/ontology/content/ImageSet" url="http://api.ft.com/content/aae9611e-f66c-4fe4-a6c6-2e2bdea69060" data-embedded="true"></ft-content>
22
<p>Lorem ipsum dolor sit amet, consectetur adipiscing elit. Mauris scelerisque, nunc vel consectetur sagittis, purus ex ultrices metus, in consectetur nisl lacus congue nulla. Integer fermentum molestie dui at accumsan.</p>
3-
<p>Nam <a href="https://ft.com/content/396d9102-9845-4ce2-8783-49b73f8f1302">scelerisque luctus</a> tristique. Aliquam orci massa, hendrerit non pulvinar a, tristique vitae enim. Pellentesque laoreet condimentum nulla sed tempor. Orci varius natoque penatibus et magnis dis parturient montes, nascetur ridiculus mus. Quisque euismod euismod porta. Praesent id sapien et magna porta malesuada. Proin sit amet justo vel augue sollicitudin volutpat sodales id turpis.</p>
3+
<p>Nam <a href="https://www.ft.com/content/396d9102-9845-4ce2-8783-49b73f8f1302">scelerisque luctus</a> tristique. Aliquam orci massa, hendrerit non pulvinar a, tristique vitae enim. Pellentesque laoreet condimentum nulla sed tempor. Orci varius natoque penatibus et magnis dis parturient montes, nascetur ridiculus mus. Quisque euismod euismod porta. Praesent id sapien et magna porta malesuada. Proin sit amet justo vel augue sollicitudin volutpat sodales id turpis.</p>
44
<p>Sed posuere vestibulum metus non cursus. Fusce ac blandit erat. Fusce turpis turpis, vehicula et condimentum quis, dapibus eget odio. Vivamus lobortis vulputate sapien quis ultrices. </p>
55
<p>Morbi laoreet, sem at bibendum rutrum, ligula erat rhoncus est, eget hendrerit leo diam sit amet mauris. Curabitur cursus dictum mi id eleifend. Pellentesque sed massa sit amet massa ornare accumsan. Nulla eget lobortis velit. </p>
66
<p>Cras vel libero ut arcu hendrerit accumsan. “Vivamus ligula lectus”, vestibulum at nisi id, imperdiet “ornare libero”.</p>
77
<pull-quote><pull-quote-text><p>Maecenas ac ipsum in elit aliquam consectetur. Proin felis metus, efficitur et nulla eu, interdum malesuada diam.</p></pull-quote-text><pull-quote-source>Pellentesque habitant, morbi tristique</pull-quote-source></pull-quote>
8-
<p>Donec id faucibus erat. Suspendisse tempor laoreet lorem, sit amet vehicula massa facilisis at. Nulla quis feugiat massa. Praesent viverra non lectus ut ullamcorper. Phasellus <a href="https://ft.com/content/c71efed9-fe5a-488d-9f47-20c15d177153">porttitor neque</a> at volutpat pulvinar.</p>
8+
<p>Donec id faucibus erat. Suspendisse tempor laoreet lorem, sit amet vehicula massa facilisis at. Nulla quis feugiat massa. Praesent viverra non lectus ut ullamcorper. Phasellus <a href="https://www.ft.com/content/c71efed9-fe5a-488d-9f47-20c15d177153">porttitor neque</a> at volutpat pulvinar.</p>
99
<p>“Curabitur fermentum, dolor vel interdum varius, tellus justo dapibus velit, interdum sollicitudin dolor nibh varius velit.”</p>
1010
</body>

0 commit comments

Comments
 (0)