Skip to content

Commit 46f9657

Browse files
author
Mark Kasaboski
committed
Fixes activity key error
1 parent c7298c7 commit 46f9657

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

packages/flare/bin/cron_job_ingest_events.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -122,10 +122,10 @@ def main(
122122
flare_api_cls=flare_api_cls,
123123
):
124124
save_last_fetched(kvstore=kvstore)
125-
126125
save_next(kvstore=kvstore, tenant_id=tenant_id, next=next_token)
127126

128-
print(json.dumps(event), flush=True)
127+
if event:
128+
print(json.dumps(event), flush=True)
129129

130130
events_fetched_count += 1
131131

packages/flare/bin/flare.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -116,9 +116,12 @@ def _fetch_event_feed_metadata(
116116

117117
def _fetch_full_event_from_uid(self, *, uid: str) -> dict:
118118
event_response = self.flare_client.get(url=f"/firework/v2/activities/{uid}")
119-
event = event_response.json()["activity"]
119+
event = event_response.json()
120120
self.logger.debug(event)
121-
return event
121+
if not event or "activity" not in event:
122+
self.logger.info(f"Failed to fetch event with uid: {uid}")
123+
return {}
124+
return event["activity"]
122125

123126
def fetch_api_key_validation(self) -> requests.Response:
124127
return self.flare_client.get(

0 commit comments

Comments
 (0)