Commit 4ee56ab
Notify on image-property changes in ResultViewModel
The Image, BadgeImage, and PreviewImage setters never raised
PropertyChanged, even though the LoadImageAsync comments asserted that
"modifying the property" was supposed to trigger the event. The notify
call was lost in 2021 when the LazyAsync<ImageSource> wrapper was
inlined (e8691c2).
The bug usually hides because subsequent identical IcoPath lookups hit
ImageCache synchronously in the getter, so the binding sees the loaded
image on its first evaluation. But when a brand-new IcoPath comes in
and the host doesn't virtualize the row out and back in (e.g., a
single-result query like a chat plugin's "Ask" preview), the field is
mutated post-await and the binding stays on LoadingImage forever.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>1 parent 17184c4 commit 4ee56ab
1 file changed
Lines changed: 15 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
175 | 175 | | |
176 | 176 | | |
177 | 177 | | |
178 | | - | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
179 | 183 | | |
180 | 184 | | |
181 | 185 | | |
| |||
190 | 194 | | |
191 | 195 | | |
192 | 196 | | |
193 | | - | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
194 | 202 | | |
195 | 203 | | |
196 | 204 | | |
| |||
205 | 213 | | |
206 | 214 | | |
207 | 215 | | |
208 | | - | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
209 | 221 | | |
210 | 222 | | |
211 | 223 | | |
| |||
0 commit comments