Fix types for the UserManipulator factory methods in tests

Author: stof

Tests/Command/ActivateUserCommandTest.php

@@ -75,12 +75,7 @@ private function createCommandTester(UserManipulator $manipulator, Application $
         return new CommandTester($application->find('fos:user:activate'));
     }
 
-    /**
-     * @param $username
-     *
-     * @return mixed
-     */
-    private function getManipulator($username)
+    private function getManipulator(string $username): UserManipulator
     {
         $manipulator = $this->getMockBuilder('FOS\UserBundle\Util\UserManipulator')
             ->disableOriginalConstructor()

Tests/Command/CreateUserCommandTest.php

@@ -79,16 +79,7 @@ private function createCommandTester(UserManipulator $manipulator, Application $
         return new CommandTester($application->find('fos:user:create'));
     }
 
-    /**
-     * @param $username
-     * @param $password
-     * @param $email
-     * @param $active
-     * @param $superadmin
-     *
-     * @return mixed
-     */
-    private function getManipulator($username, $password, $email, $active, $superadmin)
+    private function getManipulator(string $username, string $password, string $email, bool $active, bool $superadmin): UserManipulator
     {
         $manipulator = $this->getMockBuilder('FOS\UserBundle\Util\UserManipulator')
             ->disableOriginalConstructor()

Tests/Command/DeactivateUserCommandTest.php

@@ -75,12 +75,7 @@ private function createCommandTester(UserManipulator $manipulator, Application $
         return new CommandTester($application->find('fos:user:deactivate'));
     }
 
-    /**
-     * @param $username
-     *
-     * @return mixed
-     */
-    private function getManipulator($username)
+    private function getManipulator(string $username): UserManipulator
     {
         $manipulator = $this->getMockBuilder('FOS\UserBundle\Util\UserManipulator')
             ->disableOriginalConstructor()

Tests/Command/DemoteUserCommandTest.php

@@ -76,14 +76,7 @@ private function createCommandTester(UserManipulator $manipulator, Application $
         return new CommandTester($application->find('fos:user:demote'));
     }
 
-    /**
-     * @param $username
-     * @param $role
-     * @param $super
-     *
-     * @return mixed
-     */
-    private function getManipulator($username, $role, $super)
+    private function getManipulator(string $username, string $role, bool $super): UserManipulator
     {
         $manipulator = $this->getMockBuilder('FOS\UserBundle\Util\UserManipulator')
             ->disableOriginalConstructor()

Tests/Command/PromoteUserCommandTest.php

@@ -76,14 +76,7 @@ private function createCommandTester(UserManipulator $manipulator, Application $
         return new CommandTester($application->find('fos:user:promote'));
     }
 
-    /**
-     * @param $username
-     * @param $role
-     * @param $super
-     *
-     * @return mixed
-     */
-    private function getManipulator($username, $role, $super)
+    private function getManipulator(string $username, string $role, bool $super): UserManipulator
     {
         $manipulator = $this->getMockBuilder('FOS\UserBundle\Util\UserManipulator')
             ->disableOriginalConstructor()