Skip to content

Commit 95aba09

Browse files
Lasercarmoondroidcoder
authored andcommitted
Fix target variation
Also no need to do instrumental stuff if not random
1 parent 811b9e3 commit 95aba09

File tree

1 file changed

+11
-8
lines changed

1 file changed

+11
-8
lines changed

source/funkin/ui/freeplay/FreeplayState.hx

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2461,6 +2461,10 @@ class FreeplayState extends MusicBeatSubState
24612461
letterSort.inputEnabled = false;
24622462

24632463
var targetSongCap:SongMenuItem = FlxG.random.getObject(availableSongCapsules);
2464+
// Seeing if I can do an animation...
2465+
curSelected = grpCapsules.members.indexOf(targetSongCap);
2466+
changeSelection(); // Trigger an update. This will also fix the target variation.
2467+
24642468
var targetSongId:String = targetSongCap?.freeplayData?.data.id ?? 'unknown';
24652469
var targetSongNullable:Null<Song> = SongRegistry.instance.fetchEntry(targetSongId);
24662470
if (targetSongNullable == null)
@@ -2483,14 +2487,6 @@ class FreeplayState extends MusicBeatSubState
24832487
return;
24842488
}
24852489

2486-
var baseInstrumentalId:String = targetSong.getBaseInstrumentalId(targetDifficultyId, targetDifficulty?.variation ?? Constants.DEFAULT_VARIATION) ?? '';
2487-
var altInstrumentalIds:Array<String> = targetSong.listAltInstrumentalIds(targetDifficultyId,
2488-
targetDifficulty?.variation ?? Constants.DEFAULT_VARIATION) ?? [];
2489-
2490-
// Choose a random instrumental
2491-
var instrumentalIds:Array<String> = [baseInstrumentalId].concat(altInstrumentalIds);
2492-
var targetInstrumentalId:String = FlxG.random.getObject(instrumentalIds);
2493-
24942490
// Seeing if I can do an animation...
24952491
curSelected = grpCapsules.members.indexOf(targetSongCap);
24962492
changeSelection(0); // Trigger an update.
@@ -2501,6 +2497,13 @@ class FreeplayState extends MusicBeatSubState
25012497

25022498
if (instChoice == 'random')
25032499
{
2500+
var baseInstrumentalId:String = targetSong.getBaseInstrumentalId(targetDifficultyId, targetDifficulty?.variation ?? Constants.DEFAULT_VARIATION) ?? '';
2501+
var altInstrumentalIds:Array<String> = targetSong.listAltInstrumentalIds(targetDifficultyId,
2502+
targetDifficulty?.variation ?? Constants.DEFAULT_VARIATION) ?? [];
2503+
2504+
// Choose a random instrumental
2505+
var instrumentalIds:Array<String> = [baseInstrumentalId].concat(altInstrumentalIds);
2506+
var targetInstrumentalId:String = FlxG.random.getObject(instrumentalIds);
25042507
// Hit Confirm on that song with random instrumental
25052508
capsuleOnConfirmDefault(targetSongCap, targetInstrumentalId);
25062509
}

0 commit comments

Comments
 (0)