Merge pull request #348 from GameTechDev/bug/summary-perc

Summary Percentile Labels

Author: markgalvan-intel

IntelPresentMon/AppCef/Web/src/core/preferences.ts

@@ -145,10 +145,11 @@ const migrations: Migration[] = [
     {
         version: '0.18.0',
         migrate: (prefs: Preferences) => {
-            console.info('Migrating preferences to 0.18.0 (manualEtwFlush enable/rate)');
+            console.info('Migrating preferences to 0.18.0 (manualEtwFlush enable/rate, lower offset)');
             const def = makeDefaultPreferences();
             prefs.manualEtwFlush = def.manualEtwFlush;
             prefs.etwFlushPeriod = def.etwFlushPeriod;
+            prefs.metricsOffset = def.metricsOffset;
         }
     },
 ];

IntelPresentMon/Core/source/pmon/RawFrameDataWriter.cpp

@@ -361,8 +361,8 @@ namespace p2c::pmon
             "Total Frames,"
             "Average FPS,"
             "Minimum FPS,"
-            "99th Percentile FPS,"
-            "95th Percentile FPS,"
+            "1st Percentile FPS,"
+            "5th Percentile FPS,"
             "Maximum FPS,"
             "AnimationErrorPerSecond,"
             "AnimationErrorPerFrame\n";

IntelPresentMon/PresentMonService/ActionServer.cpp

@@ -80,6 +80,7 @@ namespace pmon::svc
                 // insert a session context object for this connection, will be initialized properly upon OpenSession action
                 sessionId = pPipe->GetId();
                 sessions[*sessionId].pPipe = pPipe;
+                pmlog_info(std::format("Action pipe connected id:{}", *sessionId));
                 // fork this acceptor coroutine
                 as::co_spawn(ioctx_, AcceptConnection_(), as::detached);
                 // run the action handler until client session is terminated
@@ -95,7 +96,7 @@ namespace pmon::svc
                         clientPid = i->second.clientPid;
                     }
                     actionManager_.ctx_.DisposeSession(*sessionId);
-                    pmlog_info(std::format("Action pipe disconnected id:{} pid:{}", *sessionId, clientPid));
+                    pmlog_info(std::format("Action pipe disconnected, session closed id:{} pid:{}", *sessionId, clientPid));
                     co_return;
                 }
                 pmlog_info("Sessionless pipe disconnected");

IntelPresentMon/PresentMonService/acts/OpenSession.h

@@ -36,8 +36,8 @@ namespace pmon::svc::acts
 			stx.clientPid = in.clientPid;
 			stx.clientBuildId = in.clientBuildId;
 			ctx.pSvc->SignalClientSessionOpened();
-			pmlog_dbg(std::format("Received open session action from {} BID={} vs {} (svc)",
-				in.clientPid, in.clientBuildId, BuildIdShortHash()));
+			pmlog_info(std::format("Open action for session #{} pid={}; [BID] cli={} svc={}",
+				stx.pPipe->GetId(), in.clientPid, in.clientBuildId, BuildIdShortHash()));
 			return Response{ .serviceBuildId = BuildIdShortHash() };
 		}
 	};

IntelPresentMon/PresentMonService/acts/StartTracking.h

@@ -39,7 +39,7 @@ namespace pmon::svc::acts
 			}
 			stx.trackedPids.insert(in.targetPid);
 			const Response out{ .nsmFileName = std::move(nsmFileName) };
-			pmlog_dbg(std::format("StartStreaming action from [{}] targetting [{}] assigned nsm [{}]",
+			pmlog_info(std::format("StartTracking action from [{}] targeting [{}] assigned nsm [{}]",
 				stx.clientPid, in.targetPid, out.nsmFileName));
 			return out;
 		}

IntelPresentMon/PresentMonService/acts/StopTracking.h

@@ -27,7 +27,7 @@ namespace pmon::svc::acts
 		{
 			ctx.pPmon->StopStreaming(stx.clientPid, in.targetPid);
 			stx.trackedPids.erase(in.targetPid);
-			pmlog_dbg(std::format("StopStreaming action from [{}] un-targeting [{}]", stx.clientPid, in.targetPid));
+			pmlog_info(std::format("StopTracking action from [{}] un-targeting [{}]", stx.clientPid, in.targetPid));
 			return {};
 		}
 	};