Skip to content

W-ASAP Dashboard next steps #793

@fhennig

Description

@fhennig

This is a bug fix that we need to get merged and deployed: GenSpectrum/dashboard-components#987 - because of it we get some 500 errors

I'm collecting some things in here.

  • for two-step load processes (i.e. load mutations to display first, then fetch data): improve loading screen feat(website): add Loading component with spinner to the W-ASAP dashboard #800
  • have a look at the annotation descriptions, is it fine? We still need a fetch date there.
  • fetchMutations - add proper typing (zod) for the JSON response (and better error handling possibly)
  • maybe move 'Sequence Type' selector out of the analysis mode specific settings. All modes use this filter except the resistance mutations view.
  • Improve WasapFilter type: Not all settings can be set at the same time, so it makes sense to create a union type instead.

Testing

  • Add unit test for WasapPageStateHandler
  • Add unit test for page state selector: "It could be difficult, but if you would manage to write a unit test for this (in a later PR), that would be quite a step forward ;) We don't really have any of that sort yet, but it would definitely be good. The biggest obstacle might be rendering web components in tests that run on Node." - Fabian

Sub-issues

Metadata

Metadata

Assignees

Labels

epicCollection of multiple issues for a larger feature

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions