feat: upgrade linter and fix lint

Author: RaphReynaud

Makefile

@@ -1,6 +1,6 @@
 NAME = stream-cli
 
-GOLANGCI_VERSION = 1.55.2
+GOLANGCI_VERSION = 1.62.2
 GOLANGCI = .bin/golangci/$(GOLANGCI_VERSION)/golangci-lint
 $(GOLANGCI):
 	@curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(dir $(GOLANGCI)) v$(GOLANGCI_VERSION)

pkg/cmd/chat/channel/channel.go

@@ -551,7 +551,7 @@ func hideCmd() *cobra.Command {
 				return err
 			}
 
-			cmd.Printf("Successfully hid channel for " + userID + "\n")
+			cmd.Printf("Successfully hid channel for %s\n", userID)
 			return nil
 		},
 	}

pkg/cmd/raw-recording/mix_audio.go

@@ -70,7 +70,7 @@ func runMixAudio(cmd *cobra.Command, args []string) error {
 
 	// Mix all audio tracks
 	mixer := processing.NewAudioMixer(logger)
-	mixer.MixAllAudioTracks(&processing.AudioMixerConfig{
+	_, _ = mixer.MixAllAudioTracks(&processing.AudioMixerConfig{
 		WorkDir:         globalArgs.WorkDir,
 		OutputDir:       globalArgs.Output,
 		WithScreenshare: true,

pkg/cmd/raw-recording/process_all.go

@@ -143,7 +143,7 @@ func runProcessAll(cmd *cobra.Command, args []string) error {
 
 	// Mix all audio tracks
 	mixer := processing.NewAudioMixer(logger)
-	mixer.MixAllAudioTracks(&processing.AudioMixerConfig{
+	_, _ = mixer.MixAllAudioTracks(&processing.AudioMixerConfig{
 		WorkDir:         globalArgs.WorkDir,
 		OutputDir:       globalArgs.Output,
 		WithScreenshare: false,

pkg/cmd/raw-recording/processing/container_converter.go

@@ -27,7 +27,6 @@ type RTPDump2WebMConverter struct {
 	recorder      WebmRecorder
 	sampleBuilder *samplebuilder.SampleBuilder
 
-	firstPkt        *rtp.Packet
 	lastPkt         *rtp.Packet
 	lastPktDuration uint32
 	dtxInserted     uint64
@@ -341,10 +340,6 @@ func opusFrameCount(c byte, payload []byte) int {
 	return 0
 }
 
-func (c *RTPDump2WebMConverter) offset(pts, fts uint32) int64 {
-	return int64(c.timestampDiff(pts, fts) / 90)
-}
-
 func (c *RTPDump2WebMConverter) timestampDiff(pts, fts uint32) uint32 {
 	return pts - fts
 }

pkg/cmd/raw-recording/processing/ffmpeg_helper.go

@@ -198,9 +198,9 @@ func runFFmpegCommand(args []string, logger *ProcessingLogger) error {
 
 	if err != nil {
 		logger.Errorf("FFmpeg process pid<%d> failed: %v", cmd.Process.Pid, err)
-		return fmt.Errorf("FFmpeg process pid<%d> failed in %s: %w", cmd.Process.Pid, time.Now().Sub(startAt).Round(time.Millisecond), err)
+		return fmt.Errorf("FFmpeg process pid<%d> failed in %s: %w", cmd.Process.Pid, time.Since(startAt).Round(time.Millisecond), err)
 	}
 
-	logger.Infof("FFmpeg process pid<%d> ended successfully in %s", cmd.Process.Pid, time.Now().Sub(startAt).Round(time.Millisecond))
+	logger.Infof("FFmpeg process pid<%d> ended successfully in %s", cmd.Process.Pid, time.Since(startAt).Round(time.Millisecond))
 	return nil
 }

pkg/cmd/raw-recording/processing/gstreamer_converter.go

@@ -248,14 +248,14 @@ func (r *GstreamerConverter) Close() error {
 
 		select {
 		case <-time.After(5 * time.Second):
-			r.logger.Warnf("GStreamer process pid<%d> termination timeout in %s...", r.gstreamerCmd.Process.Pid, time.Now().Sub(r.startAt).Round(time.Millisecond))
+			r.logger.Warnf("GStreamer process pid<%d> termination timeout in %s...", r.gstreamerCmd.Process.Pid, time.Since(r.startAt).Round(time.Millisecond))
 
 			// Timeout, force kill
 			if e := r.gstreamerCmd.Process.Kill(); e != nil {
 				r.logger.Errorf("GStreamer process pid<%d> errored while killing: %v", r.gstreamerCmd.Process.Pid, e)
 			}
 		case <-done:
-			r.logger.Infof("GStreamer process pid<%d> exited succesfully in %s...", r.gstreamerCmd.Process.Pid, time.Now().Sub(r.startAt).Round(time.Millisecond))
+			r.logger.Infof("GStreamer process pid<%d> exited succesfully in %s...", r.gstreamerCmd.Process.Pid, time.Since(r.startAt).Round(time.Millisecond))
 		}
 	}
 

pkg/cmd/raw-recording/processing/sdp_tool.go

@@ -16,23 +16,6 @@ func readSDP(sdpFilePath string) (string, error) {
 	return string(content), nil
 }
 
-func replaceSDP(sdpContent string, port int) string {
-	lines := strings.Split(sdpContent, "\n")
-	for i, line := range lines {
-		if strings.HasPrefix(line, "m=") {
-			// Parse the m= line: m=<media_type> <port> RTP/AVP <payload_type>
-			parts := strings.Fields(line)
-			if len(parts) >= 4 {
-				// Replace the port (second field)
-				parts[1] = fmt.Sprintf("%d", port)
-				lines[i] = strings.Join(parts, " ")
-				break
-			}
-		}
-	}
-	return strings.Join(lines, "\n")
-}
-
 func mimeType(sdp string) (string, error) {
 	upper := strings.ToUpper(sdp)
 	if strings.Contains(upper, "VP9") {

test/helpers.go

@@ -6,7 +6,6 @@ import (
 	"math/rand"
 	"os"
 	"testing"
-	"time"
 
 	stream "github.com/GetStream/stream-chat-go/v5"
 	"github.com/spf13/cobra"
@@ -91,7 +90,6 @@ func DeleteMessage(id string) {
 }
 
 func RandomString(n int) string {
-	rand.Seed(time.Now().UnixNano())
 	bytes := make([]byte, n)
 	for i := 0; i < n; i++ {
 		bytes[i] = byte(65 + rand.Intn(25)) // A=65 and Z = 65+25